Your message dated Sun, 07 Dec 2008 17:47:07 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#497917: fixed in ncmpc 0.12-1
has caused the Debian Bug report #497917,
regarding ncmpc: crash with "timedisplay-type = remaining" in config
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
497917: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=497917
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: ncmpc
Version: 0.11.1+svn-r3965-2
Tags: patch
When one sets "timedisplay-type = remaining" in the config,
ncmpc will crash with a strange looking libc memory corruption
error.
I found the reason to be the initialisation of the variable
options.timedisplay_type in src/options.c:371, which does not
work as expected, if at all.
When one sets "timedisplay-type = remaining" in the config, the
g_free() in src/conf.c:477 fails because there is no memory
allocated but options.timedisplay_type != NULL, this gives
the libc errors.
The solution is to use g_strdup() to allocate the memory for
the string. I have attached a patch vs. the current svn
revision (7398), but it applied to the debian sources as well.
I also sent this report to upstream, but there was no action (yet):
http://www.musicpd.org/mantis/view.php?id=1720
Cheers,
Stefan.
diff -dupr ncmpc.svn/src/options.c ncmpc.fix/src/options.c
--- ncmpc.svn/src/options.c 2006-06-29 16:07:25.000000000 +0200
+++ ncmpc.fix/src/options.c 2008-08-08 14:49:16.000000000 +0200
@@ -368,7 +368,7 @@ options_init( void )
options.crossfade_time = DEFAULT_CROSSFADE_TIME;
options.seek_time = 1;
options.screen_list = g_strsplit_set(DEFAULT_SCREEN_LIST, " ", 0);
- options.timedisplay_type = DEFAULT_TIMEDISPLAY_TYPE;
+ options.timedisplay_type = g_strdup(DEFAULT_TIMEDISPLAY_TYPE);
return &options;
}
--- End Message ---
--- Begin Message ---
Source: ncmpc
Source-Version: 0.12-1
We believe that the bug you reported is fixed in the latest version of
ncmpc, which is due to be installed in the Debian FTP archive:
ncmpc_0.12-1.diff.gz
to pool/main/n/ncmpc/ncmpc_0.12-1.diff.gz
ncmpc_0.12-1.dsc
to pool/main/n/ncmpc/ncmpc_0.12-1.dsc
ncmpc_0.12-1_amd64.deb
to pool/main/n/ncmpc/ncmpc_0.12-1_amd64.deb
ncmpc_0.12.orig.tar.gz
to pool/main/n/ncmpc/ncmpc_0.12.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastian Harl <[EMAIL PROTECTED]> (supplier of updated ncmpc package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 07 Dec 2008 17:34:07 +0100
Source: ncmpc
Binary: ncmpc
Architecture: source amd64
Version: 0.12-1
Distribution: experimental
Urgency: low
Maintainer: Sebastian Harl <[EMAIL PROTECTED]>
Changed-By: Sebastian Harl <[EMAIL PROTECTED]>
Description:
ncmpc - ncurses-based audio player
Closes: 395407 447781 471761 496450 497359 497917
Changes:
ncmpc (0.12-1) experimental; urgency=low
.
* New upstream release:
- Added support for wide characters (Closes: #395407).
- Fixed a segfault when working with empty or removed directories
(Closes: #471761).
- Added command "locate" ('G') which locates a song in the database
browser; thanks to Hagen Fuchs for the original patch (Closes: #496450).
- Fixed connection handling (Closes: #497359).
- Fixed handling of the "timedisplay-type" config option; thanks to Stefan
Bender for the original patch (Closes: #497917).
* Uploading to experimental because of the Lenny freeze.
* debian/control:
- Added Homepage and Vcs-{Git,Browser} fields.
- Added versioned build dependency on dpkg-dev (>= 1.14.6) to support the
new fields.
- Suggest (instead of recommend) mpd - server and client may run on
different host, so not having both packages installed is not unusual
(Closes: #447781).
- Updated to Standards-Version 3.8.0.
- Build-depend on liblircclient-dev - this is required for lirc support.
- Suggest python and ruby - these are required by the lyrics scripts.
- Updated package description.
* debian/watch:
- Query sf.net instead of the old upstream website.
- Use uversionmangle to mangle "_alpha" and "_beta".
* debian/rules:
- Do not try to install upstream ChangeLog and TODO files - they no longer
exist.
- Do not ignore "make distclean" errors.
- -I/usr/include/ncursesw is no longer required - it's now handled by the
upstream configure script.
- Explicitly enable all features when running the configure script.
* debian/menu:
- Use section "Applications" instead of "Apps".
Checksums-Sha1:
46d907ef0e374571e7258faa78615d41fcd27414 1155 ncmpc_0.12-1.dsc
e6e12a69300de9a00b0a75a89d2718d78a120fd1 252763 ncmpc_0.12.orig.tar.gz
7f5eab985c52adeb3eb00dd57b2bd4ab650bc3d6 5882 ncmpc_0.12-1.diff.gz
f7ce85596a7971b4bcb28307671d66c7549182e9 103282 ncmpc_0.12-1_amd64.deb
Checksums-Sha256:
9ca6dc6e07b4f4fec4f71febe21a9c119b76287c7e93a28c0754484137a17956 1155
ncmpc_0.12-1.dsc
5d09205ef4c66715c84f0859f0d01dd946bfc586339f1da0b6825a030307db4a 252763
ncmpc_0.12.orig.tar.gz
a67befee29d5df8ab7aa6eb6f4c9a41cf609dd258496ed94d57fc09949b8f89b 5882
ncmpc_0.12-1.diff.gz
7ec5cff5bfe078d62a77172d7136d259cdb53a063d0c4558be43972e84746232 103282
ncmpc_0.12-1_amd64.deb
Files:
1ee0fe719ee72937b95dc0eb22167119 1155 sound optional ncmpc_0.12-1.dsc
8a7cff66c859d037bda735662313d4b0 252763 sound optional ncmpc_0.12.orig.tar.gz
7b149c880df4a71e4b54d441626f39ed 5882 sound optional ncmpc_0.12-1.diff.gz
40da1cdd21532c9d628bc4f66d4e9129 103282 sound optional ncmpc_0.12-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkk8CBkACgkQ01u8mbx9AgqaDwCgltVfhQFl552JHPdH9R7EWxYu
XcoAoMG5VEbSr+6uqeDudhm3R3L7Xk+N
=SlOh
-----END PGP SIGNATURE-----
--- End Message ---
