Your message dated Mon, 29 Dec 2008 05:32:04 +0000
with message-id <[email protected]>
and subject line Bug#507346: fixed in dpkg 1.14.24
has caused the Debian Bug report #507346,
regarding /usr/bin/dpkg-shlibdeps: combines all dependency templates when 
Build-Depends-Package is set
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
507346: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507346
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dpkg-dev
Version: 1.14.23
Severity: important
File: /usr/bin/dpkg-shlibdeps
Tags: patch

Hello,

when Build-Depends-Package is set in the symbols file, dpkg-shlibdeps always
combines main and all alternative dependency templates into resulting shlibs
substvar. It is done regardless which symbols with what dependency templates
actually matched. I'm marking this bug as important as it violates          
deb-symbols(5) specification and causes unexpected end result. The fix      
(attached) is very trivial 3-line fix though, it could even go to lenny.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (101, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.27-1-amd64 (SMP w/1 CPU core)
Locale: LANG=lt_LT.UTF-8, LC_CTYPE=lt_LT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages dpkg-dev depends on:
ii  binutils            2.18.1~cvs20080103-7 The GNU assembler, linker and bina
ii  bzip2               1.0.5-1              high-quality block-sorting file co
ii  cpio                2.9-14               GNU cpio -- a program to manage ar
ii  dpkg                1.14.23              Debian package management system
ii  libtimedate-perl    1.1600-9             Time and date functions for Perl
ii  lzma                4.43-14              Compression method of 7z format in
ii  make                3.81-5               The GNU version of the "make" util
ii  patch               2.5.9-5              Apply a diff file to an original
ii  perl [perl5]        5.10.0-18            Larry Wall's Practical Extraction 
ii  perl-modules        5.10.0-18            Core Perl modules

Versions of packages dpkg-dev recommends:
ii  build-essential               11.4       Informational list of build-essent
ii  gcc [c-compiler]              4:4.3.2-2  The GNU C compiler
ii  gcc-4.1 [c-compiler]          4.1.2-23   The GNU C compiler
ii  gcc-4.3 [c-compiler]          4.3.2-1    The GNU C compiler

Versions of packages dpkg-dev suggests:
pn  debian-keyring                <none>     (no description available)
ii  gnupg                         1.4.9-3    GNU privacy guard - a free PGP rep

-- no debconf information

>From 7a158372f1d19d5414525b72af2346f0a8d605ee Mon Sep 17 00:00:00 2001
From: Modestas Vainius <[email protected]>
Date: Sun, 30 Nov 2008 11:57:59 +0200
Subject: [PATCH] shlibdeps: do not combine all dependency templates when 
Build-Depends-Package is set.

Do not combine dependencies from main and all alternative templates
when Build-Depends-Package is set in the symbols file. The correct
behaviour is to update only existing dependencies with proper minver.

Signed-off-by: Modestas Vainius <[email protected]>
---
 scripts/dpkg-shlibdeps.pl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/dpkg-shlibdeps.pl b/scripts/dpkg-shlibdeps.pl
index 82a9a01..e9e7a75 100755
--- a/scripts/dpkg-shlibdeps.pl
+++ b/scripts/dpkg-shlibdeps.pl
@@ -328,7 +328,7 @@ foreach my $file (keys %exec) {
            my $minver = get_min_version_from_deps($build_deps, $dev_pkg);
            if (defined $minver) {
                foreach my $dep ($symfile->get_dependencies($soname)) {
-                   update_dependency_version($dep, $minver);
+                   update_dependency_version($dep, $minver, 1);
                }
            }
        }
@@ -526,7 +526,7 @@ sub get_min_version_from_deps {
 }
 
 sub update_dependency_version {
-    my ($dep, $minver) = @_;
+    my ($dep, $minver, $existing_only) = @_;
     return if not defined($minver);
     foreach my $subdep (split /\s*,\s*/, $dep) {
        if (exists $dependencies{$cur_field}{$subdep} and
@@ -538,7 +538,7 @@ sub update_dependency_version {
            {
                $dependencies{$cur_field}{$subdep} = $minver;
            }
-       } else {
+       } elsif (!$existing_only) {
            $dependencies{$cur_field}{$subdep} = $minver;
        }
     }
-- 
1.5.6.5

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
--- Begin Message ---
Source: dpkg
Source-Version: 1.14.24

We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive:

dpkg-dev_1.14.24_all.deb
  to pool/main/d/dpkg/dpkg-dev_1.14.24_all.deb
dpkg_1.14.24.dsc
  to pool/main/d/dpkg/dpkg_1.14.24.dsc
dpkg_1.14.24.tar.gz
  to pool/main/d/dpkg/dpkg_1.14.24.tar.gz
dpkg_1.14.24_i386.deb
  to pool/main/d/dpkg/dpkg_1.14.24_i386.deb
dselect_1.14.24_i386.deb
  to pool/main/d/dpkg/dselect_1.14.24_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillem Jover <[email protected]> (supplier of updated dpkg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 29 Dec 2008 05:38:31 +0100
Source: dpkg
Binary: dpkg dpkg-dev dselect
Architecture: source i386 all
Version: 1.14.24
Distribution: unstable
Urgency: low
Maintainer: Dpkg Developers <[email protected]>
Changed-By: Guillem Jover <[email protected]>
Description: 
 dpkg       - Debian package management system
 dpkg-dev   - Debian package development tools
 dselect    - Debian package management front-end
Closes: 506139 507217 507219 507346 508392 509150 509424 509887
Changes: 
 dpkg (1.14.24) unstable; urgency=low
 .
   [ Raphael Hertzog ]
   * Fix parsing of objdump output (by dpkg-shlibdeps) in a special case where
     the symbol name is separated only with a single space. Closes: #506139
   * Fix dpkg-shlibdeps behaviour when Build-Depends-Package is used in the
     symbols file. It was merging all dependency templates into the generated
     dependency instead of simply modifying the minimal version. Thanks to
     Modestas Vainius <[email protected]>. Closes: #507346
   * Fix dpkg-source to correctly extract a source package even when called
     from a non-writable directory when a target directory has been specified
     on the command line. Closes: #507217, #507219
 .
   [ Guillem Jover ]
   * Do not allow installing packages with non-obsolete conffiles owned by
     other packages without a proper Replaces field. Closes: #508392
 .
   [ Updated dselect translations ]
   * Galician (Marce Villarino). Closes: #509887
 .
   [ Updated dpkg translations ]
   * Galician (Marce Villarino). Closes: #509150
   * Vietnamese (Clytie Siddall). Closes: #509424
 .
   [ Updated scripts translations ]
   * Improve German translation.
Checksums-Sha1: 
 90fb7664755d275097d563dab63b2e137f94b325 1215 dpkg_1.14.24.dsc
 cb24965fe2278f0f72338d9aeafd7764a62a43da 6813642 dpkg_1.14.24.tar.gz
 99724f0aa5de5c8cf8f518a294e9b06bde1172f4 2340728 dpkg_1.14.24_i386.deb
 7988ef6a7e0c548f060197899585c62a77663bce 789386 dselect_1.14.24_i386.deb
 a4c48e6f01b4eef71fc37f415e62d55ad7f34200 764370 dpkg-dev_1.14.24_all.deb
Checksums-Sha256: 
 00e4ad1590b6a169aa52069fcbd3b25e3d3cf1e640391ce6726cb3a04f2f876b 1215 
dpkg_1.14.24.dsc
 ce21cdae0981f2043715142e6b254b7e867e71e5d81b3b210c0e741b0b6e760c 6813642 
dpkg_1.14.24.tar.gz
 794c79af9ba44207d9f0f48beb1ca670b6899bdf88dc611032cc355fb6df3c22 2340728 
dpkg_1.14.24_i386.deb
 4184f05da5d401c2403718dee54404c9125dd22f65de45b423519301ad2334a9 789386 
dselect_1.14.24_i386.deb
 c8c119fa4ad160caee0ed052d7310f3d59de374cc55cff3b189113d0f0ec852f 764370 
dpkg-dev_1.14.24_all.deb
Files: 
 6bde50b234067db41befb08dd36ca5c8 1215 admin required dpkg_1.14.24.dsc
 36c784e66fdd311b90a05a4f234a758a 6813642 admin required dpkg_1.14.24.tar.gz
 77ef07a9573617b95d686ee5ed9a71d3 2340728 admin required dpkg_1.14.24_i386.deb
 19003fe0626d880aed65d3232538eab0 789386 admin optional dselect_1.14.24_i386.deb
 6ee9956ae5cbd0a2ab3a9bcf502edbc6 764370 utils optional dpkg-dev_1.14.24_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAklYVrQACgkQuW9ciZ2SjJsrSACgv4FE3XnhS0hCpOAH1qOHb7Ia
v84AnjIi9hFT4QGDichUp/uwyTShnKzs
=rxGV
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to