Your message dated Wed, 14 Jan 2009 09:17:15 +0000
with message-id <[email protected]>
and subject line Bug#507213: fixed in netdiag 1.0-13
has caused the Debian Bug report #507213,
regarding netdiag: Doesn't specify a mode when calling open() with O_CREAT
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
507213: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507213
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: netdiag
Version: 1.0-12
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu jaunty ubuntu-patch
Hi,
Your package calls open() with the O_CREAT but without specifying a
mode. open(2) says that this isn't allowed. The attached patch adds
the mode argument to the call, please consider applying it.
Thanks,
James
diff -u netdiag-1.0/netwatch-1.0c/netwatch.c
netdiag-1.0/netwatch-1.0c/netwatch.c
--- netdiag-1.0/netwatch-1.0c/netwatch.c
+++ netdiag-1.0/netwatch-1.0c/netwatch.c
@@ -2679,7 +2679,7 @@
work->plog = open(nam,O_APPEND|O_WRONLY);
if (work->plog<0)
{
- work->plog = open(nam,O_APPEND|O_CREAT|O_WRONLY);
+ work->plog = open(nam,O_APPEND|O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
st = write(work->plog,&starttime,sizeof(starttime));
st = write(work->plog,&simmagic,sizeof(simmagic));
}
--- End Message ---
--- Begin Message ---
Source: netdiag
Source-Version: 1.0-13
We believe that the bug you reported is fixed in the latest version of
netdiag, which is due to be installed in the Debian FTP archive:
netdiag_1.0-13.diff.gz
to pool/main/n/netdiag/netdiag_1.0-13.diff.gz
netdiag_1.0-13.dsc
to pool/main/n/netdiag/netdiag_1.0-13.dsc
netdiag_1.0-13_amd64.deb
to pool/main/n/netdiag/netdiag_1.0-13_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Meskes <[email protected]> (supplier of updated netdiag package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 13 Jan 2009 15:57:48 +0100
Source: netdiag
Binary: netdiag
Architecture: source amd64
Version: 1.0-13
Distribution: unstable
Urgency: low
Maintainer: Michael Meskes <[email protected]>
Changed-By: Michael Meskes <[email protected]>
Description:
netdiag - Net-Diagnostics (trafshow,strobe,netwatch,statnet,tcpspray,tcpbla
Closes: 507213 510898
Changes:
netdiag (1.0-13) unstable; urgency=low
.
* Applied patch by James Westby <[email protected]> to make open(2)
usage standard conform, closes: #507213
* Updated Japanese debconf translation, closes: #510898
* Made init script not call itself.
Checksums-Sha1:
785f898836777afa29a530f7632e6afc465c07ab 989 netdiag_1.0-13.dsc
3f40f9d7e675751cefa1b75bff1002ffc106b0f1 112343 netdiag_1.0-13.diff.gz
88a80bc0edf706118637a05514861c585e4c9cbf 298946 netdiag_1.0-13_amd64.deb
Checksums-Sha256:
a4b166616418926ede566f66cefd495f13f7ded86566d1b5f5c42dab3c543062 989
netdiag_1.0-13.dsc
33ff7919605febb8205977b1def003c1ecda0d2e72f4cfb9ade5321dc60b18e7 112343
netdiag_1.0-13.diff.gz
da88b5d7a87a854ba2c7b44d97d481377f6dc31e30d3f593d9302745abb1235a 298946
netdiag_1.0-13_amd64.deb
Files:
bc76992184c1a644ad5bf5bcfd70e076 989 net extra netdiag_1.0-13.dsc
b41e362134813dd82eee99f13e94a70e 112343 net extra netdiag_1.0-13.diff.gz
bae2dba0e95b6252e8e9602b25efef75 298946 net extra netdiag_1.0-13_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iD8DBQFJbacHVkEm8inxm9ERAvT5AJ0eQWCTib/4XIvCmmvU4VbyTSt/WACghHVE
e5XpHHKmecvnmKqRju8Oyew=
=drJm
-----END PGP SIGNATURE-----
--- End Message ---
