Your message dated Sat, 17 Jan 2009 18:23:04 +0100 (MET)
with message-id <pine.soc.4.64.0901171809270.25...@fiesta>
and subject line solved in 3.0.0~cvs20081223-2
has caused the Debian Bug report #512043,
regarding Fails to build with itk 3.10, and also without uuid-dev
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
512043: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512043
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: igstk
Version: 3.0.0~cvs20080716-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

Your package failed to build on Ubuntu, with itk 3.10, as the check
for the version of itk uses the normal CMake comparison, which deems
3.10 to be less than the required 3.4. Instead of LESS etc. it should
use VERSION_LESS etc., which were introduced in CMake 3.6.2.

Also, I had to add uuid-dev to the Build-Depends in order to build the
package, as it looked for /usr/lib/libuuid.so during the build.

Please consider making these changes.

Thanks,

James
diff -u igstk-3.0.0~cvs20080716/debian/changelog 
igstk-3.0.0~cvs20080716/debian/changelog
diff -u igstk-3.0.0~cvs20080716/debian/patches/00list 
igstk-3.0.0~cvs20080716/debian/patches/00list
--- igstk-3.0.0~cvs20080716/debian/patches/00list
+++ igstk-3.0.0~cvs20080716/debian/patches/00list
@@ -2,0 +3 @@
+91_use_version_compare.dpatch
only in patch2:
unchanged:
--- igstk-3.0.0~cvs20080716.orig/debian/patches/91_use_version_compare.dpatch
+++ igstk-3.0.0~cvs20080716/debian/patches/91_use_version_compare.dpatch
@@ -0,0 +1,53 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 91_use_version_compare.dpatch by  <[email protected]>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Use VERSION_LESS etc. for comparing version numbers so that
+## DP: 3.10 > 3.4. Requires CMake 2.6.2. Fixes build with itk 3.10 and
+## DP: higher.
+
+...@dpatch@
+diff -urNad igstk-3.0.0~cvs20080716~/CMakeLists.txt 
igstk-3.0.0~cvs20080716/CMakeLists.txt
+--- igstk-3.0.0~cvs20080716~/CMakeLists.txt    2009-01-16 16:47:26.000000000 
+0000
++++ igstk-3.0.0~cvs20080716/CMakeLists.txt     2009-01-16 16:48:38.000000000 
+0000
+@@ -1,4 +1,4 @@
+-CMAKE_MINIMUM_REQUIRED(VERSION 2.4)
++CMAKE_MINIMUM_REQUIRED(VERSION 2.6.2)
+ IF(COMMAND CMAKE_POLICY)
+   CMAKE_POLICY(SET CMP0003 NEW)
+ ENDIF(COMMAND CMAKE_POLICY)
+@@ -56,24 +56,24 @@
+ #  Use the correct ITK & VTK version 
+ IF( IGSTK_DEVELOPMENT_VERSION )
+ # development version
+-   IF( ${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} LESS 3.4)
++   IF( ${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} VERSION_LESS 3.4)
+       MESSAGE(FATAL_ERROR "You are using ITK 
${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR}. Use ITK version 3.4 or later")
+-   ENDIF(${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} LESS 3.4 )
+-   IF( ${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} LESS 5.0 )
++   ENDIF(${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} VERSION_LESS 3.4 )
++   IF( ${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} VERSION_LESS 5.0 )
+      MESSAGE(FATAL_ERROR "You are using VTK 
${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION}. Use VTK version 5.0 or later")
+-   ENDIF(${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} LESS 5.0 )
++   ENDIF(${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} VERSION_LESS 5.0 )
+ ELSE( IGSTK_DEVELOPMENT_VERSION ) 
+ # stable version
+-   IF( ${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} EQUAL 3.4 )
++   IF( ${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} VERSION_EQUAL 3.4 )
+       # correct version
+-   ELSE( ${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} EQUAL 3.4 )
++   ELSE( ${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} VERSION_EQUAL 3.4 )
+       MESSAGE(FATAL_ERROR "You are using ITK 
${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR}. Use ITK version 3.4")
+-   ENDIF( ${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} EQUAL 3.4)
+-   IF( ${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} EQUAL 5.0 )
++   ENDIF( ${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR} VERSION_EQUAL 3.4)
++   IF( ${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} VERSION_EQUAL 5.0 )
+       # correct version
+-   ELSE( ${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} EQUAL 5.0 )
++   ELSE( ${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} VERSION_EQUAL 5.0 )
+      MESSAGE(FATAL_ERROR "You are using VTK 
${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION}. Use VTK version 5.0")
+-   ENDIF( ${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} EQUAL 5.0 )
++   ENDIF( ${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION} VERSION_EQUAL 5.0 )
+ ENDIF( IGSTK_DEVELOPMENT_VERSION ) 
+ 
+ #

--- End Message ---
--- Begin Message ---
Hi,

Thank you for the bug report. The issues you described are already solved in the last Debian package. I will close the bug report.

Cheers
Dominique


--- End Message ---

Reply via email to