Your message dated Fri, 13 Feb 2009 23:32:45 +0100
with message-id <[email protected]>
and subject line Re: Bug#515133: shellsink: Shellsink crashes if
.bash_history_timestamp is empty
has caused the Debian Bug report #515133,
regarding shellsink: Shellsink crashes if .bash_history_timestamp is empty
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
515133: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=515133
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: shellsink
Version: 0.1.7
Severity: normal
Tags: patch
Hello,
shellsink crashes if ${HOME}/.bash_history_timestamp is empty.
Traceback of the issue (after removing the content of .bash_history_timestamp):
File "/usr/bin/shellsink-client", line 222, in <module>
main()
File "/usr/bin/shellsink-client", line 219, in main
client.send_command()
File "/usr/bin/shellsink-client", line 56, in send_command
if self.has_new_command():
File "/usr/bin/shellsink-client", line 87, in has_new_command
last_recorded_history_timestamp = self.last_recorded_history_timestamp()
File "/usr/bin/shellsink-client", line 100, in last_recorded_history_timestamp
old_history_timestamp = float(file.readline())
ValueError: empty string for float()
Removing that file fixes the issue.
The bug appears to be in line 98 of /usr/bin/shellsink-client.
Patch:
Change line 98 of /usr/bin/shellsink-client from:
if os.path.exists(self.history_timestamp):
to
if os.path.exists(self.history_timestamp) and
os.path.getsize(self.history_timestamp)>0 :
fixes the bug.
Regards,
Luca Invernizzi
-- System Information:
Debian Release: 5.0
APT prefers unstable
APT policy: (900, 'unstable'), (600, 'experimental'), (600, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages shellsink depends on:
ii python 2.5.2-3 An interactive high-level object-o
shellsink recommends no packages.
shellsink suggests no packages.
-- no debconf information
--- End Message ---
--- Begin Message ---
* Luca Invernizzi <[email protected]> [2009-02-13 22:08]:
> You're right. It comes from launchpad.net
> Sorry, I just assumed it was from Debian: I'll submit it in the right
> place.
OK, closing.
--
Martin Michlmayr
http://www.cyrius.com/
--- End Message ---
