Your message dated Tue, 3 Mar 2009 15:57:46 +0100
with message-id <[email protected]>
and subject line closing bug
has caused the Debian Bug report #370399,
regarding backuppc: Don't rotate empty logfiles at the beginning of the month
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
370399: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=370399
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: backuppc
Version: 2.1.2-4
Severity: wishlist
Tags: patch

Hi,

backuppc rotates the client logfiles in the first night of the month.
But clients that are configured to not do any regular backups
($Conf{FullPeriod} < 0) and didn't do any manually triggered backups
don't produce any log entries, so rotating the logs is superfluous.

I attach a one line patch that skips the rotate if the logfile is empty.


Andreas
Index: bin/BackupPC_nightly
===================================================================
RCS file: /cvsroot/backuppc/BackupPC/bin/BackupPC_nightly,v
retrieving revision 1.18
diff -u -r1.18 BackupPC_nightly
--- bin/BackupPC_nightly        29 Jan 2006 19:05:11 -0000      1.18
+++ bin/BackupPC_nightly        30 May 2006 01:19:38 -0000
@@ -227,6 +227,7 @@
     my($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime(time);
     if ( $mday == 1 ) {
         foreach my $host ( keys(%Status) ) {
+            next if -z "$TopDir/pc/$host/LOG";
             my $lastLog = $Conf{MaxOldPerPCLogFiles} - 1;
             unlink("$TopDir/pc/$host/LOG.$lastLog")
                     if ( -f "$TopDir/pc/$host/LOG.$lastLog" );

--- End Message ---
--- Begin Message ---
Hi !

With the Debian Lenny release, the bug you reported is related to a
package version not supported by Debian anymore, so I close this bug.

Regards,

-- 
Ludovic Drolez.

http://www.palmopensource.com               - The PalmOS Open Source Portal
http://www.drolez.com      - Personal site - Linux, Zaurus and PalmOS stuff


--- End Message ---

Reply via email to