Your message dated Sun, 08 Mar 2009 06:02:04 +0000
with message-id <[email protected]>
and subject line Bug#485262: fixed in passage 3+dfsg1-3
has caused the Debian Bug report #485262,
regarding passage: FTBFS when converted to new source format 3.0 (quilt): 
require -p0 for some patches
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
485262: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=485262
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: passage
Version: 3+dfsg1-2
Severity: wishlist
Usertags: 3.0-quilt-by-default

To prepare a possible switch to the new source package format "3.0
(quilt)" [1], I converted all source packages and tried to rebuild them.
Unfortunately, passage failed, you can try yourself with those
commands (and dpkg-dev >= 1.14.19 [2]) :

$ apt-get source passage
$ sed -i -e '/^Source:/ aFormat: 3.0 (quilt)' passage-3+dfsg1/debian/control
$ dpkg-source -b passage-3+dfsg1
$ dpkg-source -x passage_3+dfsg1-2.dsc
$ cd passage-3+dfsg1 && debuild -us -uc

In this process, if the .diff.gz contains changes to upstream files,
dpkg-source will have created a corresponding patch in
debian/patches/debian-changes-3+dfsg1-2 and will have registered that
patch in a quilt series (debian/patches/series, it is created if needed).
All the patches listed in the "series" file are applied directly during
the extraction (dpkg-source -x). quilt itself is used if available (and
will thus lead to the creation of the .pc directory), otherwise
dpkg-source applies the patches by itself. For more information about the
new source package format see the manual page dpkg-source(1).

In the case of passage, it already uses quilt but some of the patches
require the '-p0' option of patch to be properly applied and this
option has been hardcoded in the series file. The new source package
format doesn't support this quilt feature and requires patches
to be applicable with the '-p1' option.

You can use the following command to easily update all the patches
that use the '-p0' option:
awk '{ if ($2 == "-p0") print $1 }' debian/patches/series | while read f; do 
perl -pi -e 's|^--- (?:\./)?|--- a/|; s|^\+\+\+ (?:\./)?|+++ b/|;' 
debian/patches/$f ; done

Not that you can replace "a" by "passage-3+dfsg1.orig" and
"b" by "passage-3+dfsg1" if you prefer.

Then don't forget to strip the "-p0" options from debian/patches/series.

As a side note, you must also pay attention to the following points in your
quilt usage to guarantee compatibility with the new source package
format:
- the patches must be in debian/patches/ together with the "series" file
  (you can use QUILT_PATCHES=debian/patches if needed)
- you should not override QUILT_PC to change the location of quilt's
  internal directory (".pc" by default)
- the patches should not reference absolute filenames (in +++/--- lines)
- your clean target must work even if the patches are already applied
- your build target must work with patches applied even if the clean
  target is supposed to unapply them (because dpkg-source -b might
  have applied them back)

Cheers,

[1] http://lists.debian.org/debian-devel-announce/2008/04/msg00004.html
[2] the upcoming dpkg-dev 1.14.20 is more tolerant with patches, you can
grab it here if you want to try with that version:
http://people.debian.org/~hertzog/packages/dpkg-dev_1.14.20_all.deb
-- 
Raphael Hertzog




--- End Message ---
--- Begin Message ---
Source: passage
Source-Version: 3+dfsg1-3

We believe that the bug you reported is fixed in the latest version of
passage, which is due to be installed in the Debian FTP archive:

passage_3+dfsg1-3.diff.gz
  to pool/main/p/passage/passage_3+dfsg1-3.diff.gz
passage_3+dfsg1-3.dsc
  to pool/main/p/passage/passage_3+dfsg1-3.dsc
passage_3+dfsg1-3_amd64.deb
  to pool/main/p/passage/passage_3+dfsg1-3_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Paul Wise <[email protected]> (supplier of updated passage package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 08 Mar 2009 14:47:54 +0900
Source: passage
Binary: passage
Architecture: source amd64
Version: 3+dfsg1-3
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <[email protected]>
Changed-By: Paul Wise <[email protected]>
Description: 
 passage    - game about the passage through life
Closes: 485262
Changes: 
 passage (3+dfsg1-3) unstable; urgency=low
 .
   [ Cyril Brulebois ]
   * Fix FTBFS with new “3.0 (quilt)” source package format by using a
     patch level of 1 instead of 0 in the patches and by adjusting the
     series file appropriately (i.e. by deleting the “-p0” option),
     thanks to Raphaël Hertzog for the notice (Closes: #485262).
 .
   [ Paul Wise ]
   * Update Standards-Version, changes needed are:
     - include quilt.make to create a patch target
     - use filter instead of findstring on DEB_BUILD_OPTIONS
     - support parallel=n in DEB_BUILD_OPTIONS
     - add a README.source file pointing to the quilt one
   * Add proper version mangling to the watch file
   * Bump debhelper compat level to 7
   * Add forwarded locations to patch, menu, manual page
Checksums-Sha1: 
 1c8d878ed8dcbfca448dc78a2cab7f58fc322114 1244 passage_3+dfsg1-3.dsc
 0d699cda0e5a15dcd24b97d920a046b80f4c98e4 7382 passage_3+dfsg1-3.diff.gz
 e8c18a8944ab5596aaa6f335962f29a411951d24 55468 passage_3+dfsg1-3_amd64.deb
Checksums-Sha256: 
 6cd7831b91d0abe9b3f177d3867bcbfc522fa1585edbba77fbc6ebf6f10e559f 1244 
passage_3+dfsg1-3.dsc
 0b2ab5d9b80ba9e7c41980114e95a9de8f7704174b7ff2f816189bc0672582a8 7382 
passage_3+dfsg1-3.diff.gz
 24fe41fb4629ee00e440e972dafc2c49c967e08ebb147cc177e29fec58ad24e1 55468 
passage_3+dfsg1-3_amd64.deb
Files: 
 186a0b233e7d789c8639c41133d335f3 1244 games extra passage_3+dfsg1-3.dsc
 80854f3f044ee6c84c6f2169bfe98414 7382 games extra passage_3+dfsg1-3.diff.gz
 60c3b16fc51071fdccfe5330175f3a02 55468 games extra passage_3+dfsg1-3_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmzXgcACgkQ5Sc9mGvjxCMiNQCeLMaGJ1yJh/p0QJaLXkAyaY6q
vDsAoKxK3wLqiJ8ipboig5zH/OBpNYUz
=GntY
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to