Your message dated Sun, 08 Mar 2009 07:47:08 +0000
with message-id <[email protected]>
and subject line Bug#485257: fixed in gravitation 3+dfsg1-2
has caused the Debian Bug report #485257,
regarding gravitation: FTBFS when converted to new source format 3.0 (quilt): 
require -p0 for some patches
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
485257: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=485257
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gravitation
Version: 3+dfsg1-1
Severity: wishlist
Usertags: 3.0-quilt-by-default

To prepare a possible switch to the new source package format "3.0
(quilt)" [1], I converted all source packages and tried to rebuild them.
Unfortunately, gravitation failed, you can try yourself with those
commands (and dpkg-dev >= 1.14.19 [2]) :

$ apt-get source gravitation
$ sed -i -e '/^Source:/ aFormat: 3.0 (quilt)' gravitation-3+dfsg1/debian/control
$ dpkg-source -b gravitation-3+dfsg1
$ dpkg-source -x gravitation_3+dfsg1-1.dsc
$ cd gravitation-3+dfsg1 && debuild -us -uc

In this process, if the .diff.gz contains changes to upstream files,
dpkg-source will have created a corresponding patch in
debian/patches/debian-changes-3+dfsg1-1 and will have registered that
patch in a quilt series (debian/patches/series, it is created if needed).
All the patches listed in the "series" file are applied directly during
the extraction (dpkg-source -x). quilt itself is used if available (and
will thus lead to the creation of the .pc directory), otherwise
dpkg-source applies the patches by itself. For more information about the
new source package format see the manual page dpkg-source(1).

In the case of gravitation, it already uses quilt but some of the patches
require the '-p0' option of patch to be properly applied and this
option has been hardcoded in the series file. The new source package
format doesn't support this quilt feature and requires patches
to be applicable with the '-p1' option.

You can use the following command to easily update all the patches
that use the '-p0' option:
awk '{ if ($2 == "-p0") print $1 }' debian/patches/series | while read f; do 
perl -pi -e 's|^--- (?:\./)?|--- a/|; s|^\+\+\+ (?:\./)?|+++ b/|;' 
debian/patches/$f ; done

Not that you can replace "a" by "gravitation-3+dfsg1.orig" and
"b" by "gravitation-3+dfsg1" if you prefer.

Then don't forget to strip the "-p0" options from debian/patches/series.

As a side note, you must also pay attention to the following points in your
quilt usage to guarantee compatibility with the new source package
format:
- the patches must be in debian/patches/ together with the "series" file
  (you can use QUILT_PATCHES=debian/patches if needed)
- you should not override QUILT_PC to change the location of quilt's
  internal directory (".pc" by default)
- the patches should not reference absolute filenames (in +++/--- lines)
- your clean target must work even if the patches are already applied
- your build target must work with patches applied even if the clean
  target is supposed to unapply them (because dpkg-source -b might
  have applied them back)

Cheers,

[1] http://lists.debian.org/debian-devel-announce/2008/04/msg00004.html
[2] the upcoming dpkg-dev 1.14.20 is more tolerant with patches, you can
grab it here if you want to try with that version:
http://people.debian.org/~hertzog/packages/dpkg-dev_1.14.20_all.deb
-- 
Raphael Hertzog




--- End Message ---
--- Begin Message ---
Source: gravitation
Source-Version: 3+dfsg1-2

We believe that the bug you reported is fixed in the latest version of
gravitation, which is due to be installed in the Debian FTP archive:

gravitation_3+dfsg1-2.diff.gz
  to pool/main/g/gravitation/gravitation_3+dfsg1-2.diff.gz
gravitation_3+dfsg1-2.dsc
  to pool/main/g/gravitation/gravitation_3+dfsg1-2.dsc
gravitation_3+dfsg1-2_amd64.deb
  to pool/main/g/gravitation/gravitation_3+dfsg1-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Paul Wise <[email protected]> (supplier of updated gravitation package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 08 Mar 2009 15:28:26 +0900
Source: gravitation
Binary: gravitation
Architecture: source amd64
Version: 3+dfsg1-2
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <[email protected]>
Changed-By: Paul Wise <[email protected]>
Description: 
 gravitation - game about mania, melancholia, and the creative process
Closes: 485257
Changes: 
 gravitation (3+dfsg1-2) unstable; urgency=low
 .
   [ Paul Wise ]
   * Document using the Esc key to quit the game
   * Update Standards-Version, changes needed are:
     - include quilt.make to create a patch target
     - use filter instead of findstring on DEB_BUILD_OPTIONS
     - support parallel=n in DEB_BUILD_OPTIONS
     - add a README.source file pointing to the quilt one
   * Add proper version mangling to the watch file
   * Bump debhelper compat level to 7
   * Add forwarded locations to patch, menu, manual page
 .
   [ Cyril Brulebois ]
   * Fix FTBFS with new “3.0 (quilt)” source package format by using a
     patch level of 1 instead of 0 in the abs_path.patch patch and by
     adjusting the series file appropriately (i.e. by deleting the “-p0”
     option), thanks to Raphaël Hertzog for the notice (Closes: #485257).
Checksums-Sha1: 
 51e943a999012306e7d3601ffe912caeb7f8cc46 1288 gravitation_3+dfsg1-2.dsc
 500ee8f7642503c485a7645d339d35a7d4c94acc 5536 gravitation_3+dfsg1-2.diff.gz
 ab3d7e4703fcb6165db6f1045eb16643cd005f99 68960 gravitation_3+dfsg1-2_amd64.deb
Checksums-Sha256: 
 dc5a77464c3ee60e2f054410bb9c59dc50a7288dd3e57dbde847aef51c7217c8 1288 
gravitation_3+dfsg1-2.dsc
 deaced78dcf06917ab020ec24ce1134e02b2afc2d8e6e5a77e3f15c7613e185f 5536 
gravitation_3+dfsg1-2.diff.gz
 3bd526c4fccf4dab722781115e2b4e3d5db0e1f648241fff6732dfb9be769d7a 68960 
gravitation_3+dfsg1-2_amd64.deb
Files: 
 d3e617e2f962230e09cf75789cec8487 1288 games extra gravitation_3+dfsg1-2.dsc
 4297c8dc378f671eb244f04509ee0480 5536 games extra gravitation_3+dfsg1-2.diff.gz
 cc8ae3375aa3dcb42834e8a8b69338c7 68960 games extra 
gravitation_3+dfsg1-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmzdOkACgkQ5Sc9mGvjxCMECACfYw9J1LuUjm1NfByCwGfcBXnB
9mYAoL2xp7Vezz2B0Fmrfu4ZXEXEM2JK
=b3v1
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to