Your message dated Thu, 30 Apr 2009 15:32:13 +0000
with message-id <[email protected]>
and subject line Bug#525014: fixed in numactl 2.0.3~rc3-1
has caused the Debian Bug report #525014,
regarding libnuma1: wrong parsing to /proc/self/status causes wrong 
out-of-range errors
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
525014: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=525014
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libnuma1
Version: 2.0.3~rc1-1
Severity: important

Hello,

After upgrading a quad-socket quad-core machine from a custom 2.6.27
to Debian's 2.6.29, we were amazed to see that numactl now reports that
--physcpubind=X is an out-of-range CPU when 12<=X<16 (while obviously
we still have 16 cores in this machine). Same problem on other machines
with 2.6.29: the last 4 cores are out-of-range.

It appears that this is caused by set_thread_constraints() passing a
wrong pointer to read_mask() when trying to gather maxproccpu and
maxprocnode from /proc/self/status. It points to the second character
of the mask instead of the first one, thus loosing one "f", which means
4 cores are lost.

The kernel code generating the "Cpus_allowed:" and "Mems_allowed:" masks
in /proc/self/status has  changed recently, so maybe the formatting
changed a bit (whitespaces?).
The patch below fixes this problem by just passing a pointer to the first
character after ":" instead of trying to guess howmany whitespaces follow,
since read_mask/strtoul are able to skip whitespaces anyway.

By the way, I think it would be better to parse
/sys/devices/system/node/node*/cpumap
instead of some lines of /proc/self/status...

Signed-off-by: Brice Goglin <[email protected]>

diff -ur numactl-2.0.3~rc1/libnuma.c numactl-2.0.3~rc1.save/libnuma.c
--- numactl-2.0.3~rc1/libnuma.c 2008-12-09 20:38:07.000000000 +0100
+++ numactl-2.0.3~rc1.save/libnuma.c    2009-04-21 15:44:19.000000000 +0200
@@ -479,11 +479,11 @@
 
        while (getline(&buffer, &buflen, f) > 0) {
                if (strncmp(buffer,"Cpus_allowed:",13) == 0)
-                       maxproccpu = read_mask(buffer + 15, numa_all_cpus_ptr);
+                       maxproccpu = read_mask(buffer + 13, numa_all_cpus_ptr);
 
                if (strncmp(buffer,"Mems_allowed:",13) == 0) {
                        maxprocnode =
-                               read_mask(buffer + 15, numa_all_nodes_ptr);
+                               read_mask(buffer + 13, numa_all_nodes_ptr);
                }
        }
        fclose(f);


-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.29-1-amd64 (SMP w/16 CPU cores)
Locale: LANG=C, lc_ctype=fr...@euro (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Versions of packages libnuma1 depends on:
ii  libc6                         2.9-4      GNU C Library: Shared libraries

libnuma1 recommends no packages.

libnuma1 suggests no packages.

-- no debconf information



--- End Message ---
--- Begin Message ---
Source: numactl
Source-Version: 2.0.3~rc3-1

We believe that the bug you reported is fixed in the latest version of
numactl, which is due to be installed in the Debian FTP archive:

libnuma-dbg_2.0.3~rc3-1_i386.deb
  to pool/main/n/numactl/libnuma-dbg_2.0.3~rc3-1_i386.deb
libnuma-dev_2.0.3~rc3-1_i386.deb
  to pool/main/n/numactl/libnuma-dev_2.0.3~rc3-1_i386.deb
libnuma1_2.0.3~rc3-1_i386.deb
  to pool/main/n/numactl/libnuma1_2.0.3~rc3-1_i386.deb
numactl_2.0.3~rc3-1.diff.gz
  to pool/main/n/numactl/numactl_2.0.3~rc3-1.diff.gz
numactl_2.0.3~rc3-1.dsc
  to pool/main/n/numactl/numactl_2.0.3~rc3-1.dsc
numactl_2.0.3~rc3-1_i386.deb
  to pool/main/n/numactl/numactl_2.0.3~rc3-1_i386.deb
numactl_2.0.3~rc3.orig.tar.gz
  to pool/main/n/numactl/numactl_2.0.3~rc3.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ian Wienand <[email protected]> (supplier of updated numactl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 30 Apr 2009 08:04:32 -0700
Source: numactl
Binary: numactl libnuma1 libnuma-dev libnuma-dbg
Architecture: source i386
Version: 2.0.3~rc3-1
Distribution: unstable
Urgency: low
Maintainer: Ian Wienand <[email protected]>
Changed-By: Ian Wienand <[email protected]>
Description: 
 libnuma-dbg - Debug package for libnuma
 libnuma-dev - Development files for libnuma
 libnuma1   - Libraries for controlling NUMA policy
 numactl    - NUMA scheduling and memory placement tool
Closes: 525014
Changes: 
 numactl (2.0.3~rc3-1) unstable; urgency=low
 .
   * New upstream (Closes: #525014)
   * Move libnuma-dbg to debug section
   * Add ${misc:Depends} deps to packages
   * Update to standards version to 3.8.1
Checksums-Sha1: 
 8d7edfda20958e64b21cfd3bfb32712b177b3caf 1090 numactl_2.0.3~rc3-1.dsc
 7799afcf8f2f6a39ece307268885a4ae1d93274d 70912 numactl_2.0.3~rc3.orig.tar.gz
 5c95d431d7fbb404da97836dbd902a8eeb47583e 5199 numactl_2.0.3~rc3-1.diff.gz
 7befb6db080852b299a7c5bce7f193b71a074cf5 29686 numactl_2.0.3~rc3-1_i386.deb
 54912daf359758ac021e8a2c5d46f832b1f85448 24198 libnuma1_2.0.3~rc3-1_i386.deb
 08935a5beb5ccb4a53c7aea6310de5e2af2564c8 37748 libnuma-dev_2.0.3~rc3-1_i386.deb
 16aebdf3774ddfa0ab74cba377bfc1474b2f9f97 50506 libnuma-dbg_2.0.3~rc3-1_i386.deb
Checksums-Sha256: 
 b041879eed7b929ef143bf0a0c8ea0d967ff68965a186634c680f07a86ea8eaa 1090 
numactl_2.0.3~rc3-1.dsc
 45701a7289f8d07f58ca8f064f3e35d2e8a2b1586b42fc76da9e68dbe08b1f76 70912 
numactl_2.0.3~rc3.orig.tar.gz
 1aa30f639be092a16a9fa7ce680c1c964bce45e157bf6fa6d942a6397371b84f 5199 
numactl_2.0.3~rc3-1.diff.gz
 29c084b38d72c2a1798b8a0636d60adb616d31d69864eb7ed155eccd5155060f 29686 
numactl_2.0.3~rc3-1_i386.deb
 6f084b603452d22076f4e4387de0b98fa373a626f28f39eca27b945ee05391c8 24198 
libnuma1_2.0.3~rc3-1_i386.deb
 adfd82f7e19d66fe64272cada6852f3de80c5ec1b375dbe11d5b636f9405984c 37748 
libnuma-dev_2.0.3~rc3-1_i386.deb
 190d66b898bedfcd5785a9b6fa638036c5c18f07383bcb36dbc5b7798e42bff2 50506 
libnuma-dbg_2.0.3~rc3-1_i386.deb
Files: 
 74f9f7a545cf9c128f50097652f2936f 1090 admin optional numactl_2.0.3~rc3-1.dsc
 fd9d2d834d9e6d15a0d16a16f6c93c86 70912 admin optional 
numactl_2.0.3~rc3.orig.tar.gz
 58e25156d8ea6bc966a0c7a42e913aea 5199 admin optional 
numactl_2.0.3~rc3-1.diff.gz
 f0c22fe3de98e75163a9e156cf046545 29686 admin optional 
numactl_2.0.3~rc3-1_i386.deb
 abaa5fdadd109244683b9378ca7b261f 24198 libs optional 
libnuma1_2.0.3~rc3-1_i386.deb
 555a2f428d1b39524409afc32ed5965e 37748 libdevel extra 
libnuma-dev_2.0.3~rc3-1_i386.deb
 3770874ee737aef96fb53ea1fbe2706b 50506 debug extra 
libnuma-dbg_2.0.3~rc3-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkn5wcIACgkQWDlSU/gp6ed9GACg56m6D02TbppFE2NzzY5MgImj
smoAoN0pI/jL1yWv2nAQClQKmWCoefis
=3FM8
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to