Your message dated Mon, 4 May 2009 13:33:04 -0500
with message-id <[email protected]>
and subject line Re: Bug#526884: Text area for editing comments too narrow on 
epiphany and iceweasel
has caused the Debian Bug report #526884,
regarding Text area for editing comments too narrow on epiphany and iceweasel
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
526884: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=526884
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ikiwiki
Version: 3.10
Severity: minor
Tags: patch

The text area to make a comment does not set a column parameter, and
appears very narrow in epiphany and firefox by default. This commit sets
the text area to be slightly wider (80 chars, instead of 72) than the
subject field.

        manoj

>From e33889c5daa24a5066e6b2e205c5767043c80c04 Mon Sep 17 00:00:00 2001
From: Manoj Srivastava <[email protected]>
Date: Mon, 4 May 2009 03:32:52 -0500
Subject: [PATCH] [comment-textarea-width-fix] Set columns for the editing Text area

The text area to make a comment does not set a column parameter, and
appears very narrow in epiphany and firefox by default. This commit sets
the text area to be slightly wider (80 chars, instead of 72) than the
subject field.

Signed-Off-By: Manoj Srivastava <[email protected]>
---
 IkiWiki/Plugin/comments.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/IkiWiki/Plugin/comments.pm b/IkiWiki/Plugin/comments.pm
index e618d1a..6f5fd6d 100644
--- a/IkiWiki/Plugin/comments.pm
+++ b/IkiWiki/Plugin/comments.pm
@@ -297,7 +297,7 @@ sub editcomment ($$) {
 		force => 1);
 	$form->field(name => 'page', type => 'hidden');
 	$form->field(name => 'subject', type => 'text', size => 72);
-	$form->field(name => 'editcontent', type => 'textarea', rows => 10);
+	$form->field(name => 'editcontent', type => 'textarea', cols => 80, rows => 10);
 	$form->field(name => "type", value => $type, force => 1,
 		type => 'select', options => \...@page_types);
 
-- 
1.6.2.4



-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'oldstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.29.1-anzu (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages ikiwiki depends on:
ii  libhtml-parser-perl          3.60-1      collection of modules that parse H
ii  libhtml-scrubber-perl        0.08-4      Perl extension for scrubbing/sanit
ii  libhtml-template-perl        2.9-1       HTML::Template : A module for usin
ii  libtext-markdown-perl        1.0.24-1    Markdown and MultiMarkdown markup 
ii  liburi-perl                  1.37+dfsg-1 Manipulates and accesses URI strin
ii  perl                         5.10.0-19   Larry Wall's Practical Extraction 

Versions of packages ikiwiki recommends:
ii  bcc [c-compiler]           0.16.17-3     16-bit x86 C compiler
ii  bzr                        1.14-1        easy to use distributed version co
ii  gcc [c-compiler]           4:4.3.3-3     The GNU C compiler
ii  gcc-4.3 [c-compiler]       4.3.3-8       The GNU C compiler
ii  git-core                   1:1.6.2.4-1   fast, scalable, distributed revisi
pn  libauthen-passphrase-perl  <none>        (no description available)
ii  libc6-dev [libc-dev]       2.9-9         GNU C Library: Development Librari
ii  libcgi-formbuilder-perl    3.05.01-6     Easily generate and process statef
ii  libcgi-session-perl        4.41-1        persistent session data in CGI app
ii  liblwpx-paranoidagent-perl 1.04-1        a "paranoid" subclass of LWP::User
ii  libmail-sendmail-perl      0.79.16-1     Send email from a perl script
ii  libnet-openid-consumer-per 0.14-4        library for consumers of OpenID id
ii  libterm-readline-gnu-perl  1.19-1        Perl extension for the GNU Readlin
ii  libtimedate-perl           1.1600-9      Time and date functions for Perl
ii  libxml-simple-perl         2.18-1        Perl module for reading and writin
ii  mercurial                  1.2-1         scalable distributed version contr
ii  subversion                 1.5.6dfsg-1   Advanced version control system
ii  tla                        1.3.5+dfsg-14 GNU Arch revision control system

Versions of packages ikiwiki suggests:
ii  dvipng                     1.11-1        convert DVI files to PNG graphics
ii  gitweb                     1:1.6.2.4-1   fast, scalable, distributed revisi
ii  graphviz                   2.20.2-3+b2   rich set of graph drawing tools
ii  libcrypt-ssleay-perl       0.57-1+b1     Support for https protocol in LWP
ii  libdigest-sha1-perl        2.11-2+b1     NIST SHA-1 message digest algorith
ii  libfile-mimeinfo-perl      0.15-1        Perl module to determine file type
ii  libhtml-tree-perl          3.23-1        represent and create HTML syntax t
ii  liblocale-gettext-perl     1.05-4        Using libc functions for internati
ii  libmailtools-perl          2.04-1        Manipulate email in perl programs
ii  libnet-amazon-s3-perl      0.50-1        Amazon S3 Perl API - Simple Storag
ii  librpc-xml-perl            0.64-1        Perl module implementation of XML-
pn  libsearch-xapian-perl      <none>        (no description available)
pn  libsort-naturally-perl     <none>        (no description available)
ii  libtext-csv-perl           1.11-1        comma-separated values manipulator
pn  libtext-textile-perl       <none>        (no description available)
ii  libtext-typography-perl    0.01-2        markup ASCII text with correct typ
ii  libtext-wikicreole-perl    0.07-1        Convert Wiki Creole 1.0 markup to 
ii  libtext-wikiformat-perl    0.78-1        translates Wiki formatted text int
ii  libxml-feed-perl           0.42+dfsg-1   syndication feed parser and auto-d
ii  perlmagick                 7:6.5.1.0-1   Perl interface to the ImageMagick 
pn  polygen                    <none>        (no description available)
ii  python                     2.5.4-2       An interactive high-level object-o
ii  python-docutils            0.5-3         utilities for the documentation of
pn  sparkline-php              <none>        (no description available)
ii  texlive                    2007.dfsg.2-3 TeX Live: A decent selection of th
ii  tidy                       20081224cvs-1 HTML syntax checker and reformatte
pn  xapian-omega               <none>        (no description available)

-- no debconf information


-- 
The clothes have no emperor.  -- C. A. Hoare, about Ada.
Manoj Srivastava <[email protected]> <http://www.golden-gryphon.com/>  
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C

--- End Message ---
--- Begin Message ---
Joey Hess writes:
 > Manoj Srivastava wrote:
 > > The text area to make a comment does not set a column parameter, and
 > > appears very narrow in epiphany and firefox by default. This commit sets
 > > the text area to be slightly wider (80 chars, instead of 72) than the
 > > subject field.
 > 
 > Are you using a custom style sheet that is missing this configuration
 > from style.css?
 > 
 > #editcontent {
 >         width: 100%;
 
        Yes, I am. I also thought I was using style.css, which should
 have had that, earlier in the cascade, but somehow, a zero byte
 style.css was committed into the git repository for my site. I have
 removed that, uninstalled the patch,  and things work now.

        Sorry for the noise.

        manoj
-- 
grep me no patterns and I'll tell you no lines.
Manoj Srivastava <[email protected]> <[email protected]> 
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C


--- End Message ---

Reply via email to