Your message dated Fri, 8 May 2009 00:16:04 +0200
with message-id <[email protected]>
and subject line Patch not correct
has caused the Debian Bug report #506063,
regarding Patch from Ubuntu (clean directories correctly when purging)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
506063: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=506063
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tiger
Version: 1:3.2.2-7.1
Hi,
This following patch is from Ubuntu. Described as "clean directories
correctly when purging".
--- tiger-3.2.2.orig/config.in
+++ tiger-3.2.2/config.in
@@ -133,8 +133,14 @@
# TODO: WORKDIR should be removed on exit if it is located in a temporary
# directory
if [ ! -d "$WORKDIR" ] ; then
+ case "$WORKDIR" in
+ /var/run/* | /tmp* | /var/tmp/* )
+ mkdir -p "$WORKDIR"
+ ;;
+ *)
echo "Configured working directory $WORKDIR does not exist" >&2
exit 1
+ esac
fi
@@ -222,10 +228,11 @@
#
[ -n "$RCFILE" -a -f $RCFILE ] && {
+ tmpf=$(tempfile)
$GREP -v '^#' $RCFILE |
- $SED -e 's/^\(.*\)=/export \1; \1=/' > $WORKDIR/rcfile.$$
- . $WORKDIR/rcfile.$$
- $RM -f $WORKDIR/rcfile.$$
+ $SED -e 's/^\(.*\)=/export \1; \1=/' > $tmpf
+ . $tmpf
+ $RM -f $tmpf
}
HOSTNAME=`$GETHOSTNAME`
--- End Message ---
--- Begin Message ---
This patch is not correct for several reasons:
- it patches the wrong file (config.in should not be used)
- config already does this:
# 08/30/2006 jfs Attempt to create working directory if it does not exist
# (Debian bug #366919)
- the second part of the patch (using a tempfile instead of the working dir)
is not how it should be done because it overrides WORKDIR definition.
Regards
Javier
signature.asc
Description: Digital signature
--- End Message ---
