Your message dated Wed, 13 May 2009 13:42:32 +1930
with message-id <[email protected]>
and subject line The patch was applied in last revision.
has caused the Debian Bug report #435211,
regarding Add "show asterisks" functionality to password widget in CDialog
backend
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
435211: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=435211
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libui-dialog-perl
Version: 1.08-1
The patch below adds the --insecure option to the CDialog backend of
UI::Dialog. This option makes the password widget friendlier, by
showing asterisks when a user types a password. This functionality
exists in in the dialog program, but unfortunately not in this
Perl module. Ofcourse, this feature is only activated when the
appropriate parameter is passed when the UI::Dialog::Backend::CDialog
object is created:
$d = new UI::Dialog::Backend::CDialog( insecure => 1 ) or die;
The "unless not" constructions seen around the added line seem
very ugly to me, because "unless not" essentially means the same
as "if". However I've decided not to touch those lines yet. Perhaps
I will do so in the future should I decide to ask for upstream
maintainership of the module on CPAN. Ofcourse, anybody is free to
still change that regadless of what I decide to do. This is also
the reason why I sent the bug to Debian and not to upstream: the
project seems to have been inactive since 2004.
Kind regards,
Michiel de Boer
[email protected]
diff -Nru libui-dialog-perl-1.08.orig/lib/UI/Dialog/Backend/CDialog.pm
libui-dialog-perl-1.08/lib/UI/Dialog/Backend/CDialog.pm
--- libui-dialog-perl-1.08.orig/lib/UI/Dialog/Backend/CDialog.pm
2004-10-04 05:16:43.000000000 +0200
+++ libui-dialog-perl-1.08/lib/UI/Dialog/Backend/CDialog.pm 2007-07-30
05:12:56.000000000 +0200
@@ -84,6 +84,7 @@
$self->{'_opts'}->{'extra-label'} = $cfg->{'extra-label'} || undef();
$self->{'_opts'}->{'help-button'} = $cfg->{'help-button'} || 0;
$self->{'_opts'}->{'help-label'} = $cfg->{'help-label'} || undef();
+ $self->{'_opts'}->{'insecure'} = $cfg->{'insecure'} || 0;
$self->{'_opts'}->{'max-input'} = $cfg->{'max-input'} || 0;
$self->{'_opts'}->{'no-cancel'} = $cfg->{'no-cancel'} ||
$cfg->{'nocancel'} || 0;
$self->{'_opts'}->{'no-collapse'} = $cfg->{'no-collapse'} || 0;
@@ -176,6 +177,7 @@
$cmnd .= ' --extra-label "'.$args->{'extra-label'}.'"' unless
not $args->{'extra-label'};
$cmnd .= ' --help-button' unless not $args->{'help-button'} and
not $args->{'help-label'};
$cmnd .= ' --help-label "'.$args->{'help-label'}.'"' unless not
$args->{'help-label'};
+ $cmnd .= ' --insecure' if $args->{'insecure'};
$cmnd .= ' --max-input "'.$args->{'max-input'}.'"' unless not
$args->{'max-input'};
$cmnd .= ' --no-cancel' unless not $args->{'nocancel'} and not
$args->{'no-cancel'};
$cmnd .= ' --no-collapse' unless not $args->{'no-collapse'} and
not $args->{'literal'};
--- End Message ---
--- Begin Message ---
The bug was fixed in second revision but it was not closed by
changelog due mistake of maintainer : ), the patch was applied. Thanks
Best wishes
--
http://www.mogaal.com
GNU/Linux Debian SID
Usuario Linux registrado #386758
GPG Key Fingerprint = F6A7 EF7E 4688 70C6 6B37 A8EF F6B0 9645 B24B F200
--- End Message ---
