Your message dated Fri, 15 May 2009 09:17:32 +0000
with message-id <[email protected]>
and subject line Bug#508969: fixed in epdfview 0.1.7-2
has caused the Debian Bug report #508969,
regarding epdfview wrongly assumes nonexistant files are encrypted
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
508969: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=508969
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: epdfview
Version: 0.1.6-7
Severity: normal
Tags: patch
I noticed that when I mistakenly entered a filename to a file which
didn't exist, epdfview started to ask for a password to decrypt the
file! Cancelling caused epdfview to disallow opening new files and
made it necessary to restart the program. I confirmed this behaviour
on a freshly installed machine.
The problem was if poppler couldn't open the document it set
POPPLER_ERROR but epdfview interpreted this as an encrytption error.
With my proposed patch the problems seems to have bin fixed, at least
for me; asking for password when trying to open encrypted files and
alerting the user that it wasn't able to open the file, if the file
is non-existent.
--
Olof Johansson ✉ <[email protected]>
http://www.ethup.se ☎ +46-739-467135
--- epdfview-0.1.6.orig/src/PDFDocument.cxx 2008-12-16 14:21:53.000000000 +0100
+++ epdfview-0.1.6/src/PDFDocument.cxx 2008-12-17 02:05:07.000000000 +0100
@@ -19,6 +19,7 @@
#include <gdk/gdk.h>
#include <time.h>
#include <poppler.h>
+#include <poppler/ErrorCodes.h>
#include <unistd.h>
#include "epdfview.h"
@@ -210,7 +211,7 @@
return FALSE;
}
// Try to open the PDF document.
- GError *loadError = NULL;
+
// In case the user specified to read the PDF file from the stdin
// (i.e., -), then we save the contents of the stdin to a temporary
// file and use the URI to this temporary file to load.
@@ -241,38 +242,13 @@
}
}
PopplerDocument *newDocument =
- poppler_document_new_from_file (filename_uri, password, &loadError);
+ poppler_document_new_from_file (filename_uri, password, error);
g_free (filename_uri);
- // Check if the document couldn't be opened successfully and why.
- if ( NULL == newDocument )
- {
- // Poppler's glib wrapper passes the Poppler error code unless the
- // error is that the file is encrypted. We want to set our own
- // error code in this case.
- DocumentError errorCode = DocumentErrorNone;
- if ( POPPLER_ERROR == loadError->domain )
- {
- errorCode = DocumentErrorEncrypted;
- }
- else
- {
- // OK, the glib's wrapper don't pass the error code directly
- // from Poppler. Instead returns G_FILE_ERROR_FAILED and a
- // non translated string.
- // Maybe I'm wrong (very probable) but that's a wrong way.
- // So I'm reading the error code from the error string...
- sscanf (loadError->message, "Failed to load document (error %d)",
- (gint *)&errorCode);
- }
- g_error_free (loadError);
- // Get our error message.
- gchar *errorMessage = IDocument::getErrorMessage (errorCode);
- g_set_error (error,
- EPDFVIEW_DOCUMENT_ERROR, errorCode,
- _("Failed to load document '%s'.\n%s\n"),
- filename, errorMessage);
- g_free (errorMessage);
+ // Check if the document couldn't be opened successfully and why.
+ if ( !newDocument && (*error)->code ) {
+ if((*error)->code==POPPLER_ERROR_ENCRYPTED)
+ (*error)->code = DocumentErrorEncrypted;
return FALSE;
}
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: epdfview
Source-Version: 0.1.7-2
We believe that the bug you reported is fixed in the latest version of
epdfview, which is due to be installed in the Debian FTP archive:
epdfview_0.1.7-2.diff.gz
to pool/main/e/epdfview/epdfview_0.1.7-2.diff.gz
epdfview_0.1.7-2.dsc
to pool/main/e/epdfview/epdfview_0.1.7-2.dsc
epdfview_0.1.7-2_amd64.deb
to pool/main/e/epdfview/epdfview_0.1.7-2_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Yves-Alexis Perez <[email protected]> (supplier of updated epdfview package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Format: 1.8
Date: Fri, 15 May 2009 08:28:11 +0200
Source: epdfview
Binary: epdfview
Architecture: source amd64
Version: 0.1.7-2
Distribution: unstable
Urgency: low
Maintainer: Yves-Alexis Perez <[email protected]>
Changed-By: Yves-Alexis Perez <[email protected]>
Description:
epdfview - Lightweight pdf viewer based on poppler libs
Closes: 459263 459263 508969 527355
Changes:
epdfview (0.1.7-2) unstable; urgency=low
.
* debian/rules:
- install icon in the correct location. closes: #459263, #459263
* debian/control:
- update standards version to 3.8.1.
* debian/patches:
- 02_fix-mouse-wheel added, fix scrolling with mouse wheel. closes: #527355
- 03_nonexisting-file added, fix epdfview asking for password when
opening non-existant files. closes: #508969
Checksums-Sha1:
6456ee8e7be9532450f4bfc4adf8f67bf8fbcfa8 1088 epdfview_0.1.7-2.dsc
f60bea945b262e871fc3af8974bb5c5b3813cf91 6985 epdfview_0.1.7-2.diff.gz
d1fcaedbf73105ff4b2c36463947cffff69ab281 126386 epdfview_0.1.7-2_amd64.deb
Checksums-Sha256:
3f2a478789e86fe83a3d39013a1d93f320ea423d3fa309269e038ed7e916daa5 1088
epdfview_0.1.7-2.dsc
907c2ed4657b60e73224e995d4996d51bf059f7f0f1a37abea3f4a47fb50c348 6985
epdfview_0.1.7-2.diff.gz
4569214434924e0999b3c69c6475e514c7e4cd4650c6441105de07955dbc4103 126386
epdfview_0.1.7-2_amd64.deb
Files:
130cc37352a333f2900231d802083eff 1088 x11 optional epdfview_0.1.7-2.dsc
e0deb426f2df208036b0bddd0ae048e2 6985 x11 optional epdfview_0.1.7-2.diff.gz
d74c667104db53b3e8f66d847331aaf7 126386 x11 optional epdfview_0.1.7-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEUEAREDAAYFAkoNDGYACgkQTUTAIMXAW64VVwCXYaYSZvtopjO/X5VqCPixRGo7
tACglvIbS3PB/bYh7MHMc5oOq0s7U+Q=
=DxEI
-----END PGP SIGNATURE-----
--- End Message ---
