Your message dated Tue, 09 Jun 2009 11:17:04 +0000
with message-id <[email protected]>
and subject line Bug#531609: fixed in globus-common 10.2-5
has caused the Debian Bug report #531609,
regarding globus-common: FTBFS on hurd-i386
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
531609: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=531609
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: globus-common
Severity: important
Tags: patch
Hello,
globus-common currently FTBFS on hurd-i386 because it makes an
unconditional use of PATH_MAX, while POSIX says such limit is optional,
and it happens that hurd-i386 doesn't have such limitation.
Barry deFreese wrote a patch to fix this, attached to this mail, could
you please apply it?
Thanks
Samuel
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.29 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
--
Samuel Thibault <[email protected]>
<y> muhahaha...
<y> ya un train qui part de Perrache � 14h57
<y> qui passe � Part-Dieu � 15h10
<y> si je le prend � Perrache, je suis en zone bleue
<y> si je le prends � Part-Dieu, je suis en zone blanche
<y> donc je vais le prendre � Perrache *mais* � Part-Dieu ;-)
-+- #ens-mim - vive la SNCF -+-
diff -ur globus-common-10.2-orig/library/globus_common.h.in
globus-common-10.2/library/globus_common.h.in
--- globus-common-10.2-orig/library/globus_common.h.in 2006-01-19
05:54:14.000000000 +0000
+++ globus-common-10.2/library/globus_common.h.in 2009-06-02
17:12:58.000000000 +0000
@@ -115,11 +115,6 @@
#endif
#endif
-#if !defined(MAXPATHLEN)
-# include <sys/param.h>
-# define MAXPATHLEN PATH_MAX
-#endif
-
/* most network-related functions (getpeername, getsockname,...) have
an int* as argument, except AIX which uses size_t*. This will
masquerade the difference. */
Only in globus-common-10.2/library: globus_common.h.in.orig
diff -ur globus-common-10.2-orig/library/globus_libc.c
globus-common-10.2/library/globus_libc.c
--- globus-common-10.2-orig/library/globus_libc.c 2008-04-05
03:09:41.000000000 +0000
+++ globus-common-10.2/library/globus_libc.c 2009-06-02 17:15:48.000000000
+0000
@@ -34,6 +34,8 @@
#include "config.h"
#include "globus_common.h"
+#include <stddef.h> /* For offsetof() */
+
#ifdef HAVE_STRING_H
#include <string.h>
#endif
@@ -46,11 +48,6 @@
#include <arpa/inet.h>
#endif
-#if !defined(MAXPATHLEN)
-# include <sys/param.h>
-# define MAXPATHLEN PATH_MAX
-#endif
-
/* HPUX 10.20 headers do not define this */
#if defined(TARGET_ARCH_HPUX)
extern int h_errno;
@@ -2218,7 +2215,7 @@
static globus_mutex_t gethomedir_mutex;
static int initialized = GLOBUS_FALSE;
static struct passwd pw;
- static char homedir[MAXPATHLEN];
+ static char * homedir;
static int homedir_len = 0;
static char buf[1024];
int rc;
@@ -2258,7 +2255,7 @@
if (!rc && p)
{
len = strlen(p);
- if (len+1 < MAXPATHLEN)
+ if ((homedir = malloc(len+1) != NULL))
{
memcpy(homedir, p, len);
homedir[len] = '\0';
@@ -2556,9 +2553,6 @@
struct dirent *tmpdir, *entry;
int save_errno;
- entry = (struct dirent *) globus_malloc(sizeof(struct dirent)
- + MAXPATHLEN
- + 1);
globus_libc_lock();
tmpdir = readdir(dirp);
@@ -2570,13 +2564,15 @@
globus_libc_unlock();
- globus_free(entry);
-
errno = save_errno;
return -1;
}
+ entry = (struct dirent *) globus_malloc(offsetof(struct dirent, d_name)
+ + strlen(tmpdir->d_name)
+ + 1);
+
/* copy returned buffer into data structure */
entry->d_ino = tmpdir->d_ino;
# if defined(GLOBUS_HAVE_DIRENT_OFF)
@@ -2619,8 +2615,8 @@
# if defined(GLOBUS_HAVE_READDIR_R_3)
{
int rc = 0;
- struct dirent *entry = globus_malloc(sizeof(struct dirent)
- + MAXPATHLEN
+ struct dirent *entry = globus_malloc(offsetof(struct dirent, d_name)
+ + NAME_MAX
+ 1);
rc = readdir_r(dirp, entry, result);
@@ -2634,8 +2630,8 @@
}
# elif defined(GLOBUS_HAVE_READDIR_R_2)
{
- struct dirent *entry = globus_malloc(sizeof(struct dirent)
- + MAXPATHLEN
+ struct dirent *entry = globus_malloc(offsetof(struct dirent, d_name)
+ + NAME_MAX
+ 1);
int rc=0;
Only in globus-common-10.2/library: globus_libc.c.orig
--- End Message ---
--- Begin Message ---
Source: globus-common
Source-Version: 10.2-5
We believe that the bug you reported is fixed in the latest version of
globus-common, which is due to be installed in the Debian FTP archive:
globus-common-progs_10.2-5_amd64.deb
to pool/main/g/globus-common/globus-common-progs_10.2-5_amd64.deb
globus-common_10.2-5.diff.gz
to pool/main/g/globus-common/globus-common_10.2-5.diff.gz
globus-common_10.2-5.dsc
to pool/main/g/globus-common/globus-common_10.2-5.dsc
libglobus-common-dev_10.2-5_amd64.deb
to pool/main/g/globus-common/libglobus-common-dev_10.2-5_amd64.deb
libglobus-common-doc_10.2-5_amd64.deb
to pool/main/g/globus-common/libglobus-common-doc_10.2-5_amd64.deb
libglobus-common0_10.2-5_amd64.deb
to pool/main/g/globus-common/libglobus-common0_10.2-5_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mattias Ellert <[email protected]> (supplier of updated globus-common
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 02 Jun 2009 23:57:07 +0200
Source: globus-common
Binary: libglobus-common0 globus-common-progs libglobus-common-dev
libglobus-common-doc
Architecture: source amd64
Version: 10.2-5
Distribution: unstable
Urgency: low
Maintainer: Mattias Ellert <[email protected]>
Changed-By: Mattias Ellert <[email protected]>
Description:
globus-common-progs - Globus Toolkit - Common Library Programs
libglobus-common-dev - Globus Toolkit - Common Library Development Files
libglobus-common-doc - Globus Toolkit - Common Library Documentation Files
libglobus-common0 - Globus Toolkit - Common Library
Closes: 531609
Changes:
globus-common (10.2-5) unstable; urgency=low
.
* Fix compilation on i386-hurd (Closes: #531609).
Checksums-Sha1:
c59ee9e31a38f6986f82aba8939784767bed20c7 1601 globus-common_10.2-5.dsc
24907455dae9f3ea7005b1f6c33b29cafc62660e 17693 globus-common_10.2-5.diff.gz
9b04b09177838d91c745064d24f1c31d46bf4c94 101558
libglobus-common0_10.2-5_amd64.deb
d3699aaabc0cc62d0f450b412ff3209adfb4b98d 58716
globus-common-progs_10.2-5_amd64.deb
d580a8a8d9c47295642f2182fb71744e2de0291c 177028
libglobus-common-dev_10.2-5_amd64.deb
ff0644d1df43edf258eaec6f431109218e3db320 362118
libglobus-common-doc_10.2-5_amd64.deb
Checksums-Sha256:
f7e16609c4fda5f8c318d8caa536b26f19f2f388467e10f2616fefc2dfdbb332 1601
globus-common_10.2-5.dsc
e3e580b90f7b7d39874a6d18b126ec0c5373fddd86f9d333d7bc02b3a397fd46 17693
globus-common_10.2-5.diff.gz
61219718d6edc2a26349e862627a72a5327496e22733355f941b5633c39c248d 101558
libglobus-common0_10.2-5_amd64.deb
e50ce964c6ec090c726dfe41100846b39453aa05f2552b5655925d16e099aed5 58716
globus-common-progs_10.2-5_amd64.deb
c556cca65ec35dca3c86358ef19e770097dca3009fa1e6c6e5476a73da2057c6 177028
libglobus-common-dev_10.2-5_amd64.deb
e845f45bc19d14bb9ed9aae334ff5a421804f58146ed2e39842d5c42e6c323cb 362118
libglobus-common-doc_10.2-5_amd64.deb
Files:
9cb4f775630b512acda014cf2e4241a7 1601 net optional globus-common_10.2-5.dsc
1006139868158ad9117746cf9dadbbbc 17693 net optional
globus-common_10.2-5.diff.gz
6204ab3b58c5ca7d62c8f89099a038ed 101558 libs optional
libglobus-common0_10.2-5_amd64.deb
3076f893939994ae27371db317a03a27 58716 net optional
globus-common-progs_10.2-5_amd64.deb
f5ca5ce3d8c1a89a08538eef656c9b86 177028 libdevel optional
libglobus-common-dev_10.2-5_amd64.deb
6a0a6250bdf307a584619b5611d19d9e 362118 doc optional
libglobus-common-doc_10.2-5_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkouQEwACgkQeJY7S99W//IuTQCeNPBVp8xTboc5fv75mrJNarXJ
wC4AoJgqJUB0TC75c1jWRIxWM5+vT6cN
=Cqvv
-----END PGP SIGNATURE-----
--- End Message ---
