Your message dated Fri, 26 Jun 2009 10:37:13 +0000
with message-id
<20090626103713.19971.qm...@5ba047bf4e8bae.315fe32.mid.smarden.org>
and subject line Re: Bug#530088: git-core: bashism in /bin/sh script
has caused the Debian Bug report #530088,
regarding git-core: bashism in /bin/sh script
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
530088: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530088
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: git-core
Severity: important
Version: 1:1.6.3.1-1
User: [email protected]
Usertags: goal-dash
Hello maintainer,
While performing an archive wide checkbashisms (from the 'devscripts' package)
check I've found your package containing a /bin/sh script making use
of a bashism.
checkbashisms' output:
> possible bashism in ./usr/lib/git-core/git-rebase--interactive line 463
> (should be >word 2>&1):
> echo "$command${sha1:+ }$sha1${rest:+ }$rest" >&$fd
Not using bash (or a Debian Policy conformant shell interpreter which doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there was
a release goal for Lenny to make dash the default /bin/sh[1], and has been
proposed for squeeze as well[2].
If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html
For more information supporting this goal please refer to Debian Policy,
section 10.4, at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts
Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh
If you still don't know how to fix the bashisms don't hesitate to reply to
this email, or tag the bug as 'help'.
[1]http://release.debian.org/lenny/goals.txt
[2]http://lists.debian.org/debian-release/2009/04/msg00133.html
Thank you,
Raphael Geissert
--- End Message ---
--- Begin Message ---
On Sat, Jun 06, 2009 at 09:02:06PM +0300, Kalle Olavi Niemitalo wrote:
> Raphael Geissert <[email protected]> writes:
>
> > While performing an archive wide checkbashisms (from the 'devscripts'
> > package)
> > check I've found your package containing a /bin/sh script making use
> > of a bashism.
> >
> > checkbashisms' output:
> >> possible bashism in ./usr/lib/git-core/git-rebase--interactive line 463
> >> (should be >word 2>&1):
> >> echo "$command${sha1:+ }$sha1${rest:+ }$rest" >&$fd
>
> That is not intended to redirect stdout and stderr to the same file.
> Instead, it is intended to redirect stdout to the file descriptor
> whose number is $fd. And that syntax works in dash 0.5.3-8 too:
>
> % LANG=C dash
> $ cat testing
> cat: testing: No such file or directory
> $ exec 4> testing
> $ fd=4
> $ echo foo >&$fd
> $ cat testing
> foo
> $
>
> Thus, I suggest closing this bug, and perhaps changing
> checkbashisms to somehow realize this is not a bashism.
Thanks, I confirm that, it's fine with posix.
Gruss, Gerrit.
--- End Message ---
