Your message dated Fri, 10 Jul 2009 09:32:05 +0000
with message-id <[email protected]>
and subject line Bug#521711: fixed in cdbs 0.4.57
has caused the Debian Bug report #521711,
regarding cdbs: Clean target is misordered when using cmake class.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
521711: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521711
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cdbs
Version: 0.4.54
Severity: normal
When calling clean target, the clean sequence looks wrong. This is an except:
---8<-----
fakeroot debian/rules clean
test -x debian/rules
test "`id -u`" = 0
rmdir obj-x86_64-linux-gnu
rmdir: failed to remove «obj-x86_64-linux-gnu»: No existe el fichero o el
directorio
make: [cleanbuilddir] Error 1 (no tiene efecto)
rm -rf obj-x86_64-linux-gnu
/usr/bin/make -C obj-x86_64-linux-gnu -k clean
make: *** obj-x86_64-linux-gnu: No existe el fichero o el directorio. Alto.
make: [makefile-clean] Error 2 (no tiene efecto)
rm -f debian/stamp-makefile-build
dh_clean
/usr/bin/make -f debian/rules reverse-config
------->8-----
In my case the rules file states:
include /usr/share/pkg-kde-tools/makefiles/1/cdbs/kde.mk
include /usr/share/cdbs/1/rules/debhelper.mk
include /usr/share/cdbs/1/rules/patchsys-quilt.mk
Where kde.mk basically includes cmake class.
After having examined the cdbs sources, i found clean target to be defined
in buildcore.mk like this:
----(buildcore.mk)----
clean:: testdir testroot cleanbuilddir reverse-config
cleanbuilddir:: $(patsubst %,cleanbuilddir/%,$(DEB_ALL_PACKAGES))
-$(if $(call cdbs_streq,$(DEB_BUILDDIR),$(DEB_SRCDIR)),,rmdir
$(DEB_BUILDDIR))
----(buildcore.mk)----
Whereas in cmake.mk:
----(cmake.mk)----
cleanbuilddir::
-$(if $(call cdbs_streq,$(DEB_BUILDDIR),$(DEB_SRCDIR)),,rm -rf
$(DEB_BUILDDIR))
----(cmake.mk)----
Also cmake class include makefile class, makefile.mk which defines:
-------(makefile.mk)------------
clean:: makefile-clean
makefile-clean::
$(if $(DEB_MAKE_CLEAN_TARGET),+-$(DEB_MAKE_INVOKE) -k
$(DEB_MAKE_CLEAN_TARGET),@echo "DEB_MAKE_CLEAN_TARGET unset, not running
clean")
rm -f debian/stamp-makefile-build
-------(makefile.mk)------------
So what's happening is that makefile.mk makefile-clean target is being added
to clean target
and this target is being called after cleanbuilddir, unfortunately too late.
IMHO, makefile-clean
should be invoked before cleanbuilddir, or as the first action of
cleanbuilddir
I'm not sure how to proceed in this case, because I don¡'t think it's
feasible redefining clean target in buildcore.mk
A possible solution would be redifining cleanbuilddir in cmake.mk like this:
cleanbuilddir:: makefile-clean
-$(if $(call cdbs_streq,$(DEB_BUILDDIR),$(DEB_SRCDIR)),,rm -rf
$(DEB_BUILDDIR))
Not sure is this is sensible though. Hope you have better ideas.
Regards,
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (900, 'unstable'), (500, 'testing'), (100, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.29-toi3head (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages cdbs depends on:
ii debhelper 7.2.7 helper programs for debian/rules
Versions of packages cdbs recommends:
ii autotools-dev 20080123.2 Update infrastructure for config.
{
Versions of packages cdbs suggests:
ii devscripts 2.10.47 scripts to make the life of a
Debi
pn doc-base <none> (no description available)
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: cdbs
Source-Version: 0.4.57
We believe that the bug you reported is fixed in the latest version of
cdbs, which is due to be installed in the Debian FTP archive:
cdbs_0.4.57.dsc
to pool/main/c/cdbs/cdbs_0.4.57.dsc
cdbs_0.4.57.tar.gz
to pool/main/c/cdbs/cdbs_0.4.57.tar.gz
cdbs_0.4.57_all.deb
to pool/main/c/cdbs/cdbs_0.4.57_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jonas Smedegaard <[email protected]> (supplier of updated cdbs package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Format: 1.8
Date: Fri, 10 Jul 2009 11:00:48 +0200
Source: cdbs
Binary: cdbs
Architecture: source all
Version: 0.4.57
Distribution: unstable
Urgency: low
Maintainer: CDBS Hackers <[email protected]>
Changed-By: Jonas Smedegaard <[email protected]>
Description:
cdbs - common build system for Debian packages
Closes: 520105 520383 521711 525855 529355 531692 532193 532262 534895 536351
Changes:
cdbs (0.4.57) unstable; urgency=low
.
[ Jonas Smedegaard ]
* Have debhelper.mk build-depend on cdbs 0.4.53 or newer for DH v7.
* Relax build-dependencies (e.g. drop versioning when satisfied in
oldstable and not explicitly required by policy):
+ keep old versioning for perl (required by policy)
+ relax slightly versioning for python
+ drop some old versionings for debhelper, gnulib, type-handling,
cdbs and patchutils
* Adjust gnome.mk to extend build-dependencies after including classes
which initialize them.
* Append trunk in Vcs-* stanzas of debian/control, and use viewsvn
(not vswn) in Vcs-Browser stanza. Closes: bug#531692.
* Build-depend on python-all-dev (not python2.4-dev or python2.5-dev),
and generalize python-distutils tests to try all available versions
of python. Closes: bug#525855, thanks to Martin Pitt.
* Use $(filter ...) instead of $(findstring ...) to extract space-
separated options from DEB_BUILD_OPTIONS in debian/rules.
* Fix autotools.mk not completing all dependencies of post-patches
before doing configure.
* Fix doc-base section (Debian, not Programming). Closes: bug#532193,
thanks to Drew Parsons.
* Fix testroot rule broken since 0.4.54. Closes: bug#532262, thanks to
Frédéric Brière.
* Fix makefile.mk to cleanup before cleanbuilddir (not in parallel).
Closes: bug#521711, thanks to Raúl Sánchez Siles.
* Fix perlmodule-vars.mk to work with recent MakeMaker (set DESTDIR
instead of PREFIX). Closes: bug#534895, thanks to Kevin Ryde.
* Fix override autotools config.{guess,sub,rpath} also when symlinks.
Closes: bug#536351.
* Drop noop inclusion of docbookxml.mk in gnome.mk.
* Unconditionally add binary-install/* rules in gnome.mk (they are
silently ignored if debhelper.mk not included).
.
[ Peter Eisentraut ]
* Document the class for KDE 4 provided by pkg-kde-tools, and document the
KDE 3 class as obsolescent. Move up the cmake section so the order makes
sense again. (closes: #520383)
* Allow JAVACMD to include options (patch by Matthias Klose) (ant.mk)
(closes: #520105)
* Reenabled the ant-1 test
* Added support for lzma-compressed tarballs (patch by Robert Millan)
(buildcore.mk, tarball.mk) (closes: #529355); added test case
Checksums-Sha1:
d1674034356280765ba843b213e883638669a429 1166 cdbs_0.4.57.dsc
8ce602c2308ed469f111dcbaba2b93d418dd2440 209173 cdbs_0.4.57.tar.gz
832c5106afd8cce7c2e7c5f823344a2a218304de 1003656 cdbs_0.4.57_all.deb
Checksums-Sha256:
3c21ec4a8f20ef55926e902a9aa7da9429eb9f72156c6319645ed9d2b71720ef 1166
cdbs_0.4.57.dsc
90cd425fcbf0545ba562d918b6f5de16114aca77bf71da30e0c69bf8f1a29949 209173
cdbs_0.4.57.tar.gz
1e256b586a1d15ee3ea0316e7708071cbe40adb7782739dd4fea0e624b0c00af 1003656
cdbs_0.4.57_all.deb
Files:
0636d7e707e2f5b00dc06c5ded742260 1166 devel optional cdbs_0.4.57.dsc
114a00a5b0e37751609c2a8c27bcc4ee 209173 devel optional cdbs_0.4.57.tar.gz
26cdaacea1a3a9dbfcafca52a36ef26f 1003656 devel optional cdbs_0.4.57_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEAREDAAYFAkpXCNsACgkQn7DbMsAkQLgCxgCfYLVMUafHLRRliG9zrmSqQ+k7
Tg4AniQFvPtf2eFJKZnj0KygpxbBs/x7
=0DWJ
-----END PGP SIGNATURE-----
--- End Message ---
