Your message dated Fri, 4 Sep 2009 10:27:37 +0100
with message-id <[email protected]>
and subject line Re: Bug #110417 abcde: Option to do both id3v1 and id3v2 tags
has caused the Debian Bug report #110417,
regarding abcde: Option to do both id3v1 and id3v2 tags
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
110417: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=110417
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: abcde
Version: 2.0-1
Severity: wishlist
Hi,
This would be a nice feature to include IMHO - it makes the files
forwards-compatible and at the same time compatible with most current players
(ie ones that don't support id3v2).
Here is a patch:
--- /usr/bin/abcde Wed Aug 15 23:35:25 2001
+++ /usr/local/bin/abcde Tue Aug 28 13:32:14 2001
@@ -219,12 +219,18 @@
# ...except id3v2's -c is completely broken (there's a bug in
id3lib
# v3.7.x keeping -c from being properly implemented)
if [ "$ID3TAGV" = "2" ]; then
- run_command tagtrack-$1 $TAGGER $TAGGEROPTS -A
"$DALBUM" -a "$TRACKARTIST" \
+ run_command tagtrack-$1 $ID3V2 $ID3V2OPTS -A "$DALBUM"
-a "$TRACKARTIST" \
-t "$TRACKNAME" -T "$1"
"$ABCDETEMPDIR/track$1.$OUTPUTTYPE"
- else
- run_command tagtrack-$1 $TAGGER $TAGGEROPTS -c
"$COMMENTOUTPUT" \
+ elif [ "$ID3TAGV" = "1" ]; then
+ run_command tagtrack-$1 $ID3 $ID3OPTS -c
"$COMMENTOUTPUT" \
-A "$DALBUM" -a "$TRACKARTIST" -t "$TRACKNAME"
-T "$1" "$ABCDETEMPDIR/track$1.$OUTPUTTYPE"
- fi
+ else # assume we want both tags
+ run_command tagtrack-$1 $ID3V2 $ID3V2OPTS -A "$DALBUM"
-a "$TRACKARTIST" \
+ -t "$TRACKNAME" -T "$1"
"$ABCDETEMPDIR/track$1.$OUTPUTTYPE"
+
+ run_command tagtrack-$1 $ID3 $ID3OPTS -c
"$COMMENTOUTPUT" \
+ -A "$DALBUM" -a "$TRACKARTIST" -t "$TRACKNAME"
-T "$1" "$ABCDETEMPDIR/track$1.$OUTPUTTYPE"
+ fi
else
# vorbiscomment can't do in-place modification, mv the file
first
if [ -f "$ABCDETEMPDIR/track$1.$OUTPUTTYPE" -a \! -f
"$ABCDETEMPDIR/track$1.uncommented.$OUTPUTTYPE" ]; then
[end of patch]
You would then add to the default config file (see below) a value for ID3TAGV
(1, 2 or both) - this should be there anyway.
-- System Information
Debian Release: testing/unstable
Kernel Version: Linux callisto 2.4.9 #1 Thu Aug 23 20:14:39 BST 2001 i686
unknown
Versions of the packages abcde depends on:
ii cd-discid 0.7-1 CDDB DiscID utility
ii cdda2wav 1.9-1 Creates WAV files from audio cd's
ii cdparanoia 3a9.8-4 An audio extraction tool for sampling CDs.
ii vorbis-tools 1.0rc1-1 Several Ogg Vorbis Tools
ii wget 1.6-2 utility to retrieve files from the WWW via H
--- Begin /etc/abcde.conf (modified conffile)
LAMEOPTS='-b 56 -v -h -V 2'
OUTPUTDIR=/e/rip/mp3/current
WAVOUTPUTDIR=/e/rip/wav
OUTPUTTYPE=mp3
OUTPUTFORMAT='${ARTISTFILE}/${ALBUMFILE}/${TRACKNUM}-${TRACKFILE}.${OUTPUTTYPE}'
VAOUTPUTFORMAT='${ARTISTFILE}/${TRACKNUM}-${TRACKFILE}.${OUTPUTTYPE}'
ID3TAGV=1
--- End /etc/abcde.conf
--- End Message ---
--- Begin Message ---
On Tue, Sep 01, 2009 at 06:18:59PM +0100, Colin Tuckley wrote:
> Since you opened the above bug the -c option in id3lib has been fixed and
> abcde has been modified accordingly.
>
> Can you please take a look at the bug again and either close it if it's no
> longer relevant or add some comments (and a modified patch) if it's still
> something that is needed.
I don't use abcde with mp3s any more, so I can't verify this, but if
you're happy then I'm happy. I'm closing this bug.
Cheers,
Dominic.
--
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)
--- End Message ---
