Your message dated Tue, 15 Sep 2009 18:17:21 +0000
with message-id <[email protected]>
and subject line Bug#546462: fixed in ekeyd 1.0.5-1
has caused the Debian Bug report #546462,
regarding ekeyd: Incorrect runlevels and dependencies in init.d script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
546462: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=546462
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package:  ekeyd
Version:  1.0.1-1
Severity: serious
Tags:     patch
User:     [email protected]
Usertags: incorrect-runlevels incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The init.d script headers to not match
the arguments used by update-rc.d.  I assume the update-rc.d call is
correct, and propose to adjust the headers.  Also, the scripts uses
files in /usr/, and should depend on $remote_fs, and used to start
after the syslog was operational and should probably continue to do
so.  The udev dependency should probably be optional, as it is not
required to use udev in Debian. Last, I suspect the scripts should
have a fixed order, and the old one was to start ekeyd-egd-linux
before ekeyd.  This should be expressed explicitly.

<URL: 
http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html
 >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should fix the issues.  Setting severity serious as the
script will fail to work if /usr/ is on a separate partition, not yet
mounted when the scripts are executed too early during boot.
 
diff -ur ekeyd-1.0.4/debian/ekeyd-egd-linux.init 
ekeyd-1.0.4-pere/debian/ekeyd-egd-linux.init
--- ekeyd-1.0.4/debian/ekeyd-egd-linux.init     2009-09-13 13:15:20.000000000 
+0200
+++ ekeyd-1.0.4-pere/debian/ekeyd-egd-linux.init        2009-09-13 
13:18:12.000000000 +0200
@@ -2,10 +2,10 @@

 ### BEGIN INIT INFO
 # Provides:          ekeyd-egd-linux
-# Required-Start:
-# Required-Stop:
-# Default-Start:     S
-# Default-Stop:
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Short-Description: Entropy Key Manager, EGD->Linux pool stirrer
 ### END INIT INFO

diff -ur ekeyd-1.0.4/debian/ekeyd.init ekeyd-1.0.4-pere/debian/ekeyd.init
--- ekeyd-1.0.4/debian/ekeyd.init       2009-09-13 13:15:20.000000000 +0200
+++ ekeyd-1.0.4-pere/debian/ekeyd.init  2009-09-13 13:17:50.000000000 +0200
@@ -2,10 +2,11 @@

 ### BEGIN INIT INFO
 # Provides:          ekeyd
-# Required-Start:    udev
-# Required-Stop:
-# Default-Start:     S
-# Default-Stop:
+# Required-Start:    $remote_fs $syslog ekeyd-egd-linux
+# Required-Stop:     $remote_fs $syslog ekeyd-egd-linux
+# Should-Start:      udev
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Short-Description: Entropy Key Manager
 ### END INIT INFO

diff -ur ekeyd-1.0.4/debian/ekeyd.postinst 
ekeyd-1.0.4-pere/debian/ekeyd.postinst
--- ekeyd-1.0.4/debian/ekeyd.postinst   2009-09-13 13:15:20.000000000 +0200
+++ ekeyd-1.0.4-pere/debian/ekeyd.postinst      2009-09-13 13:30:59.000000000 
+0200
@@ -6,5 +6,13 @@
     udevadm control --reload-rules 2>/dev/null || udevadm control 
--reload_rules 2>/dev/null
 fi

+# Those using dependency based boot sequencing with sysv-rc and installing
+# ekeyd-egd-linux before and including version 1.0.4-1 would have wrong
+# runlevel symlinks.  Recover from this.
+if [ "$1" = "configure" ] && dpkg --compare-versions "$2" le "1.0.4-1" \
+   && [ -f /etc/rcS.d/S[0-9][0-9]ekeyd ] ; then
+   update-rc.d -f ekeyd remove
+fi
+
 #DEBHELPER#
diff -urN ekeyd-1.0.4/debian/ekeyd-egd-linux.postinst 
ekeyd-1.0.4-pere/debian/ekeyd-egd-linux.postinst
--- ekeyd-1.0.4/debian/ekeyd-egd-linux.postinst 1970-01-01 01:00:00.000000000 
+0100
+++ ekeyd-1.0.4-pere/debian/ekeyd-egd-linux.postinst    2009-09-13 
13:34:44.000000000 +0200
@@ -0,0 +1,12 @@
+#!/bin/sh -e
+
+# Those using dependency based boot sequencing with sysv-rc and installing
+# ekeyd-egd-linux before and including version 1.0.4-1 would have wrong
+# runlevel symlinks.  Recover from this.
+if [ "$1" = "configure" ] && dpkg --compare-versions "$2" le "1.0.4-1" \
+   && [ -f /etc/rcS.d/S[0-9][0-9]ekeyd-egd-linux ] ; then
+   update-rc.d -f ekeyd-egd-linux remove
+fi
+
+#DEBHELPER#
+

Happy hacking,
-- 
Petter Reinholdtsen



--- End Message ---
--- Begin Message ---
Source: ekeyd
Source-Version: 1.0.5-1

We believe that the bug you reported is fixed in the latest version of
ekeyd, which is due to be installed in the Debian FTP archive:

ekeyd-egd-linux_1.0.5-1_amd64.deb
  to pool/main/e/ekeyd/ekeyd-egd-linux_1.0.5-1_amd64.deb
ekeyd-uds_1.0.5-1_amd64.deb
  to pool/main/e/ekeyd/ekeyd-uds_1.0.5-1_amd64.deb
ekeyd_1.0.5-1.diff.gz
  to pool/main/e/ekeyd/ekeyd_1.0.5-1.diff.gz
ekeyd_1.0.5-1.dsc
  to pool/main/e/ekeyd/ekeyd_1.0.5-1.dsc
ekeyd_1.0.5-1_amd64.deb
  to pool/main/e/ekeyd/ekeyd_1.0.5-1_amd64.deb
ekeyd_1.0.5.orig.tar.gz
  to pool/main/e/ekeyd/ekeyd_1.0.5.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Silverstone <[email protected]> (supplier of updated ekeyd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 15 Sep 2009 16:10:49 +0100
Source: ekeyd
Binary: ekeyd ekeyd-uds ekeyd-egd-linux
Architecture: source amd64
Version: 1.0.5-1
Distribution: unstable
Urgency: low
Maintainer: Simtec Electronics <[email protected]>
Changed-By: Daniel Silverstone <[email protected]>
Description: 
 ekeyd      - Simtec Electronics UDEKEY01 Entropy Key Daemon
 ekeyd-egd-linux - Transfers entropy from an EGD to the Linux kernel pool
 ekeyd-uds  - Simtec Electronics UDEKEY01 Entropy Key Daemon (UDS variant)
Closes: 546462
Changes: 
 ekeyd (1.0.5-1) unstable; urgency=low
 .
   * New upstream release
     - Corrects minor bug in daemonise routines.
     - Adds syslog() support to the ulusbd
   * Update init info in the init scripts with information provided by
     pere.  This does not take all of pere's patch, rather only the parts
     which seemed critical to the correct functioning of the information
     block. (Closes: #546462)
   * Install ekeyd-egd-linux manpage.
Checksums-Sha1: 
 adc52d5c2871ad74ad0acbe6764d8adb4b93aaae 1454 ekeyd_1.0.5-1.dsc
 95b1f54315746ee979b38d62383c0fa7c25ace90 87743 ekeyd_1.0.5.orig.tar.gz
 b6d4cc850984dcd0e3c6b5a2d5b39e5abfd441bb 4921 ekeyd_1.0.5-1.diff.gz
 e20554a31a448f0943007eeec0032ef227eaf877 84254 ekeyd_1.0.5-1_amd64.deb
 f8b8390eeb2304c60c7a17b2be02b034026e817c 10742 ekeyd-uds_1.0.5-1_amd64.deb
 2646c56bb6c7ccf5d78adac0e888eaaafa2303f3 12174 
ekeyd-egd-linux_1.0.5-1_amd64.deb
Checksums-Sha256: 
 a89b1f111b8c8b588fe4cae0ce52e92d8f2f654d73c308cec113d62da48aebcd 1454 
ekeyd_1.0.5-1.dsc
 fc82c4e1c9d702c74bd98df3e4b18f5d1c9dc9ba59ad0a3569d79def02b847e1 87743 
ekeyd_1.0.5.orig.tar.gz
 11d330e54c1f7b39b74f7f006d774ddbe7f9cb3404b268e440e25805c93258a7 4921 
ekeyd_1.0.5-1.diff.gz
 0cd7043807bd57775f6b864e44a7e9f8048cc4198ba7c6118a7bd1b592d95bf9 84254 
ekeyd_1.0.5-1_amd64.deb
 4ef611eec74a4377cfb77be914047fc4b5a9963ae3450c69fc5b9d8200f6708c 10742 
ekeyd-uds_1.0.5-1_amd64.deb
 47f324b09b26da8be933c5b54a18f862403d7dfeb80ba5ecc568a737f674aac8 12174 
ekeyd-egd-linux_1.0.5-1_amd64.deb
Files: 
 cbf0774eda1e4f1f9733ae9eb4bc2bbe 1454 utils optional ekeyd_1.0.5-1.dsc
 dcae806904a7d6e150954f9aca345cf1 87743 utils optional ekeyd_1.0.5.orig.tar.gz
 51e4d26df4c888b240b6eb1766f6b156 4921 utils optional ekeyd_1.0.5-1.diff.gz
 6e8a0d69dd11ec948a74d3d91007f723 84254 utils optional ekeyd_1.0.5-1_amd64.deb
 812f72442c0dace613512c5cf624fc7d 10742 utils optional 
ekeyd-uds_1.0.5-1_amd64.deb
 dcd04a83fc59379a5f641fec433ed318 12174 utils optional 
ekeyd-egd-linux_1.0.5-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQEVAwUBSq/Xi8MN9DnymH10AQqdtAf/YKOtuAYNMn2v824oHxIK/OlO8K5v1OjV
B/1qzbSdpk0jYJzXbC1uRKUMV7P5pP3i6dxlJo7oZKWezCo18obAK3MZK5z+fi+6
hPsqo+EvJSdJsrVSBh2DJhcVQBfaJDwPJYzNhnneHXTbtXJjkLzqmxr6t+aAHIIl
cAVKOGvduu0HYl86WHsRxEMEfprV7lNXGAdZ/rT+t384yFEU6QlmEpkHbgUGojce
q53F6t7djFEsP/vRyqS3VzL4KgpKujWvSyfsu2gfS60UDAXm3MUfxt8BH70LBF4V
KgNd+3wk9O7NQZwA7lZ2/+sY08yYOR9Q11xksbMVaoXkDjaDFxQS9A==
=u4lV
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to