Your message dated Sat, 03 Oct 2009 23:02:24 +0000
with message-id <[email protected]>
and subject line Bug#533513: fixed in graphicsmagick 1.3.5-5.2
has caused the Debian Bug report #533513,
regarding graphicsmagick: FTBFS on hurd-i386 due to unconditional PATH_MAX usage
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
533513: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533513
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: graphicsmagick
Version: 1.3.5-5
Severity: important
Tags: patch
Hello,
graphicsmagick currently FTBFS on hurd-i386 because it unconditionally
uses PATH_MAX, while POSIX says that this may not be defined when there
is no such limitation in the system, which is the case for the Hurd. The
attached patch fixes this.
Samuel
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.30 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
--
Samuel Thibault <[email protected]>
<O> ?a peut ?tre une madeleine ? sous munitions (avec des composants,
par exemple)
-+- #runtime -+-
--- graphicsmagick-1.3.5.orig/magick/utility.c
+++ graphicsmagick-1.3.5/magick/utility.c
@@ -1255,32 +1255,52 @@
some other systems use compatible schemes.
*/
int
- length;
+ length,
+ ret;
long
pid;
char
- link_path[MaxTextExtent],
- real_path[PATH_MAX+1];
+ link_path[MaxTextExtent];
+
+ char *
+ real_path = NULL;
+
+ struct stat
+ linkbuf;
pid=(long) getpid();
/* Linux format */
FormatString(link_path,"/proc/%ld/exe",pid);
- length=readlink(link_path, real_path, PATH_MAX);
- if (length == -1)
+ ret = lstat(link_path, &linkbuf);
+ if (ret == 0)
+ {
+ real_path = malloc(linkbuf.st_size + 1);
+ length=readlink(link_path, real_path, linkbuf.st_size);
+ }
+ if ((ret != 0) || (length == -1))
{
/* Try FreeBSD format */
FormatString(link_path,"/proc/%ld/file",pid);
- length=readlink(link_path, real_path, PATH_MAX);
+ ret = lstat(link_path, &linkbuf);
+ if (ret == 0)
+ {
+ real_path = realloc(real_path, linkbuf.st_size + 1);
+ length=readlink(link_path, real_path, linkbuf.st_size);
+ }
}
- if ((length > 0) && (length <= PATH_MAX))
+ if ((ret == 0) && (length > 0) && (length <= linkbuf.st_size))
{
real_path[length]=0;
if (strlcpy(path,real_path,MaxTextExtent) < MaxTextExtent)
if (IsAccessible(path))
- return(MagickPass);
+ {
+ free(real_path);
+ return(MagickPass);
+ }
}
+ free(real_path);
}
#endif
return(MagickFail);
--- End Message ---
--- Begin Message ---
Source: graphicsmagick
Source-Version: 1.3.5-5.2
We believe that the bug you reported is fixed in the latest version of
graphicsmagick, which is due to be installed in the Debian FTP archive:
graphicsmagick-dbg_1.3.5-5.2_amd64.deb
to pool/main/g/graphicsmagick/graphicsmagick-dbg_1.3.5-5.2_amd64.deb
graphicsmagick-imagemagick-compat_1.3.5-5.2_all.deb
to
pool/main/g/graphicsmagick/graphicsmagick-imagemagick-compat_1.3.5-5.2_all.deb
graphicsmagick-libmagick-dev-compat_1.3.5-5.2_all.deb
to
pool/main/g/graphicsmagick/graphicsmagick-libmagick-dev-compat_1.3.5-5.2_all.deb
graphicsmagick_1.3.5-5.2.diff.gz
to pool/main/g/graphicsmagick/graphicsmagick_1.3.5-5.2.diff.gz
graphicsmagick_1.3.5-5.2.dsc
to pool/main/g/graphicsmagick/graphicsmagick_1.3.5-5.2.dsc
graphicsmagick_1.3.5-5.2_amd64.deb
to pool/main/g/graphicsmagick/graphicsmagick_1.3.5-5.2_amd64.deb
libgraphics-magick-perl_1.3.5-5.2_amd64.deb
to pool/main/g/graphicsmagick/libgraphics-magick-perl_1.3.5-5.2_amd64.deb
libgraphicsmagick++1-dev_1.3.5-5.2_amd64.deb
to pool/main/g/graphicsmagick/libgraphicsmagick++1-dev_1.3.5-5.2_amd64.deb
libgraphicsmagick++3_1.3.5-5.2_amd64.deb
to pool/main/g/graphicsmagick/libgraphicsmagick++3_1.3.5-5.2_amd64.deb
libgraphicsmagick1-dev_1.3.5-5.2_amd64.deb
to pool/main/g/graphicsmagick/libgraphicsmagick1-dev_1.3.5-5.2_amd64.deb
libgraphicsmagick3_1.3.5-5.2_amd64.deb
to pool/main/g/graphicsmagick/libgraphicsmagick3_1.3.5-5.2_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Banck <[email protected]> (supplier of updated graphicsmagick package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Format: 1.8
Date: Mon, 28 Sep 2009 23:02:18 +0200
Source: graphicsmagick
Binary: graphicsmagick libgraphicsmagick3 libgraphicsmagick1-dev
libgraphicsmagick++3 libgraphicsmagick++1-dev libgraphics-magick-perl
graphicsmagick-imagemagick-compat graphicsmagick-libmagick-dev-compat
graphicsmagick-dbg
Architecture: source amd64 all
Version: 1.3.5-5.2
Distribution: unstable
Urgency: low
Maintainer: Daniel Kobras <[email protected]>
Changed-By: Michael Banck <[email protected]>
Description:
graphicsmagick - collection of image processing tools
graphicsmagick-dbg - format-independent image processing - debugging symbols
graphicsmagick-imagemagick-compat - image processing tools providing
ImageMagick interface
graphicsmagick-libmagick-dev-compat - image processing libraries providing
ImageMagick interface
libgraphics-magick-perl - format-independent image processing - perl interface
libgraphicsmagick++1-dev - format-independent image processing - C++
development files
libgraphicsmagick++3 - format-independent image processing - C++ shared library
libgraphicsmagick1-dev - format-independent image processing - C development
files
libgraphicsmagick3 - format-independent image processing - C shared library
Closes: 533513
Changes:
graphicsmagick (1.3.5-5.2) unstable; urgency=low
.
* Non-maintainer upload.
* Applied patch to fix FTBFS on hurd-i386, by Barry deFreese and Samuel
Thibauilt. Closes: #533513.
Checksums-Sha1:
44cff63bce35b796f6fda23b43061d72ed06a950 1520 graphicsmagick_1.3.5-5.2.dsc
3defc0806e068c709ed557fb45f051c757140cee 157877
graphicsmagick_1.3.5-5.2.diff.gz
1e5fb4f1abb8d6031035513c2094fe440c033e33 1139018
graphicsmagick_1.3.5-5.2_amd64.deb
3279aae01e1dc7b833b02da184fe08484ffc66fb 1282874
libgraphicsmagick3_1.3.5-5.2_amd64.deb
9af8529d2141d17f0f6644c9629fafad209b669e 1782974
libgraphicsmagick1-dev_1.3.5-5.2_amd64.deb
0e85f6c229770458fd14bbfd1cd5141443dd1b65 177776
libgraphicsmagick++3_1.3.5-5.2_amd64.deb
51316ffd085ef132fabc85723635b2193e4ae708 466408
libgraphicsmagick++1-dev_1.3.5-5.2_amd64.deb
a2ebad0150b4aaea08dc1b2102914ad0909f99d9 103676
libgraphics-magick-perl_1.3.5-5.2_amd64.deb
2cc8563a22d197b026246a596ea09566a82f8c38 2167036
graphicsmagick-dbg_1.3.5-5.2_amd64.deb
f61f607d8131163dcf9aa93d54ebebab02cb195d 14556
graphicsmagick-imagemagick-compat_1.3.5-5.2_all.deb
c7c5e80984ac2b8dda0232124d4a4b4b96e29421 18130
graphicsmagick-libmagick-dev-compat_1.3.5-5.2_all.deb
Checksums-Sha256:
b8b4b6d6feac6e00fbbb47129f50c4268903590aceb1e9419e1c44d39b11a218 1520
graphicsmagick_1.3.5-5.2.dsc
45f328352b93007a53d8fd5e495f05184476cfa90162cdee790889066deb9ebf 157877
graphicsmagick_1.3.5-5.2.diff.gz
6bb0c8ed47b116cf6b19a1ea716481026532e1decc10aeeab7c85530b5315758 1139018
graphicsmagick_1.3.5-5.2_amd64.deb
c4f206397075865f914e4758b47ae12ed81bbba933220080c1efb79f3cd9176b 1282874
libgraphicsmagick3_1.3.5-5.2_amd64.deb
e2cde7311e91287a4d7d225134bb3e53def986b166241aa0c67286be0efe17c7 1782974
libgraphicsmagick1-dev_1.3.5-5.2_amd64.deb
48612888e2bf5cf8729d6abdd3ab7a9cea8ba40b6389f9ce0f350bcc6f31bd7c 177776
libgraphicsmagick++3_1.3.5-5.2_amd64.deb
050522f4dbfa45d070738f7292b1390ff69c5f01959bd6c5da3d8000eb50a7e5 466408
libgraphicsmagick++1-dev_1.3.5-5.2_amd64.deb
d1056546ea507f27319ddca3eeb1779965002c1f3acea83954a369eb73313de0 103676
libgraphics-magick-perl_1.3.5-5.2_amd64.deb
55f0413370ceb5b48d05cf6420fe8a6015132375e2f6f0c152220e3d65017afc 2167036
graphicsmagick-dbg_1.3.5-5.2_amd64.deb
66b9da3119628bec63d73fce75d0342211a088c2b4708f877cf3a7e985307c2c 14556
graphicsmagick-imagemagick-compat_1.3.5-5.2_all.deb
0f8a164c0b5b034a703a5b9ef4cf0606ad8c462f1683539157fe13c4e0b4fed7 18130
graphicsmagick-libmagick-dev-compat_1.3.5-5.2_all.deb
Files:
e422b63a03e4ece0c19b8d14df5764a6 1520 graphics optional
graphicsmagick_1.3.5-5.2.dsc
aff044b5bd1c37abdd4880ace50c1687 157877 graphics optional
graphicsmagick_1.3.5-5.2.diff.gz
540316770ca0041ccdb5035df33144c4 1139018 graphics optional
graphicsmagick_1.3.5-5.2_amd64.deb
062b407e43e0c919f9949af0036c9a4c 1282874 libs optional
libgraphicsmagick3_1.3.5-5.2_amd64.deb
ccb8516d6ac423e51505b803de796539 1782974 libdevel optional
libgraphicsmagick1-dev_1.3.5-5.2_amd64.deb
2e31ff3619fe449371e4b7ef56e06f45 177776 libs optional
libgraphicsmagick++3_1.3.5-5.2_amd64.deb
2f7d947f7430c5b9933675fad98201f2 466408 libdevel optional
libgraphicsmagick++1-dev_1.3.5-5.2_amd64.deb
8c23a5751b6ebc8ce66edd60e8b073e3 103676 perl optional
libgraphics-magick-perl_1.3.5-5.2_amd64.deb
e083c8f5b1ca1fd57af927d3e6a63535 2167036 debug extra
graphicsmagick-dbg_1.3.5-5.2_amd64.deb
e5cbaf3389dc868ba8b0e6d70c74d58b 14556 graphics extra
graphicsmagick-imagemagick-compat_1.3.5-5.2_all.deb
b31e39bfffc6b259614a03bd37650ee9 18130 graphics extra
graphicsmagick-libmagick-dev-compat_1.3.5-5.2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iD8DBQFKwTgCmHaJYZ7RAb8RA3lxAJwIzO7SBBeaY7dqeepFq8Zpgc+mQACg0ERU
4tn5oQ575XjgnPL6eKC1To8=
=rt9f
-----END PGP SIGNATURE-----
--- End Message ---
