Your message dated Wed, 21 Oct 2009 11:32:09 +0000
with message-id <[email protected]>
and subject line Bug#449591: fixed in tcpslice 1.2a3-3
has caused the Debian Bug report #449591,
regarding tcpslice: failure due to use of freed memory structure in
extract_slice, patch available
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
449591: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=449591
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tcpslice
Version: 1.2a3-2
Severity: important
Tags: patch
extract_slice() may make use of a freed "states" element if trying to
slice against several tcpdump files where the first tcpdump file is not
included by the timespec the user specified (and then closed and freed).
The call to pcap_dump_open then incorrectly references the first element
of states, ala "dumper = pcap_dump_open(states->p, ...."
Program may exit normally, and work, or not work, or give a pcap error
about linktype -1 being invalid.
electric-fence with the EF_WIPE_FREE option shows this up.
-- System Information:
Debian Release: 4.0
APT prefers stable
APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-5-686
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Versions of packages tcpslice depends on:
ii libc6 2.3.6.ds1-13etch2 GNU C Library: Shared libraries
ii libpcap0.7 0.7.2-7 System interface for user-level pa
tcpslice recommends no packages.
-- no debconf information
diff -ur tcpslice-1.2a3/tcpslice.c ../tcpslice-1.2a3/tcpslice.c
--- tcpslice-1.2a3/tcpslice.c 2005-10-24 15:06:26.000000000 -0700
+++ ../tcpslice-1.2a3/tcpslice.c 2007-11-06 13:50:54.000000000 -0800
@@ -598,6 +598,7 @@
pcap_dumper_t *dumper;
struct timeval temp1, temp2, relative_start, relative_stop;
int i;
+ struct state *statetemplate = NULL;
struct state *last_state; /* remember the last packet */
struct pcap_pkthdr last_hdr; /* in order to remove duplicates */
@@ -639,6 +640,10 @@
continue;
}
+ if (statetemplate == NULL) {
+ statetemplate = s;
+ }
+
/*
* sf_find_packet() requires that the time it's passed as
* its last argument be in the range [min_time, max_time],
@@ -657,7 +662,7 @@
get_next_packet(s);
}
- dumper = pcap_dump_open(states->p, write_file_name);
+ dumper = pcap_dump_open(statetemplate->p, write_file_name);
if (! dumper) {
error( "error creating output file %s: ",
write_file_name, pcap_geterr( states->p ) );
--- End Message ---
--- Begin Message ---
Source: tcpslice
Source-Version: 1.2a3-3
We believe that the bug you reported is fixed in the latest version of
tcpslice, which is due to be installed in the Debian FTP archive:
tcpslice_1.2a3-3.diff.gz
to pool/main/t/tcpslice/tcpslice_1.2a3-3.diff.gz
tcpslice_1.2a3-3.dsc
to pool/main/t/tcpslice/tcpslice_1.2a3-3.dsc
tcpslice_1.2a3-3_sparc.deb
to pool/main/t/tcpslice/tcpslice_1.2a3-3_sparc.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jochen Friedrich <[email protected]> (supplier of updated tcpslice package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 21 Oct 2009 12:21:01 +0200
Source: tcpslice
Binary: tcpslice
Architecture: source sparc
Version: 1.2a3-3
Distribution: unstable
Urgency: low
Maintainer: Jochen Friedrich <[email protected]>
Changed-By: Jochen Friedrich <[email protected]>
Description:
tcpslice - extract pieces of and/or glue together tcpdump files
Closes: 449591 521068
Changes:
tcpslice (1.2a3-3) unstable; urgency=low
.
* Convert to debhelper 7.
* Add README.source.
* Bump standards version to 3.8.3.
* Add patch to accept captures with zero or one packet. (Closes: #521068)
Thanks to Sam Roberts <[email protected]> for the patch.
* Add patch to avoid using freed memory in extract_slice. (Closes: #449591)
Thanks to Ted Deppner <[email protected]> for the patch.
Checksums-Sha1:
b11c8dbaa26c2981efc70ed125a4bac08d178e35 1007 tcpslice_1.2a3-3.dsc
b2acc1436897032b699ac17fb60b5c2f9589f5b9 5451 tcpslice_1.2a3-3.diff.gz
cf9bf6fea9559631bb7404d62803b1acceed0c15 18214 tcpslice_1.2a3-3_sparc.deb
Checksums-Sha256:
6d308bd5b97b8923e9691a24a80bf8e33ee1c85aab50dcb49a7148c39c9e5146 1007
tcpslice_1.2a3-3.dsc
f50e21068024ac1d0b933b4fee773eb4b25fbb05dd81d33e93b5978e5988cd26 5451
tcpslice_1.2a3-3.diff.gz
4944f48f2b3c109a09199b293ad29e3b51f76468f45db1bcb5c5caf35b0b7990 18214
tcpslice_1.2a3-3_sparc.deb
Files:
26dc4885cc5b40595367bdc5259bbc82 1007 net optional tcpslice_1.2a3-3.dsc
44275a5c73458f4474849150e25f5e38 5451 net optional tcpslice_1.2a3-3.diff.gz
9fd39e85db2f8155d40f71061bd47763 18214 net optional tcpslice_1.2a3-3_sparc.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iD8DBQFK3uyI0fhX0Y/ocz0RAhOQAJ97PqS+ufsYrejMQAULZlo71XLP1QCfcR3r
NDQeVlz62Ud+2FplvsAmgEY=
=Vlym
-----END PGP SIGNATURE-----
--- End Message ---
