Your message dated Tue, 3 Nov 2009 15:14:34 +0100
with message-id <[email protected]>
and subject line Re: Bug#520440: poppler: some header files causes gcc warnings
has caused the Debian Bug report #520440,
regarding poppler: some header files causes gcc warnings
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
520440: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=520440
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libpoppler-dev
Version: 0.10.4-3
Severity: minor
Inclusion of some poppler header files causes gcc to emit dozens of
warnings. See [1] for an example build log.
Poppler build system suppresses those warnings with -Wno-write-strings.
I could, of course, use that option too. However, I don't want to
conceal potential bugs in my own code.
The attached patch fixes the symptoms in <poppler/Object.h>.
[1]
https://buildd.debian.org/fetch.cgi?&pkg=pdf2djvu&ver=0.4.11a-1%2Bb1&arch=i386&stamp=1236513697&file=log
--
Jakub Wilk
diff --git a/poppler/Object.h b/poppler/Object.h
--- a/poppler/Object.h
+++ b/poppler/Object.h
@@ -46,14 +46,14 @@
#define OBJECT_TYPE_CHECK(wanted_type) \
if (unlikely(type != wanted_type)) { \
- error(0, "Call to Object where the object was type %d, " \
+ error(0, (char*) "Call to Object where the object was type %d, " \
"not the expected type %d", type, wanted_type); \
abort(); \
}
#define OBJECT_2TYPES_CHECK(wanted_type1, wanted_type2) \
if (unlikely(type != wanted_type1) && unlikely(type != wanted_type2)) { \
- error(0, "Call to Object where the object was type %d, " \
+ error(0, (char*) "Call to Object where the object was type %d, " \
"not the expected type %d or %d", type, wanted_type1, wanted_type2); \
abort(); \
}
--- End Message ---
--- Begin Message ---
Version: 0.12.0-1
The bug was fixed by upstream.
--
Jakub Wilk
--- End Message ---
