Your message dated Sun, 08 Nov 2009 17:32:30 +0000
with message-id <[email protected]>
and subject line Bug#554904: fixed in hellanzb 0.13-5.3
has caused the Debian Bug report #554904,
regarding HellaNZB crashes on startup when missing unrar package
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
554904: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=554904
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: hellanzb
Version: 0.13-5.2
Severity: important
Tags: patch
The hellanzb package has been patched so that it doesn't use unrar by
default in order to prevent the package from being moved from main to
contrib. In more detail, the SKIP_UNRAR configuration option defaults to
True in Debian and unrar has been added to hellanzb's Suggests. So far
so good.
However, hellanzb crashes on startup if unrar isn't installed, no matter
what the SKIP_UNRAR configuration option is set to:
A problem occurred while reading the config file: FatalError'>:
Cannot continue program, required executable not found: 'unrar'
Exiting: FatalError'>: Cannot continue program, required
executable not found: 'unrar'
The attached debdiff fixes this bug. It changes hellanzb's Core.py so
that it only looks for the unrar executable if SKIP_UNRAR is not set to
True. The diff also contains other minor changes, which of course can be
dropped if they're not welcome:
* Bump Standards-Version to 3.8.3 (no changes needed).
* Add README.sources to fix patch-system-but-no-source-readme lintian
warning.
* Minor cleanup in README.Debian and NEWS.Debian.
If the patch is applied, I'll take care of sending it upstream. However,
the project is more or less dead.
Fixing this bug will also make it possible to finally resolve #523851,
because up to now, LottaNZB depended unrar only to prevent HellaNZB from
crashing.
Regards,
Severin Heiniger
diff -u hellanzb-0.13/debian/control hellanzb-0.13/debian/control
--- hellanzb-0.13/debian/control
+++ hellanzb-0.13/debian/control
@@ -4,7 +4,7 @@
Maintainer: Adam Cécile (Le_Vert) <[email protected]>
Build-Depends: debhelper (>= 5.0.37.2), dpatch
Build-Depends-Indep: python-all-dev (>= 2.5.4), python-all, python-support (>= 0.5.3)
-Standards-Version: 3.8.1
+Standards-Version: 3.8.3
Homepage: http://www.hellanzb.com/
Package: hellanzb
diff -u hellanzb-0.13/debian/changelog hellanzb-0.13/debian/changelog
--- hellanzb-0.13/debian/changelog
+++ hellanzb-0.13/debian/changelog
@@ -1,3 +1,13 @@
+hellanzb (0.13-5.3) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Bump Standards-Version to 3.8.3 (no changes needed).
+ * Add new patch to fix crash when unrar isn't installed.
+ * Add README.sources to fix patch-system-but-no-source-readme lintian warning.
+ * Minor cleanup in README.Debian and NEWS.Debian.
+
+ -- Severin Heiniger <[email protected]> Wed, 04 Nov 2009 19:32:33 +0100
+
hellanzb (0.13-5.2) unstable; urgency=low
* Non-maintainer upload.
diff -u hellanzb-0.13/debian/NEWS.Debian hellanzb-0.13/debian/NEWS.Debian
--- hellanzb-0.13/debian/NEWS.Debian
+++ hellanzb-0.13/debian/NEWS.Debian
@@ -1,16 +1,16 @@
hellanzb (0.11-1) experimental; urgency=low
- On previous version, hellanzb XMLRPC server was listening to world.
- It's really unsafe and expose user to several security issues if he doesn't
- change the default password.
+ In previous versions, the HellaNZB XMLRPC server accepted connections from
+ anywhere. Not changing the default password exposed the user to several
+ security issues.
- Therefore, I added a new configuration directive named
- Hellanzb.XMLRPC_SERVER_BIND. If it's not set, remote access to the XMLRPC
- server is disabled (binded to 127.0.0.1).
+ Therefore, a new configuration directive named Hellanzb.XMLRPC_SERVER_BIND
+ has been added. If it's not set, remote access to the XMLRPC server is
+ disabled (bound to 127.0.0.1).
- To reproduce the same behavior as previous version, just add:
- Hellanzb.XMLRPC_SERVER_BIND. = '0.0.0.0' to hellanzb.conf.
+ To reproduce the same behavior as previous versions, just add
+ Hellanzb.XMLRPC_SERVER_BIND = '0.0.0.0' to hellanzb.conf.
- /!\ Please add Hellanzb.XMLRPC_SERVER_BIND. to your configuration file.
+ Please add Hellanzb.XMLRPC_SERVER_BIND to your configuration file.
-- Adam Cécile (Le_Vert) <[email protected]> Sat, 10 Feb 2007 15:01:20 +0100
diff -u hellanzb-0.13/debian/README.Debian hellanzb-0.13/debian/README.Debian
--- hellanzb-0.13/debian/README.Debian
+++ hellanzb-0.13/debian/README.Debian
@@ -1,12 +1,11 @@
-hellanzb for Debian
-----------------------
+HellaNZB for Debian
+-------------------
-The default configuration files skip unraring during post processing
-("Hellanzb.SKIP_UNRAR = True").
+The default configuration file skips unraring during post-processing
+(Hellanzb.SKIP_UNRAR is set to True). This is necessary to prevent the package
+from being moved from main to contrib.
-I removed unrar call to avoid the package to be moved from main to contrib.
-
-You can enable this feature again but you need to install unrar package from
-non-free.
+You can enable this feature again but you'll need to install the non-free
+unrar package.
-- Adam Cécile (Le_Vert) <[email protected]>, Fri, 8 Sep 2006 21:12:36 +0200
diff -u hellanzb-0.13/debian/patches/00list hellanzb-0.13/debian/patches/00list
--- hellanzb-0.13/debian/patches/00list
+++ hellanzb-0.13/debian/patches/00list
@@ -5,0 +6 @@
+005-Fix_crash_on_missing_unrar
only in patch2:
unchanged:
--- hellanzb-0.13.orig/debian/README.source
+++ hellanzb-0.13/debian/README.source
@@ -0,0 +1,26 @@
+This package uses dpatch to manage all modifications to the upstream
+source. Changes are stored in the source package as diffs in
+debian/patches and applied during the build.
+
+To get the fully patched source after unpacking the source package, cd
+to the root level of the source package and run:
+
+ debian/rules patch
+
+Removing a patch is as simple as removing its entry from the
+debian/patches/00list file, and please also remove the patch file
+itself.
+
+Creating a new patch is done with "dpatch-edit-patch patch XX_patchname"
+where you should replace XX with a new number and patchname with a
+descriptive shortname of the patch. You can then simply edit all the
+files your patch wants to edit, and then simply "exit 0" from the shell
+to actually create the patch file.
+
+To tweak an already existing patch, call "dpatch-edit-patch XX_patchname"
+and replace XX_patchname with the actual filename from debian/patches
+you want to use.
+
+To clean up afterwards again, "debian/rules unpatch" will do the
+work for you - or you can of course choose to call
+"fakeroot debian/rules clean" all together.
only in patch2:
unchanged:
--- hellanzb-0.13.orig/debian/patches/005-Fix_crash_on_missing_unrar
+++ hellanzb-0.13/debian/patches/005-Fix_crash_on_missing_unrar
@@ -0,0 +1,42 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 005-Fix_crash_on_missing_unrar by
+## Severin Heiniger <[email protected]>
+##
+## DP: This package doesn't depend on unrar and SKIP_UNRAR is set to True by the
+## DP: 002-Debianize_conf_file patch.
+## DP: However, if unrar isn't installed, HellaNZB crashes on startup no matter
+## DP: what SKIP_UNRAR is set to. This patch causes HellaNZB not to look for the
+## DP: unrar executable if SKIP_UNRAR is set to True.
+
+...@dpatch@
+diff -urNad hellanzb-0.13~/Hellanzb/Core.py hellanzb-0.13/Hellanzb/Core.py
+--- hellanzb-0.13~/Hellanzb/Core.py 2009-11-04 19:30:49.115313617 +0100
++++ hellanzb-0.13/Hellanzb/Core.py 2009-11-04 19:31:16.375292395 +0100
+@@ -84,10 +84,14 @@
+ else:
+ Hellanzb.MAX_RATE = int(Hellanzb.MAX_RATE)
+
+- if not hasattr(Hellanzb, 'UNRAR_CMD') or Hellanzb.UNRAR_CMD is None:
+- Hellanzb.UNRAR_CMD = assertIsExe(['rar', 'unrar'])
+- else:
+- Hellanzb.UNRAR_CMD = assertIsExe([Hellanzb.UNRAR_CMD])
++ if not hasattr(Hellanzb, 'SKIP_UNRAR') or Hellanzb.SKIP_UNRAR is None:
++ Hellanzb.SKIP_UNRAR = False
++
++ if not Hellanzb.SKIP_UNRAR:
++ if not hasattr(Hellanzb, 'UNRAR_CMD') or Hellanzb.UNRAR_CMD is None:
++ Hellanzb.UNRAR_CMD = assertIsExe(['rar', 'unrar'])
++ else:
++ Hellanzb.UNRAR_CMD = assertIsExe([Hellanzb.UNRAR_CMD])
+
+ if not hasattr(Hellanzb, 'PAR2_CMD') or Hellanzb.PAR2_CMD is None:
+ Hellanzb.PAR2_CMD = assertIsExe(['par2'])
+@@ -104,8 +108,6 @@
+ else:
+ Hellanzb.MACBINCONV_CMD = assertIsExe([Hellanzb.MACBINCONV_CMD])
+
+- if not hasattr(Hellanzb, 'SKIP_UNRAR') or Hellanzb.SKIP_UNRAR is None:
+- Hellanzb.SKIP_UNRAR = False
+ if not hasattr(Hellanzb, 'XMLRPC_SERVER_BIND') or Hellanzb.XMLRPC_SERVER_BIND is None:
+ print 'Warning: Hellanzb.XMLRPC_SERVER_BIND is not set, bind to 127.0.0.1'
+ Hellanzb.XMLRPC_SERVER_BIND = '127.0.0.1'
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
--- End Message ---
--- Begin Message ---
Source: hellanzb
Source-Version: 0.13-5.3
We believe that the bug you reported is fixed in the latest version of
hellanzb, which is due to be installed in the Debian FTP archive:
hellanzb_0.13-5.3.diff.gz
to main/h/hellanzb/hellanzb_0.13-5.3.diff.gz
hellanzb_0.13-5.3.dsc
to main/h/hellanzb/hellanzb_0.13-5.3.dsc
hellanzb_0.13-5.3_all.deb
to main/h/hellanzb/hellanzb_0.13-5.3_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Severin Heiniger <[email protected]> (supplier of updated hellanzb
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 08 Nov 2009 11:20:53 +0100
Source: hellanzb
Binary: hellanzb
Architecture: source all
Version: 0.13-5.3
Distribution: unstable
Urgency: low
Maintainer: Adam Cécile (Le_Vert) <[email protected]>
Changed-By: Severin Heiniger <[email protected]>
Description:
hellanzb - Newzbin (nzb) & BinNews (bns) files downloader and post-processor
Closes: 554904
Changes:
hellanzb (0.13-5.3) unstable; urgency=low
.
* Non-maintainer upload.
* Bump Standards-Version to 3.8.3 (no changes needed).
* Add new patch to fix crash when unrar isn't installed. (Closes: #554904)
* Add README.sources to fix patch-system-but-no-source-readme lintian
warning.
* Minor cleanup in README.Debian and NEWS.Debian.
Checksums-Sha1:
2cb2a030e9d2af7d13a969279c2d697c0a377392 1741 hellanzb_0.13-5.3.dsc
c26e00033e5924a6c1a2c1a2594933719c959de8 10792 hellanzb_0.13-5.3.diff.gz
1154f088d36a0adab483ce03ccd56e8c1c90edf1 172392 hellanzb_0.13-5.3_all.deb
Checksums-Sha256:
34a61391591b0d8c727f7b89abdf7c4af62f0a46207ae264f14765c7b80bb22a 1741
hellanzb_0.13-5.3.dsc
630947c70edcf5c1dcda4fdb41ec5ccd248033fb9d1add290f85f0f8946e1702 10792
hellanzb_0.13-5.3.diff.gz
8c0691a2b294fb89cbcf2c943b22af245ae6eff0a01568242c0b13c01cbcd35a 172392
hellanzb_0.13-5.3_all.deb
Files:
848eee8dc9db3b8446db670d6fe089a8 1741 net extra hellanzb_0.13-5.3.dsc
62e4b54e8aeb1fc68de2f7787122f2f0 10792 net extra hellanzb_0.13-5.3.diff.gz
0ff26713fa3f081bbc04d4b926bd0bcf 172392 net extra hellanzb_0.13-5.3_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iQIcBAEBCgAGBQJK9vWNAAoJEHqPSei2NIC+D1gP/3mlDUHEP8weH8vEwz/C9K8u
rQZlZzf4HcIJ0EGoSUk6XzcbWFKFFWP+ra//+xhxY33WF2zttsygb9QQFZ4pEpdU
diJd9OwvKXuehRtofTGpg92Fxg61uzeqP40rQmsCo4kiuwU8M7BTkEEjdZ7oiH/J
xeA5Adp8QkbjYN44BwJ3tQ0dsv8da3GYlEH8ijb/BYs8f1TFOVU7zuIRscFwCZGN
cPZpCX+NnIUpRLEvX02jNe1fOENgx5WY3s43RsFaSIdzXs5M52561eiV7/vU68m1
7t0Q6e75ixKke25QoNPyjlEAl/dQJsBlGxOacuiFWAARzq7luLDupzRW1TM6qt8O
0iGyLHLZ03u6qF8voS3Rmdr5lRixcRDMhvcQr8hjCRip8Kv0hJSDvfhP9tXkRUbe
fng0c7UgSMYvfmOtOEwyIudmvVCl4rEOglhmaK8OKL2Sg/tDqjFRkbY2ruuAFddp
xDz9/cuVj2kRgSsHWY2rFJZa155hwqJncYiJqKstOcirQ3rfZcVV/sh06um11TYb
kqbedTjg4CGeoAS6fbbmqVJTrzE2hfid9paBUgug6Kd+jCwdKCKGMpYpkMZt7HJz
HCA5v9XW0qWQrTxfdTxviqRgKwukt2fBOYhJ/0bhIS/VAog8SswiTOQNFyDFTd9U
W1biRwv31JMayCV5wQtK
=Ic0u
-----END PGP SIGNATURE-----
--- End Message ---
