Your message dated Tue, 10 Nov 2009 22:32:40 +0000
with message-id <e1n7zgs-0003af...@ries.debian.org>
and subject line Bug#555055: fixed in gvfs 1.4.1-3
has caused the Debian Bug report #555055,
regarding gvfs: FTBFS on hurd-i386
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
555055: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=555055
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: gvfs
Version: 1.4.1-2
Severity: important
Tags: patch

Hello,

gvfs currently FTBFS on hurd-i386 because of unconditional use of
PATH_MAX. The attached patch fixes it by just using glibc's ability to
allocate just what is required. It also actually fixes a bug for the
case when a symlink in /dev doesn't exist. It also enables the
libcdio-paranoia-dev dep which is now available on hurd-i386, and drops
the gphoto2 backends which can not yet be built on hurd-i386.

Samuel

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.31 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gvfs depends on:
ii  libc6                         2.9-25     GNU C Library: Shared libraries
ii  libdbus-1-3                   1.2.16-2   simple interprocess messaging syst
ii  libgconf2-4                   2.28.0-1   GNOME configuration database syste
ii  libglib2.0-0                  2.22.2-2   The GLib library of C routines
ii  libhal1                       0.5.13-3   Hardware Abstraction Layer - share
ii  libudev0                      146-5      libudev shared library
ii  x11-utils                     7.4+1      X11 utilities

Versions of packages gvfs recommends:
ii  dbus                          1.2.16-2   simple interprocess messaging syst
pn  gnome-mount | exo-utils       <none>     (no description available)
ii  hal                           0.5.13-3   Hardware Abstraction Layer

Versions of packages gvfs suggests:
ii  gvfs-backends                 1.4.1-2    userspace virtual filesystem - bac

-- no debconf information

-- 
Samuel Thibault <samuel.thiba...@fnac.net>
#ifndef I_WISH_WORLD_WERE_PERFECT
/* It is not :-( All the routers (except for Linux) return only
...
 -+- linux/net/ipv4/ipip.c -+-
--- ./monitor/hal/ghalvolumemonitor.c.orig      2009-11-08 00:15:19.000000000 
+0000
+++ ./monitor/hal/ghalvolumemonitor.c   2009-11-08 00:18:53.000000000 +0000
@@ -739,11 +739,23 @@
         }
       else
         {
-          char resolved_device_path[PATH_MAX];
           /* handle symlinks such as /dev/disk/by-uuid/47C2-1994 */
+#ifdef __GLIBC__
+          char *resolved_device_path;
+          resolved_device_path = realpath (device_path, NULL);
+          if (resolved_device_path != NULL &&
+              strcmp (resolved_device_path, device_file) == 0)
+            {
+              free (resolved_device_path);
+              return mount_point;
+            }
+          free (resolved_device_path);
+#else
+          char resolved_device_path[PATH_MAX];
           if (realpath (device_path, resolved_device_path) != NULL &&
               strcmp (resolved_device_path, device_file) == 0)
             return mount_point;
+#endif
         }
     }
 
--- ./monitor/gdu/ggduvolumemonitor.c.orig      2009-11-08 00:17:33.000000000 
+0000
+++ ./monitor/gdu/ggduvolumemonitor.c   2009-11-08 00:22:27.000000000 +0000
@@ -695,15 +695,27 @@
         }
       else
         {
+          /* handle symlinks such as /dev/disk/by-uuid/47C2-1994 */
+#ifdef __GLIBC__
+          char *resolved_fstab_device_file;
+          resolved_fstab_device_file = realpath (fstab_device_file, NULL);
+          if (resolved_fstab_device_file != NULL &&
+              g_strcmp0 (resolved_fstab_device_file, device_file) == 0)
+            {
+              free (resolved_fstab_device_file);
+              goto out;
+            }
+          free(resolved_fstab_device_file);
+#else
           char resolved_fstab_device_file[PATH_MAX];
 
-          /* handle symlinks such as /dev/disk/by-uuid/47C2-1994 */
           if (realpath (fstab_device_file, resolved_fstab_device_file) != NULL 
&&
               g_strcmp0 (resolved_fstab_device_file, device_file) == 0)
             {
               ret = mount_point;
               goto out;
             }
+#endif
         }
     }
 
@@ -1384,15 +1396,29 @@
       device_file = g_unix_mount_point_get_device_path (mount_point);
       if (g_str_has_prefix (device_file, "/dev/"))
         {
-          gchar resolved_path[PATH_MAX];
           GduDevice *device;
+#ifdef __GLIBC__
+          gchar *resolved_path;
+
+          /* doesn't exist */
+          resolved_path = realpath (device_file, NULL);
+          if (resolved_path == NULL) {
+            free(resolved_path);
+            continue;
+          }
+#else
+          gchar resolved_path[PATH_MAX];
 
           /* doesn't exist */
-          if (realpath (device_file, resolved_path) != 0)
+          if (realpath (device_file, resolved_path) == NULL)
             continue;
+#endif
 
           /* is handled by DKD */
           device = gdu_pool_get_by_device_file (monitor->pool, resolved_path);
+#ifdef __GLIBC__
+          free(resolved_path);
+#endif
           if (device != NULL)
             {
               g_object_unref (device);
--- debian/control.orig 2009-11-08 01:59:34.000000000 +0000
+++ debian/control      2009-11-08 01:56:45.000000000 +0000
@@ -23,7 +23,7 @@
                libgconf2-dev,
                libhal-dev (>= 0.5.10),
                libgudev-1.0-dev (>= 001) | not+linux-gnu,
-               libcdio-paranoia-dev (>= 0.78.2) | hurd,
+               libcdio-paranoia-dev (>= 0.78.2),
                libbluetooth-dev (>= 4.0) | not+linux-gnu,
                libdbus-glib-1-dev,
                libexpat1-dev,
--- /dev/null   2007-12-29 19:47:02.000000000 +0000
+++ debian/gvfs-backends.install.hurd-i386      2009-11-08 10:28:20.000000000 
+0000
@@ -0,0 +1,26 @@
+debian/tmp/usr/lib/gvfs/gvfsd-archive
+debian/tmp/usr/lib/gvfs/gvfsd-cdda
+debian/tmp/usr/lib/gvfs/gvfsd-dav
+debian/tmp/usr/lib/gvfs/gvfsd-dnssd
+debian/tmp/usr/lib/gvfs/gvfsd-ftp
+debian/tmp/usr/lib/gvfs/gvfsd-http
+debian/tmp/usr/lib/gvfs/gvfsd-network
+# Now installed from debian/rules:
+# debian/tmp/usr/lib/gvfs/gvfsd-obexftp
+debian/tmp/usr/lib/gvfs/gvfsd-sftp
+debian/tmp/usr/lib/gvfs/gvfsd-smb
+debian/tmp/usr/lib/gvfs/gvfsd-smb-browse
+debian/tmp/usr/lib/libgvfscommon-dnssd.so.*
+debian/tmp/usr/share/gvfs/mounts/archive.mount
+debian/tmp/usr/share/gvfs/mounts/cdda.mount
+debian/tmp/usr/share/gvfs/mounts/dav.mount
+debian/tmp/usr/share/gvfs/mounts/dav+sd.mount
+debian/tmp/usr/share/gvfs/mounts/dns-sd.mount
+debian/tmp/usr/share/gvfs/mounts/ftp.mount
+debian/tmp/usr/share/gvfs/mounts/http.mount
+debian/tmp/usr/share/gvfs/mounts/network.mount
+# Now installed from debian/rules:
+# debian/tmp/usr/share/gvfs/mounts/obexftp.mount
+debian/tmp/usr/share/gvfs/mounts/sftp.mount
+debian/tmp/usr/share/gvfs/mounts/smb-browse.mount
+debian/tmp/usr/share/gvfs/mounts/smb.mount

--- End Message ---
--- Begin Message ---
Source: gvfs
Source-Version: 1.4.1-3

We believe that the bug you reported is fixed in the latest version of
gvfs, which is due to be installed in the Debian FTP archive:

gvfs-backends_1.4.1-3_i386.deb
  to main/g/gvfs/gvfs-backends_1.4.1-3_i386.deb
gvfs-bin_1.4.1-3_i386.deb
  to main/g/gvfs/gvfs-bin_1.4.1-3_i386.deb
gvfs-dbg_1.4.1-3_i386.deb
  to main/g/gvfs/gvfs-dbg_1.4.1-3_i386.deb
gvfs-fuse_1.4.1-3_i386.deb
  to main/g/gvfs/gvfs-fuse_1.4.1-3_i386.deb
gvfs_1.4.1-3.diff.gz
  to main/g/gvfs/gvfs_1.4.1-3.diff.gz
gvfs_1.4.1-3.dsc
  to main/g/gvfs/gvfs_1.4.1-3.dsc
gvfs_1.4.1-3_i386.deb
  to main/g/gvfs/gvfs_1.4.1-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 555...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Emilio Pozuelo Monfort <po...@debian.org> (supplier of updated gvfs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 10 Nov 2009 23:08:45 +0100
Source: gvfs
Binary: gvfs gvfs-fuse gvfs-backends gvfs-bin gvfs-dbg
Architecture: source i386
Version: 1.4.1-3
Distribution: unstable
Urgency: low
Maintainer: Sebastien Bacher <seb...@debian.org>
Changed-By: Emilio Pozuelo Monfort <po...@debian.org>
Description: 
 gvfs       - userspace virtual filesystem - server
 gvfs-backends - userspace virtual filesystem - backends
 gvfs-bin   - userspace virtual filesystem - binaries
 gvfs-dbg   - userspace virtual filesystem - debugging information
 gvfs-fuse  - userspace virtual filesystem - fuse server
Closes: 555055
Changes: 
 gvfs (1.4.1-3) unstable; urgency=low
 .
   * debian/patches/04_hurd_path_max.patch:
     - Fix the build in the Hurd.
   * debian/control.in:
     - Build-dep on libcdio-paranoia-dev on the Hurd now that it's available
       there.
   * debian/gvfs-backends.install,
     debian/rules:
     - Don't install the gphoto2 backend on the Hurd.
   * Thanks to Samuel Thibault for all the above. This closes: #555055.
Checksums-Sha1: 
 25ec8a185a3f23e89bb417c3983688a825eb713f 1818 gvfs_1.4.1-3.dsc
 47c92efd6dcad1820f1f3d43ae60924e64902019 96983 gvfs_1.4.1-3.diff.gz
 39d41f223e782bb8e4cd9b0335d9550537c9893c 1166738 gvfs_1.4.1-3_i386.deb
 bbed4d2eed10a4b2f47ef9dd10ee88608a8ac029 61230 gvfs-fuse_1.4.1-3_i386.deb
 f7324f5ee2d97668619e9f6b8cebc5b010f04405 706822 gvfs-backends_1.4.1-3_i386.deb
 33dd8f3836a65b9eda2fceafce14c2e7b351778c 88902 gvfs-bin_1.4.1-3_i386.deb
 21896a12fa8c522092adb1f04e567cd20f7f487d 3714608 gvfs-dbg_1.4.1-3_i386.deb
Checksums-Sha256: 
 615b04d559222919a859df2f557f760e1a53e8553bb58624ea2b3a162b5c0ebf 1818 
gvfs_1.4.1-3.dsc
 f7abf1b43e9a226b3905053188901b1996ee1b4e6bed41a52bcf60f5eec1e96f 96983 
gvfs_1.4.1-3.diff.gz
 a9b76c836075703b668167f4994bc48de7072a071e96fcbbbbc85cfd13e9ca93 1166738 
gvfs_1.4.1-3_i386.deb
 855c27ce74a39c1b336561aac78e30492d7f206af59170810aa28811f85bda24 61230 
gvfs-fuse_1.4.1-3_i386.deb
 6afb1599e9a00e77d5c7d3c09e7056550756dd73a183c061c64021df401436cc 706822 
gvfs-backends_1.4.1-3_i386.deb
 46a458c98adef0fdc4927b79c49756c3f6478437260110ede17ce057ba0e723a 88902 
gvfs-bin_1.4.1-3_i386.deb
 1c27046cc41da29bcb829cc57b070e9ca8cb1695859680d322a006ee67718f65 3714608 
gvfs-dbg_1.4.1-3_i386.deb
Files: 
 ccf731924998933cc558d3f59e3530f4 1818 libs optional gvfs_1.4.1-3.dsc
 130e30bed91844f5fb9d715b54a2dc95 96983 libs optional gvfs_1.4.1-3.diff.gz
 0143b17ec038444a73d21d0d230f4aba 1166738 libs optional gvfs_1.4.1-3_i386.deb
 7d0218ca00eb8fa15a6cf73a350b7f61 61230 libs optional gvfs-fuse_1.4.1-3_i386.deb
 3a004b6eee1284657e37c0d26807029d 706822 libs optional 
gvfs-backends_1.4.1-3_i386.deb
 72f7857af896ec2d9531f04f1f905262 88902 libs optional gvfs-bin_1.4.1-3_i386.deb
 0c51bbfb8d08a54f52256aca6aa45d0c 3714608 debug extra gvfs-dbg_1.4.1-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkr55k4ACgkQhTV17EoIsv6brQCff0Xf8tJa3QTJ27XpxXN9/3HG
dJIAmwUe2QozyqLN0CzlDW3IFTjI8xsC
=fQuf
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to