Your message dated Tue, 01 Dec 2009 23:32:07 +0000
with message-id <[email protected]>
and subject line Bug#559052: fixed in lbzip2 0.19-1
has caused the Debian Bug report #559052,
regarding lbzip2: FTBFS on GNU/kFreeBSD
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
559052: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559052
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: lbzip2
Version: 0.18-2
Severity: important
Tags: patch
User: [email protected]
Usertags: kfreebsd

Hi,

your package FTBFS on GNU/kFreeBSD:
| gcc $(/bin/sh lfs.sh CFLAGS) -D _XOPEN_SOURCE=500 -pipe -ansi -pedantic -g3 
-Wall -O2 -c main.c
| main.c:115: error: 'ENODATA' undeclared here (not in a function)
| main.c:125: error: 'ENOSR' undeclared here (not in a function)
| main.c:126: error: 'ENOSTR' undeclared here (not in a function)
| main.c:147: error: 'ETIME' undeclared here (not in a function)
| make[1]: *** [main.o] Error 1

One could think of declaring the constant → string for each of them
conditionally, as already done for ECANCELED, but really, upstream
shouldn't be inventing the wheel again. There's strerror() for that
already. To keep the diff minimal, I used it in err2str()'s
implementation, and #if 0'd the big array out.

Thanks for considering.

Mraw,
KiBi.
--- a/main.c
+++ b/main.c
@@ -58,6 +58,7 @@ bailout(void)
 const char *pname;
 
 
+#if 0
 struct errstr
 {
   int err;
@@ -150,20 +151,13 @@ static const struct errstr errstr[] = {
     { EWOULDBLOCK,     "Operation would block" },
     { EXDEV,           "Cross-device link" }
 };
+#endif
 
 
 const char *
 err2str(int err)
 {
-  size_t idx;
-
-  for (idx = 0u; idx < sizeof errstr / sizeof errstr[0]; ++idx) {
-    if (errstr[idx].err == err) {
-      return errstr[idx].str;
-    }
-  }
-
-  return "Unknown error";
+  return strerror(err);
 }
 
 

--- End Message ---
--- Begin Message ---
Source: lbzip2
Source-Version: 0.19-1

We believe that the bug you reported is fixed in the latest version of
lbzip2, which is due to be installed in the Debian FTP archive:

lbzip2_0.19-1.debian.tar.bz2
  to main/l/lbzip2/lbzip2_0.19-1.debian.tar.bz2
lbzip2_0.19-1.dsc
  to main/l/lbzip2/lbzip2_0.19-1.dsc
lbzip2_0.19-1_amd64.deb
  to main/l/lbzip2/lbzip2_0.19-1_amd64.deb
lbzip2_0.19.orig.tar.bz2
  to main/l/lbzip2/lbzip2_0.19.orig.tar.bz2



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Laszlo Ersek <[email protected]> (supplier of updated lbzip2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 01 Dec 2009 23:25:12 +0100
Source: lbzip2
Binary: lbzip2
Architecture: source amd64
Version: 0.19-1
Distribution: unstable
Urgency: low
Maintainer: Laszlo Ersek <[email protected]>
Changed-By: Laszlo Ersek <[email protected]>
Description: 
 lbzip2     - fast, multi-threaded bzip2 utility
Closes: 559052
Changes: 
 lbzip2 (0.19-1) unstable; urgency=low
 .
   * New upstream release checks for most errno macros before relying on them
     (Closes: #559052).
Checksums-Sha1: 
 2f24326bad293baef79898f3608d6c43e7da99b6 1007 lbzip2_0.19-1.dsc
 b85b3711e435a1268d602b808d1dfef37dcff266 64178 lbzip2_0.19.orig.tar.bz2
 53805e2b7d4248990ab202ba1eabbb5b97726e53 5837 lbzip2_0.19-1.debian.tar.bz2
 27e2c7de97d9557c3d96fbba9bd1904e8c2317bf 54436 lbzip2_0.19-1_amd64.deb
Checksums-Sha256: 
 f79d9ab158411684048c984ab033b57ecddfec5844415e4301c0fa533d98ab65 1007 
lbzip2_0.19-1.dsc
 a6a6e00dbaab36d7926d66dd78314586e6d5fcaa5bba79568978df5b097a24b5 64178 
lbzip2_0.19.orig.tar.bz2
 1b1750d20c9019729a783c3a3f801fc32e78c1726115603ca6e4e76205c196ec 5837 
lbzip2_0.19-1.debian.tar.bz2
 6edc7143c95eb931a83893ea6dc262f3320b9be3124004d3ef78d162acd48cd5 54436 
lbzip2_0.19-1_amd64.deb
Files: 
 89486ea30fa8cdbf72cba9c375fb90c0 1007 utils extra lbzip2_0.19-1.dsc
 d73f179d92d93c79ac46081bb2870229 64178 utils extra lbzip2_0.19.orig.tar.bz2
 c531031a6cc39c80068755eb95beb16b 5837 utils extra lbzip2_0.19-1.debian.tar.bz2
 bf4f43949dc07225235b0bbc34213a6a 54436 utils extra lbzip2_0.19-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAksVpiUACgkQgY5NIXPNpFUd2QCgwpjz7wQA9+Kxpny4TTGpYG3V
1ZYAoIdrsFCqGO6ElD9vmhuxcpXoo3ki
=Js9i
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to