Your message dated Fri, 11 Dec 2009 15:59:17 +0000
with message-id <[email protected]>
and subject line Bug#534840: fixed in quilt 0.48-3
has caused the Debian Bug report #534840,
regarding quilt: backup-files calls chmod 000...why?
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
534840: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=534840
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: quilt
Version: 0.46-7
Severity: normal
/usr/share/quilt/scripts/backup-files, in the function process_file(),
calls 'chmod 000 "$backup"' when adding a new file. This seems like a
truly strange thing to do. Quilt already detects when the original
file is empty and uses /dev/null as the old file in the diff. Why
does it have to do a chmod 000 too? This causes things that copy
source directories to fail because of the unreadable file. For
example, the ICU package copies the extracted, patched source
directory so that it can build multiple ways. The only reason I can
think of for the chmod 000 was as a defensive coding technique to make
sure the empty file was never read. Even looking at
/usr/share/quilt/scripts/patchfns, I see no evidence that anything
cares whether the file is readable or not. In fact, the patch file
generated is the same whether the file is initially empty or initially
non-existent. Observe:
mkdir z
touch b
quilt new p1
quilt add a
quilt add b
echo test > a
echo test >> b
quilt refresh
Now, ls -l .pc/p1 shows
total 0
-rw-r--r-- 1 ejb ejb 0 Jun 27 09:25 .timestamp
---------- 1 ejb ejb 0 Jun 27 09:25 a
-rw-r--r-- 1 ejb ejb 0 Jun 27 09:25 b
and patches/p1 contains
Index: z/a
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ z/a 2009-06-27 09:25:25.093286073 -0400
@@ -0,0 +1 @@
+test
Index: z/b
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ z/b 2009-06-27 09:25:25.093286073 -0400
@@ -0,0 +1 @@
+test
So the chmod 000 seems entirely superfluous, and I believe it should
be removed.
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (500, 'testing'), (200, 'experimental'), (200, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.26-2-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages quilt depends on:
ii bzip2 1.0.5-2 high-quality block-sorting file co
ii diffstat 1.47-1 produces graph of changes introduc
ii gettext 0.17-6 GNU Internationalization utilities
ii patch 2.5.9-5 Apply a diff file to an original
quilt recommends no packages.
Versions of packages quilt suggests:
ii graphviz 2.20.2-3+b2 rich set of graph drawing tools
ii procmail 3.22-16 Versatile e-mail processor
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: quilt
Source-Version: 0.48-3
We believe that the bug you reported is fixed in the latest version of
quilt, which is due to be installed in the Debian FTP archive:
quilt_0.48-3.debian.tar.gz
to main/q/quilt/quilt_0.48-3.debian.tar.gz
quilt_0.48-3.dsc
to main/q/quilt/quilt_0.48-3.dsc
quilt_0.48-3_all.deb
to main/q/quilt/quilt_0.48-3_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Raphaël Hertzog <[email protected]> (supplier of updated quilt package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 11 Dec 2009 15:00:38 +0100
Source: quilt
Binary: quilt
Architecture: source all
Version: 0.48-3
Distribution: unstable
Urgency: low
Maintainer: Martin Quinson <[email protected]>
Changed-By: Raphaël Hertzog <[email protected]>
Description:
quilt - Tool to work with series of patches
Closes: 517664 532127 534840 557386 560621
Changes:
quilt (0.48-3) unstable; urgency=low
.
* Stop creating files with 000 mode in the .pc directory. Upstream
has changed this in their git repository, so we can update our shell
variant of backup-files accordingly. Closes: #557386, #534840
* Document the minimal versions for "dh --with quilt" in README.Debian.
Closes: #532127
* Support QUILT_PATCH_DIR input environment variable in CDBS's
patchsys-quilt.mk. Closes: #517664
* Update test suite to support newer versions of patch. Cherry-pick patch
from upstream in debian/patches/test-suite-update-for-patch-2.6.
Closes: #560621
* Update patch test_broken_patches providing test/file-not-found to work
with patch 2.6 but disable it since otherwise the package could not be
compiled with older patch releases.
Checksums-Sha1:
c582b92f1173e15a29eb6a388897948c789822f9 1605 quilt_0.48-3.dsc
c0f72f1ba731be2ef8a1fda1a840e7c0c6dfeedb 39335 quilt_0.48-3.debian.tar.gz
b6bce369fb4267322e6524ec67e16519bfe686f1 352888 quilt_0.48-3_all.deb
Checksums-Sha256:
e046841c86dbb1e0a16c86bace847f43d5090de5e40a774bf62f50f37569c6cc 1605
quilt_0.48-3.dsc
8ccacaba5d3dd9e3f42ec9b78ee3461e965d946c0320a7e68008e89fdef9d029 39335
quilt_0.48-3.debian.tar.gz
e7b36af70475a562f0d259cd460a6aae6115f2a847ff8a9873a3e47b4cad0d2f 352888
quilt_0.48-3_all.deb
Files:
7bad893ec5460e2f4913e0abd3a16154 1605 vcs optional quilt_0.48-3.dsc
91ff79fe7c27a1a511684b9d72f8583d 39335 vcs optional quilt_0.48-3.debian.tar.gz
f0987ef67c5f5ee8287832a6a6ed36db 352888 vcs optional quilt_0.48-3_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Signed by Raphael Hertzog
iQEcBAEBCAAGBQJLIlEKAAoJEAOIHavrwpq5KiIH/2PVS3egiw3oFBVBPwbwGH6y
aAY6eMlaMHngZpBpxtBTWV9WpYGvwxY1tSIPUjh3q79VPtbiG1y0q8PVGUxCmMNt
j4VLhFwQqzjQ9mKpbNfQ3AoGV4dwiNWJnmdpAdhoO4T8w4LSwU5S7I9UKuSq57yX
cyhUIcsFB2GgDF2b1pGLD2howT/UZCRbOPq8a3YpU6KFQiywPOC2EAe1h66xsveN
tlEDAsuk+JZiEAMX9di4gZVbjiA/ZFfQCrwmvVkJ6+8uehqRM8xxbJikYC+wO2Cv
4SAOb+HXA712D2LE4P5NHyAmZ5c+tXgLbpRWBQtX83AWVVLDeC9jvBHKCNKfGTU=
=C2HU
-----END PGP SIGNATURE-----
--- End Message ---
