Your message dated Sat, 19 Dec 2009 22:17:07 +0000
with message-id <[email protected]>
and subject line Bug#561533: fixed in debmirror 1:2.4
has caused the Debian Bug report #561533,
regarding Fails mirroring archives without Release.gpg files
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
561533: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561533
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: debmirror
Version: 1:2.3.1
Severity: minor
Tags: patch
Hi there
I just tried mirroring the dists at
http://build.chromium.org/buildbot/packages/dists/chromeos/ (I think
these are created with reprepro), but failed due to missing Release.gpg
files.
There were two independent issues, one was in get_release() which was
returning 0 because the remote_get() would fail for Release.gpg, I
changed:
return 0 unless remote_get("dists/$dist/Release", "$tempdir/.tmp");
my $t = $num_errors;
return 0 unless remote_get("dists/$dist/Release.gpg", "$tempdir/.tmp");
# Check for gpg
if (!$ignore_release_gpg) {
if (system("gpgv --version >/dev/null 2>/dev/null")) {
say("gpgv failed: --ignore-release-gpg or gpgv binary missing?");
to:
return 0 unless remote_get("dists/$dist/Release", "$tempdir/.tmp");
my $t = $num_errors;
if (!$ignore_release_gpg) {
return 0 unless remote_get("dists/$dist/Release.gpg", "$tempdir/.tmp");
# Check for gpg
if (system("gpgv --version >/dev/null 2>/dev/null")) {
say("gpgv failed: --ignore-release-gpg or gpgv binary missing?");
but you could as well return 1 if ignore_release_gpg.
The other spot was when moving the files in place, changed this:
rename("$tdir/Release", "$tempdir/dists/$codename$dist_sdir/Release")
or die "Error while moving $tdir/Release: $!\n";
rename("$tdir/Release.gpg",
"$tempdir/dists/$codename$dist_sdir/Release.gpg")
or die "Error while moving $tdir/Release.gpg: $!\n";
into:
rename("$tdir/Release", "$tempdir/dists/$codename$dist_sdir/Release")
or die "Error while moving $tdir/Release: $!\n";
rename("$tdir/Release.gpg",
"$tempdir/dists/$codename$dist_sdir/Release.gpg")
or $ignore_release_gpg or die "Error while moving $tdir/Release.gpg:
$!\n";
and that was enough.
Attaching debdiff.
Thanks!
--
Loïc Minier
diff -Nru debmirror-2.3.1/debian/changelog debmirror-2.3.2/debian/changelog
--- debmirror-2.3.1/debian/changelog 2009-10-08 19:41:03.000000000 +0200
+++ debmirror-2.3.2/debian/changelog 2009-12-17 23:29:35.000000000 +0100
@@ -1,3 +1,10 @@
+debmirror (1:2.3.2) UNRELEASED; urgency=low
+
+ * Fix handling of repos without Release.gpg files --ignore-release-gpg is
+ passed.
+
+ -- Loïc Minier <[email protected]> Thu, 17 Dec 2009 23:29:04 +0100
+
debmirror (1:2.3.1) unstable; urgency=low
* Update example configuration (closes: #549955):
diff -Nru debmirror-2.3.1/debmirror debmirror-2.3.2/debmirror
--- debmirror-2.3.1/debmirror 2009-10-08 19:30:56.000000000 +0200
+++ debmirror-2.3.2/debmirror 2009-12-17 23:28:57.000000000 +0100
@@ -818,7 +818,7 @@
rename("$tdir/Release", "$tempdir/dists/$codename$dist_sdir/Release")
or die "Error while moving $tdir/Release: $!\n";
rename("$tdir/Release.gpg", "$tempdir/dists/$codename$dist_sdir/Release.gpg")
- or die "Error while moving $tdir/Release.gpg: $!\n";
+ or $ignore_release_gpg or die "Error while moving $tdir/Release.gpg: $!\n";
$files{"dists/$codename$dist_sdir/Release"}=1;
$files{$tempdir."/"."dists/$codename$dist_sdir/Release"}=1;
$files{"dists/$codename$dist_sdir/Release.gpg"}=1;
@@ -1756,9 +1756,9 @@
make_dir ("$tdir");
return 0 unless remote_get("dists/$dist/Release", "$tempdir/.tmp");
my $t = $num_errors;
- return 0 unless remote_get("dists/$dist/Release.gpg", "$tempdir/.tmp");
- # Check for gpg
if (!$ignore_release_gpg) {
+ return 0 unless remote_get("dists/$dist/Release.gpg", "$tempdir/.tmp");
+ # Check for gpg
if (system("gpgv --version >/dev/null 2>/dev/null")) {
say("gpgv failed: --ignore-release-gpg or gpgv binary missing?");
push (@errlog,"gpgv failed: --ignore-release-gpg or gpgv binary missing?\n");
--- End Message ---
--- Begin Message ---
Source: debmirror
Source-Version: 1:2.4
We believe that the bug you reported is fixed in the latest version of
debmirror, which is due to be installed in the Debian FTP archive:
debmirror_2.4.dsc
to main/d/debmirror/debmirror_2.4.dsc
debmirror_2.4.tar.gz
to main/d/debmirror/debmirror_2.4.tar.gz
debmirror_2.4_all.deb
to main/d/debmirror/debmirror_2.4_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Frans Pop <[email protected]> (supplier of updated debmirror package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 19 Dec 2009 22:21:38 +0100
Source: debmirror
Binary: debmirror
Architecture: source all
Version: 1:2.4
Distribution: unstable
Urgency: low
Maintainer: Frans Pop <[email protected]>
Changed-By: Frans Pop <[email protected]>
Description:
debmirror - Debian partial mirror script, with ftp and package pool support
Closes: 544141 551878 560326 561533
Changes:
debmirror (1:2.4) unstable; urgency=low
.
* The main Debian archive has started to use rsyncable gzip files.
Use the --rsyncable flag when compressing Packages/Sources files using
gzip after applying pdiffs to ensure the md5sum of the file matches the
one in the Release file again. Closes: #560326.
This change may cause unnecessary download of the gzipped Packages/Sources
files for other archives that provide pdiffs but don't have rsyncable
gzipped files; this can be fixed using the new option --gzip-options.
* Fix mirroring of archives without a Release.gpg file. Closes: #561533.
Thanks to Loïc Minier for tracing the issue.
* Allow to specify the local mirror directory in config files.
Closes: #544141.
* Add versioned dependency on perl (>= 5.10). Closes: #551878.
* Improve dependencies on gpgv/gnupg.
Checksums-Sha1:
4b18007e74ab05c8f0798e6158a5cc8bacfed61a 798 debmirror_2.4.dsc
5b9e54d2c06fbfb9ce760c90b1abb1c764f3cc7f 37690 debmirror_2.4.tar.gz
6d4fb85e250e424e6516dd984269de63bb0011b3 47310 debmirror_2.4_all.deb
Checksums-Sha256:
85218b550a1c0ee37c176c51e2c434fac7bf47c1b416f96cac72dd3e087774b5 798
debmirror_2.4.dsc
8faf6810b985fb9d562c4562fea90dfbdeaaad6c5ed261541f5dfdb0ebdc8d3f 37690
debmirror_2.4.tar.gz
1426a5487325b26a2cd64886c8b60cc13850584b0062a3cc49ffdc26fe7dd6c5 47310
debmirror_2.4_all.deb
Files:
b05bbd478f489b17ac2fbf81a81be26f 798 net extra debmirror_2.4.dsc
1854adcaeb0abaf775317b8a78d0fabf 37690 net extra debmirror_2.4.tar.gz
c6be08d05486e1740f1ecaea317d3c4a 47310 net extra debmirror_2.4_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkstRX8ACgkQgm/Kwh6ICoRJJACggH/23ryPcXn64DWPs9UbUh2E
mMEAn3p6kfh6VcL3bKkrUArLNzgOTZeI
=K1qc
-----END PGP SIGNATURE-----
--- End Message ---
