Your message dated Sun, 24 Jan 2010 13:26:13 +0100
with message-id <[email protected]>
and subject line Re: Bug#451259: nvram-wakeup: vdr shutdown script calculates 
wrong regular wake-up time
has caused the Debian Bug report #451259,
regarding nvram-wakeup: REGULAR_DAYS option does not work correctly
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
451259: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=451259
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: nvram-wakeup
Version: 0.97-12
Severity: normal


The calculation of the next regular wakeup event is wrong if the
execution time of the shutdown-hook S90.nvram-wakeup is the same day
but before the REGULAR_TIME. In this case there should not be a whole days time 
added to the event. The attached patch fixes this issue.

*** /root/S90.nvram-wakeup.orig Tue Sep 23 09:21:21 2008
--- /usr/share/vdr/shutdown-hooks/S90.nvram-wakeup      Wed Sep 17 21:55:26 2008
***************
*** 44,49 ****
--- 44,52 ----
  TIMER=$1
  
  if [ $REGULAR_DAYS -gt 0 ]; then
+     if [ `date -d "$REGULAR_TIME" +%s` -gt `date +%s` ]; then
+         REGULAR_DAYS=$(($REGULAR_DAYS - 1))
+     fi
      REGULAR_TIMER=$((`date -d "$REGULAR_TIME" +%s` + $REGULAR_DAYS * 24 * 60 *
 60))
  
      # when no vdr timer is set or vdr timer starts later than regular timer:


-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (998, 'stable'), (99, 'testing'), (50, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-epia-1
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages nvram-wakeup depends on:
ii  debconf [debconf-2.0]  1.5.11etch2       Debian configuration management sy
ii  libc6                  2.3.6.ds1-13etch7 GNU C Library: Shared libraries
ii  makedev                2.3.1-83          creates device files in /dev

nvram-wakeup recommends no packages.

-- debconf information:
  nvram-wakeup/install_instruction:
* nvram-wakeup/install_module: true



--- End Message ---
--- Begin Message ---
Thanks for reporting this and sorry, for not answering this for such a
long time!

Stefan Goetz wrote:

> recordings in VDR. The
> bug is triggered e.g. with REGULAR_TIME=08:00 and REGULAR_DAYS=1 when
> executed between 00:00 and 07:59, yielding a wake-up time at 08:00 the
> next day.

This is the expected behaviour. The intention of REGULAR_TIME is to wake
up VDR at least once a day, if no timer triggers a wakeup. This is to
make sure, the EPG data gets updated and EpgSearch can create new timers.

In your example, if you shut down VDR at 00:01, there's no need to wake it
up at 8:00 again, because the EPG data already is up-to-date. And if no
other timer is set, it will wake up the next day at 8:00.

I'm not going to make any major changes to this anymore. It would be
better to invest some time in a completely independent wake up tool, which
 uses nvram-wakeup or ACPI and can be used by other applications as well.

Tobias

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---

Reply via email to