Your message dated Tue, 26 Jan 2010 12:07:26 +0000
with message-id <[email protected]>
and subject line Bug#546279: fixed in controlaula 1.4.0-1
has caused the Debian Bug report #546279,
regarding controlaula: Incorrect runlevels and dependencies in init.d script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
546279: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=546279
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package:  controlaula ltsp-controlaula
Version:  1.3-1
Severity: important
Tags:     patch
User:     [email protected]
Usertags: incorrect-runlevels incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The init.d scripts have a hard dependency
on dbus, which is supposed to be optional and is missing on kfreebsd.
The scripts used to start after the syslog collector, but do not
depend on $syslog.  The avahi-daemon provide do not exist (the script
provide avahi instead).  Prehaps it should be dropped as a optional
dependency?  Also, the ltsp-sirvecole script do not have the runlevel
1 listed.  This will make it fail to restart when switching from
runlevel 1 back to 2-5, and probably should be fixed.  I notice the
update-rc.d calls look like this:

  update-rc.d sirvecole start 98 2 3 5 . stop 20 0 1 6 .
  update-rc.d ltsp-sirvecole start 24 2 3 5 .

If ltsp-sirvecole really should not stop at all, no runlevel should be
listed in default-stop at all, but I believe that is the wrong
approach.  I would suggest to change the update-rc.d call like this
instead:

  update-rc.d ltsp-sirvecole start 24 2 3 5 . stop 1 .

If the script do not need special handling to stop, the stop symlinks
for runlevels 0 and 6 can be dropped for the sirvecole script.

Should the ltsp-sirvecole script depend on some LTSP specific scripts?
Why did the sirvecole start so late?  Should it depend on more init.d
scripts to ensure it is started behind something else?

This untested patch should fix the issues I know about.  The code in
the postinst is needed to update the runlevel settings for existing
installations.

diff -uNr controlaula-1.3.1/debian/controlaula.postinst 
controlaula-1.3.1-pere/debian/controlaula.postinst
--- controlaula-1.3.1/debian/controlaula.postinst       1970-01-01 
01:00:00.000000000 +0100
+++ controlaula-1.3.1-pere/debian/controlaula.postinst  2009-09-12 
09:01:16.000000000 +0200
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+case "$1" in
+  configure)
+    if dpkg --compare-versions "$2" le "1.3.1-1" ; then
+        update-rc.d -f sirvecole remove >/dev/null 2>&1 || :
+    fi
+    ;;
+esac
+
+#DEBHELPER#
diff -uNr controlaula-1.3.1/debian/controlaula.sirvecole 
controlaula-1.3.1-pere/debian/controlaula.sirvecole
--- controlaula-1.3.1/debian/controlaula.sirvecole      2009-09-12 
08:21:23.000000000 +0200
+++ controlaula-1.3.1-pere/debian/controlaula.sirvecole 2009-09-12 
08:40:31.000000000 +0200
@@ -1,11 +1,12 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          sirvecole
-# Should-Start:      avahi-daemon
-# Required-Start:    $remote_fs $network dbus avahi
-# Required-Stop:     $remote_fs $network dbus avahi
+# Required-Start:    $remote_fs $network $syslog avahi
+# Required-Stop:     $remote_fs $network $syslog avahi
+# Should-Start:      avahi-daemon dbus
+# Should-Stop:       avahi-daemon dbus
 # Default-Start:     2 3 4 5
-# Default-Stop:      0 1 6
+# Default-Stop:      1
 # Short-Description: Controlaula root daemon
 # Description:       Debian init script for Controlaula root monitoring daemon
 ### END INIT INFO
diff -uNr controlaula-1.3.1/debian/ltsp-controlaula.ltsp-sirvecole 
controlaula-1.3.1-pere/debian/ltsp-controlaula.ltsp-sirvecole
--- controlaula-1.3.1/debian/ltsp-controlaula.ltsp-sirvecole    2009-09-12 
08:21:23.000000000 +0200
+++ controlaula-1.3.1-pere/debian/ltsp-controlaula.ltsp-sirvecole       
2009-09-12 08:40:38.000000000 +0200
@@ -1,11 +1,12 @@
 #!/bin/sh
 ### BEGIN INIT INFO
 # Provides:          ltsp-sirvecole
-# Should-Start:      avahi-daemon
-# Required-Start:    $local_fs $remote_fs dbus avahi
-# Required-Stop:     $local_fs $remote_fs dbus avahi
+# Required-Start:    $remote_fs $network $syslog avahi
+# Required-Stop:     $remote_fs $network $syslog avahi
+# Should-Start:      avahi-daemon dbus
+# Should-Stop:       avahi-daemon dbus
 # Default-Start:     2 3 4 5
-# Default-Stop:      0  6
+# Default-Stop:      1
 # Short-Description: Controlaula root daemon in a ltsp environment
 # Description:       Debian init script for Controlaula root monitoring daemon 
when using ltsp
 ### END INIT INFO
diff -uNr controlaula-1.3.1/debian/ltsp-controlaula.postinst 
controlaula-1.3.1-pere/debian/ltsp-controlaula.postinst
--- controlaula-1.3.1/debian/ltsp-controlaula.postinst  1970-01-01 
01:00:00.000000000 +0100
+++ controlaula-1.3.1-pere/debian/ltsp-controlaula.postinst     2009-09-12 
09:02:00.000000000 +0200
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+case "$1" in
+  configure)
+    if dpkg --compare-versions "$2" lt "1.3.1-1" ; then
+        update-rc.d -f ltsp-sirvecole remove >/dev/null 2>&1 || :
+    fi
+    ;;
+esac
+
+#DEBHELPER#
diff -uNr controlaula-1.3.1/debian/rules controlaula-1.3.1-pere/debian/rules
--- controlaula-1.3.1/debian/rules      2009-09-12 09:04:03.000000000 +0200
+++ controlaula-1.3.1-pere/debian/rules 2009-09-12 09:05:15.000000000 +0200
@@ -59,7 +59,7 @@
        dh_installchangelogs -i
        dh_installdocs -i
        dh_install -i
-       dh_installinit -i --init-script ltsp-sirvecole -r --no-start -u"start 
24 2 3 5 ."
+       dh_installinit -i --init-script ltsp-sirvecole -r --no-start -u"start 
24 2 3 5 . stop 20 1 ."
        dh_installman debian/ltsp-sirvecole.gambas.8 -pltsp-controlaula
        dh_link -i
        dh_compress -i
@@ -75,7 +75,7 @@
        dh_installdocs -a
        dh_installchangelogs -a
        dh_install -a
-       dh_installinit -a --init-script sirvecole -r --no-start -u"start 98 2 3 
5 . stop 20 0 1 6 ."
+       dh_installinit -a --init-script sirvecole -r --no-start -u"start 98 2 3 
5 . stop 20 1 ."
        dh_installman debian/sirvecole.gambas.8  debian/pwd_controlaula.8  
-pcontrolaula
        dh_installman debian/controlaula.gambas.1  debian/monitor.gambas.1 
debian/monitorProfe.gambas.1 -pcontrolaula
        dh_strip -a
diff -uNr controlaula-1.3.1/gambas-sources/debian/controlaula.sirvecole 
controlaula-1.3.1-pere/gambas-sources/debian/controlaula.sirvecole
--- controlaula-1.3.1/gambas-sources/debian/controlaula.sirvecole       
2008-11-24 12:02:06.000000000 +0100
+++ controlaula-1.3.1-pere/gambas-sources/debian/controlaula.sirvecole  
2009-09-12 08:40:44.000000000 +0200
@@ -1,12 +1,12 @@
 #!/bin/sh
 ### BEGIN INIT INFO
 # Provides:          sirvecole
-# Should-Start:      avahi-daemon
-# Should-Stop:       avahi-daemon
-# Required-Start:    $remote_fs $network dbus avahi
-# Required-Stop:     $remote_fs $network dbus avahi
+# Required-Start:    $remote_fs $network $syslog avahi
+# Required-Stop:     $remote_fs $network $syslog avahi
+# Should-Start:      avahi-daemon dbus
+# Should-Stop:       avahi-daemon dbus
 # Default-Start:     2 3 4 5
-# Default-Stop:      0 1 6
+# Default-Stop:      1
 # Short-Description: Controlaula root daemon
 # Description:       Debian init script for Controlaula root monitoring daemon
 ### END INIT INFO
diff -uNr 
controlaula-1.3.1/gambas-sources/debian/ltsp-controlaula.ltsp-sirvecole 
controlaula-1.3.1-pere/gambas-sources/debian/ltsp-controlaula.ltsp-sirvecole
--- controlaula-1.3.1/gambas-sources/debian/ltsp-controlaula.ltsp-sirvecole     
2008-11-24 12:02:06.000000000 +0100
+++ 
controlaula-1.3.1-pere/gambas-sources/debian/ltsp-controlaula.ltsp-sirvecole    
    2009-09-12 08:40:55.000000000 +0200
@@ -1,11 +1,12 @@
 #!/bin/sh
 ### BEGIN INIT INFO
 # Provides:          ltsp-sirvecole
-# Should-Start:      avahi-daemon
-# Required-Start:    $local_fs $remote_fs dbus avahi
-# Required-Stop:     $local_fs $remote_fs dbus avahi
+# Required-Start:    $remote_fs $network $syslog avahi
+# Required-Stop:     $remote_fs $network $syslog avahi
+# Should-Start:      avahi-daemon dbus
+# Should-Stop:       avahi-daemon dbus
 # Default-Start:     2 3 4 5
-# Default-Stop:      0  6
+# Default-Stop:      1
 # Short-Description: Controlaula root daemon in a ltsp environment
 # Description:       Debian init script for Controlaula root monitoring daemon 
when using ltsp
 ### END INIT INFO

Happy hacking,
-- 
Petter Reinholdtsen



--- End Message ---
--- Begin Message ---
Source: controlaula
Source-Version: 1.4.0-1

We believe that the bug you reported is fixed in the latest version of
controlaula, which is due to be installed in the Debian FTP archive:

controlaula_1.4.0-1.diff.gz
  to main/c/controlaula/controlaula_1.4.0-1.diff.gz
controlaula_1.4.0-1.dsc
  to main/c/controlaula/controlaula_1.4.0-1.dsc
controlaula_1.4.0-1_i386.deb
  to main/c/controlaula/controlaula_1.4.0-1_i386.deb
controlaula_1.4.0.orig.tar.gz
  to main/c/controlaula/controlaula_1.4.0.orig.tar.gz
ltsp-controlaula_1.4.0-1_all.deb
  to main/c/controlaula/ltsp-controlaula_1.4.0-1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
José L. Redrejo Rodríguez <[email protected]> (supplier of updated 
controlaula package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 26 Jan 2010 09:16:38 +0100
Source: controlaula
Binary: controlaula ltsp-controlaula
Architecture: source all i386
Version: 1.4.0-1
Distribution: unstable
Urgency: low
Maintainer: José L. Redrejo Rodríguez <[email protected]>
Changed-By: José L. Redrejo Rodríguez <[email protected]>
Description: 
 controlaula - Classroom management tool
 ltsp-controlaula - Classroom management tool with ltsp clients
Closes: 546279
Changes: 
 controlaula (1.4.0-1) unstable; urgency=low
 .
   * New upstream version
   * Depends on gambas2 > 2.14 to avoid some gtk bugs
   * New Dutch (nl) translation, thanks to Rob van den Berg.
   * Fixed runlevels and dependencies in init.d script, thanks to Petter
     Reinholdtsen <[email protected]> for his patch (Closes: #546279)
Checksums-Sha1: 
 b29693ab331f8c54f045552015e80b787a724cde 1182 controlaula_1.4.0-1.dsc
 a15ba11fa4299decea306b69b676d1bc7ce068e7 1081545 controlaula_1.4.0.orig.tar.gz
 9c7bb98f8c0eb9cfbdd824c06285463c4fbcb22f 9939 controlaula_1.4.0-1.diff.gz
 6c0949208df09fb78ddaaa34a8f63f5eb41494b2 29396 ltsp-controlaula_1.4.0-1_all.deb
 d6757a063f878b3ef2db5b3d7bc3c97dbbef3af2 902766 controlaula_1.4.0-1_i386.deb
Checksums-Sha256: 
 32c3e5a8d6db424838ee8369f05df784c224918f2fc0ca3386c1fada3d4b88d5 1182 
controlaula_1.4.0-1.dsc
 ad5dcadf42ce69e7ec310caceff0d4f436e4ff831d45a5727d4297ceaffcc7b4 1081545 
controlaula_1.4.0.orig.tar.gz
 6063a5cbec1c6d971e3f59bfc44f501243766cacf0d292708082b7eb2de40510 9939 
controlaula_1.4.0-1.diff.gz
 497ad6aca1f2a6710c525d86aa03dacb51b3f0c108860cb66f05eb872279acdc 29396 
ltsp-controlaula_1.4.0-1_all.deb
 5a5362b951fbe2bea548cb585293004c9e4d56a087f23224f7907ecca12304a6 902766 
controlaula_1.4.0-1_i386.deb
Files: 
 df9b5707bdc9277c11164097024f70fa 1182 admin optional controlaula_1.4.0-1.dsc
 ed6828f06f4bf35b5772f191d98a868b 1081545 admin optional 
controlaula_1.4.0.orig.tar.gz
 acdba48bc484a616736ba2666978e5be 9939 admin optional 
controlaula_1.4.0-1.diff.gz
 283612c03f21730b205ac94ca4b08dbb 29396 admin optional 
ltsp-controlaula_1.4.0-1_all.deb
 015c8e8914175b85c63115653fe7289f 902766 admin optional 
controlaula_1.4.0-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAktetPkACgkQmqVR2WapDeIcSwCePYGdlhwGSkALILKUisMDzSbe
JeMAoOby1j90WSwivYEMn/+J7FcA1FTM
=NJ8w
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to