Your message dated Wed, 27 Jan 2010 12:49:58 +0000
with message-id <[email protected]>
and subject line Bug#567021: fixed in devicekit-power 014-3
has caused the Debian Bug report #567021,
regarding devicekit-power: DkpClient has races in signals when multiple handles
are used
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
567021: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=567021
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devicekit-power
Version: 011-1ubuntu1
Severity: normal
Tags: patch
As mentioned in the title, DkpClient has races in signals when multiple handles
are used. One such example of this would be documented in Launchpad bug
#425411[1], where gnome-power-manager ends up suspending twice because if the
power supply status changes prior to resuming.
The supplied patch which was extracted from upstream Git fixes this issue.
[1] https://bugs.launchpad.net/bugs/425411
-- System Information:
Debian Release: squeeze/sid
APT prefers karmic-updates
APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500,
'karmic-proposed'), (500, 'karmic-backports'), (500, 'karmic')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.33-rc5-hyper2 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_SG.UTF-8, LC_CTYPE=en_SG.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages devicekit-power depends on:
ii libc6 2.10.1-0ubuntu16 GNU C Library: Shared libraries
ii libdbus-1-3 1.2.16-0ubuntu9 simple interprocess messaging syst
ii libdbus-glib-1-2 0.80-4ubuntu1 simple interprocess messaging syst
ii libdevkit-power-gobject 011-1ubuntu2 abstraction for power management -
ii libglib2.0-0 2.22.3-0ubuntu1 The GLib library of C routines
ii libgudev-1.0-0 1:147~-6.1 GObject-based wrapper library for
ii libpolkit-gobject-1-0 0.94-1ubuntu1 PolicyKit Authorization API
ii libusb-0.1-4 2:0.1.12-13 userspace USB programming library
Versions of packages devicekit-power recommends:
ii pm-utils 1.2.5-2ubuntu7 utilities and scripts for power ma
ii policykit-1 0.94-1ubuntu1 framework for managing administrat
devicekit-power suggests no packages.
-- no debconf information
commit b8a200eb481a42adf26d639dbdc2224a6c99f841
Author: Richard Hughes <[email protected]>
Date: Mon Jan 25 14:25:37 2010 +0000
Make DkpClient a singleton to avoid some weird race conditions
diff --git a/devkit-power-gobject/dkp-client.c
b/devkit-power-gobject/dkp-client.c
index feac826..5cef4f9 100644
--- a/devkit-power-gobject/dkp-client.c
+++ b/devkit-power-gobject/dkp-client.c
@@ -74,6 +74,7 @@ enum {
};
static guint signals [DKP_CLIENT_LAST_SIGNAL] = { 0 };
+static gpointer dkp_client_object = NULL;
G_DEFINE_TYPE (DkpClient, dkp_client, G_TYPE_OBJECT)
@@ -734,8 +735,12 @@ dkp_client_finalize (GObject *object)
DkpClient *
dkp_client_new (void)
{
- DkpClient *client;
- client = g_object_new (DKP_TYPE_CLIENT, NULL);
- return DKP_CLIENT (client);
+ if (dkp_client_object != NULL) {
+ g_object_ref (dkp_client_object);
+ } else {
+ dkp_client_object = g_object_new (DKP_TYPE_CLIENT, NULL);
+ g_object_add_weak_pointer (dkp_client_object,
&dkp_client_object);
+ }
+ return DKP_CLIENT (dkp_client_object);
}
--- End Message ---
--- Begin Message ---
Source: devicekit-power
Source-Version: 014-3
We believe that the bug you reported is fixed in the latest version of
devicekit-power, which is due to be installed in the Debian FTP archive:
devicekit-power-doc_014-3_all.deb
to main/d/devicekit-power/devicekit-power-doc_014-3_all.deb
devicekit-power_014-3.diff.gz
to main/d/devicekit-power/devicekit-power_014-3.diff.gz
devicekit-power_014-3.dsc
to main/d/devicekit-power/devicekit-power_014-3.dsc
devicekit-power_014-3_i386.deb
to main/d/devicekit-power/devicekit-power_014-3_i386.deb
libdevkit-power-gobject-dev_014-3_i386.deb
to main/d/devicekit-power/libdevkit-power-gobject-dev_014-3_i386.deb
libdevkit-power-gobject1_014-3_i386.deb
to main/d/devicekit-power/libdevkit-power-gobject1_014-3_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Martin Pitt <[email protected]> (supplier of updated devicekit-power package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 26 Jan 2010 20:26:03 +0100
Source: devicekit-power
Binary: devicekit-power devicekit-power-doc libdevkit-power-gobject1
libdevkit-power-gobject-dev
Architecture: source all i386
Version: 014-3
Distribution: unstable
Urgency: low
Maintainer: Utopia Maintenance Team
<[email protected]>
Changed-By: Martin Pitt <[email protected]>
Description:
devicekit-power - abstraction for power management
devicekit-power-doc - abstraction for power management - documentation
libdevkit-power-gobject-dev - abstraction for power management - development
files
libdevkit-power-gobject1 - abstraction for power management - shared library
Closes: 567021
Changes:
devicekit-power (014-3) unstable; urgency=low
.
* Add 02-dkpclient-singleton.patch: Make DkpClient a singleton to avoid some
weird race conditions. Patch taken from upstream git. (Closes: #567021,
LP: #425411)
Checksums-Sha1:
f71504fdf6f7dc6934413f468c9c784e62d6165b 1619 devicekit-power_014-3.dsc
a1341a0989a1b075d59706288c31d871f0c6fd56 4405 devicekit-power_014-3.diff.gz
f5a614052bb09e65482d22b429f51be795f8876c 45434
devicekit-power-doc_014-3_all.deb
606e24fb56b32d9f446a360a6ad92e33ffda2280 81350 devicekit-power_014-3_i386.deb
98772677e7ce1da23620ecafd3d3cfb04d105fba 33204
libdevkit-power-gobject1_014-3_i386.deb
7ef684799f0e7ced93b0e9b2689aaba90c009089 37022
libdevkit-power-gobject-dev_014-3_i386.deb
Checksums-Sha256:
33a8305107046dd4635380830abf0c83ac3d69705b711e1175cd1cbcd21ce25a 1619
devicekit-power_014-3.dsc
5ccdde0b8de7d59cc4c461f4df1ebf9a3539ea87721b0c05d2f6736272c6ae89 4405
devicekit-power_014-3.diff.gz
a8944981461ffa647ef6396cab5c196d12262c43f83dffcef93289020e0964b0 45434
devicekit-power-doc_014-3_all.deb
a650beea35a22153a85386004757f65406030ef4a95e1ed3e8503d75a3541350 81350
devicekit-power_014-3_i386.deb
f1824055d09cc2d0e726ac020aa1ff9219a00ad32a5af0b52cac750f3c8aad1c 33204
libdevkit-power-gobject1_014-3_i386.deb
cd6bccd99d06b149d0816da4c05f22f0086c8bae2b8c434a79c61888a76a5312 37022
libdevkit-power-gobject-dev_014-3_i386.deb
Files:
5bb639a6b9a387f173e05dad1c595b71 1619 admin optional devicekit-power_014-3.dsc
e57acddb5acf1a8c7efa038721440438 4405 admin optional
devicekit-power_014-3.diff.gz
6e6f65349d39d7aabfa2eaee699f9b01 45434 doc optional
devicekit-power-doc_014-3_all.deb
e911670ab80afdadc304c598fb7c9843 81350 admin optional
devicekit-power_014-3_i386.deb
5caae960cea65c4c979f6ca22c9a4af3 33204 libs optional
libdevkit-power-gobject1_014-3_i386.deb
0152f4856e31bb8bb9ee53323b9b69de 37022 libdevel optional
libdevkit-power-gobject-dev_014-3_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAktgL2MACgkQDecnbV4Fd/IbQwCgizhoEyUGXBKg/H4dPueUQr6K
H2sAoIQfCiI18hmTSadvt2Gtvld6/Wus
=dfTi
-----END PGP SIGNATURE-----
--- End Message ---
