Bug#569643: marked as done (pgadmin3 has ugly icon)

Mon, 15 Feb 2010 06:59:45 -0800 

Your message dated Mon, 15 Feb 2010 15:54:48 +0100
with message-id <[email protected]>
and subject line Re: Bug#569643: pgadmin3 has ugly icon
has caused the Debian Bug report #569643,
regarding pgadmin3 has ugly icon
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
569643: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=569643
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message --- 
Package: pgadmin3
Version: 1.10.1-1
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu lucid ubuntu-patch

The xpm icon was pretty ugly. We added a svg icon that looks nice.

*** /tmp/tmp0_WSZX
In Ubuntu, we've applied the attached patch to achieve the following:

  * Changed icon for a better one (LP: #347256):
    - debian/pgadmin3.svg: added.
    - debian/pgadmin3.install: changed to install pgadmin3.svg instead of
      pgadmin3.xpm.
    - debian/pgadmin3-data.copyright: appended the copyright info of the icon.

We thought you might be interested in doing the same. 


-- System Information:
Debian Release: squeeze/sid
  APT prefers lucid-updates
  APT policy: (500, 'lucid-updates'), (500, 'lucid-security'), (500, 'lucid')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-10-generic (SMP w/1 CPU core)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -u pgadmin3-1.10.1/debian/pgadmin3.install pgadmin3-1.10.1/debian/pgadmin3.install
--- pgadmin3-1.10.1/debian/pgadmin3.install
+++ pgadmin3-1.10.1/debian/pgadmin3.install
@@ -1,3 +1,3 @@
 debian/tmp/usr/bin/pgadmin3
-debian/pgadmin3.xpm usr/share/pixmaps
+debian/pgadmin3.svg usr/share/pixmaps
 debian/pgadmin3.desktop	usr/share/applications
diff -u pgadmin3-1.10.1/debian/changelog pgadmin3-1.10.1/debian/changelog
diff -u pgadmin3-1.10.1/debian/pgadmin3-data.copyright pgadmin3-1.10.1/debian/pgadmin3-data.copyright
--- pgadmin3-1.10.1/debian/pgadmin3-data.copyright
+++ pgadmin3-1.10.1/debian/pgadmin3-data.copyright
@@ -74,0 +75,31 @@
+
+debian/pgadmin3.svg:
+
+The blue elephant SVG icon was downloaded from: http://en.wikipedia.org/wiki/PostgreSQL
+Original source: http://pgfoundry.org/docman/?group_id=1000089 
+
+Copyright:
+        Copyright (C) 2006 by Jeff MacDonald
+
+License:
+
+   The blue elephant icon is distributed under the BSD License.
+
+   Copyright (c) Jeff MacDonald.
+   All rights reserved.
+
+   Redistribution and use in source and binary forms, with or without
+   modification, are permitted provided that the following conditions
+   are met:
+
+   1. Redistributions of source code must retain the above copyright
+      notice, this list of conditions and the following disclaimer.
+   2. Redistributions in binary form must reproduce the above copyright
+      notice, this list of conditions and the following disclaimer in the
+      documentation and/or other materials provided with the distribution.
+   3. Neither the name of the University nor the names of its contributors
+      may be used to endorse or promote products derived from this software
+      without specific prior written permission.
+
+On Debian GNU/Linux systems, the complete text of the BSD License
+can be found in `/usr/share/common-licenses/BSD'.
diff -u pgadmin3-1.10.1/debian/control pgadmin3-1.10.1/debian/control
--- pgadmin3-1.10.1/debian/control
+++ pgadmin3-1.10.1/debian/control
@@ -1,7 +1,8 @@
 Source: pgadmin3
 Section: database
 Priority: optional
-Maintainer: Gerfried Fuchs <[email protected]>
+Maintainer: Ubuntu Developers <[email protected]>
+XSBC-Original-Maintainer: Gerfried Fuchs <[email protected]>
 Build-Depends: debhelper (>= 7), libpq-dev (>= 8.1), devscripts,
   libwxgtk2.8-dev, libxml2-dev, libxslt1-dev, dpkg-dev (>= 1.13.19),
   autotools-dev
only in patch2:
unchanged:
--- pgadmin3-1.10.1.orig/debian/pgadmin3.svg
+++ pgadmin3-1.10.1/debian/pgadmin3.svg
@@ -0,0 +1,22 @@
+<?xml version="1.0"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
+  "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd";>
+
+<svg width="432.071pt" height="445.383pt" viewBox="0 0 432.071 445.383" xml:space="preserve" xmlns="http://www.w3.org/2000/svg";>
+<g id="orginal" style="fill-rule:nonzero;clip-rule:nonzero;stroke:#000000;stroke-miterlimit:4;">
+	</g>
+<g id="Layer_x0020_3" style="fill-rule:nonzero;clip-rule:nonzero;fill:none;stroke:#FFFFFF;stroke-width:12.4651;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;">
+<path style="fill:#000000;stroke:#000000;stroke-width:37.3953;stroke-linecap:butt;stroke-linejoin:miter;" d="M323.205,324.227c2.833-23.601,1.984-27.062,19.563-23.239l4.463,0.392c13.517,0.615,31.199-2.174,41.587-7c22.362-10.376,35.622-27.7,13.572-23.148c-50.297,10.376-53.755-6.655-53.755-6.655c53.111-78.803,75.313-178.836,56.149-203.322    C352.514-5.534,262.036,26.049,260.522,26.869l-0.482,0.089c-9.938-2.062-21.06-3.294-33.554-3.496c-22.761-0.374-40.032,5.967-53.133,15.904c0,0-161.408-66.498-153.899,83.628c1.597,31.936,45.777,241.655,98.47,178.31    c19.259-23.163,37.871-42.748,37.871-42.748c9.242,6.14,20.307,9.272,31.912,8.147l0.897-0.765c-0.281,2.876-0.157,5.689,0.359,9.019c-13.572,15.167-9.584,17.83-36.723,23.416c-27.457,5.659-11.326,15.734-0.797,18.367c12.768,3.193,42.305,7.716,62.268-20.224    l-0.795,3.188c5.325,4.26,4.965,30.619,5.72,49.452c0.756,18.834,2.017,36.409,5.856,46.771c3.839,10.36,8.369,37.05,44.036,29.406c29.809-6.388,52.6-15.582,54.677-101.107"/>
+<path style="fill:#336791;stroke:none;" d="M402.395,271.23c-50.302,10.376-53.76-6.655-53.76-6.655c53.111-78.808,75.313-178.843,56.153-203.326c-52.27-66.785-142.752-35.2-144.262-34.38l-0.486,0.087c-9.938-2.063-21.06-3.292-33.56-3.496c-22.761-0.373-40.026,5.967-53.127,15.902    c0,0-161.411-66.495-153.904,83.63c1.597,31.938,45.776,241.657,98.471,178.312c19.26-23.163,37.869-42.748,37.869-42.748c9.243,6.14,20.308,9.272,31.908,8.147l0.901-0.765c-0.28,2.876-0.152,5.689,0.361,9.019c-13.575,15.167-9.586,17.83-36.723,23.416    c-27.459,5.659-11.328,15.734-0.796,18.367c12.768,3.193,42.307,7.716,62.266-20.224l-0.796,3.188c5.319,4.26,9.054,27.711,8.428,48.969c-0.626,21.259-1.044,35.854,3.147,47.254c4.191,11.4,8.368,37.05,44.042,29.406c29.809-6.388,45.256-22.942,47.405-50.555    c1.525-19.631,4.976-16.729,5.194-34.28l2.768-8.309c3.192-26.611,0.507-35.196,18.872-31.203l4.463,0.392c13.517,0.615,31.208-2.174,41.591-7c22.358-10.376,35.618-27.7,13.573-23.148z"/>
+<path d="M215.866,286.484c-1.385,49.516,0.348,99.377,5.193,111.495c4.848,12.118,15.223,35.688,50.9,28.045c29.806-6.39,40.651-18.756,45.357-46.051c3.466-20.082,10.148-75.854,11.005-87.281"/>
+<path d="M173.104,38.256c0,0-161.521-66.016-154.012,84.109c1.597,31.938,45.779,241.664,98.473,178.316c19.256-23.166,36.671-41.335,36.671-41.335"/>
+<path d="M260.349,26.207c-5.591,1.753,89.848-34.889,144.087,34.417c19.159,24.484-3.043,124.519-56.153,203.329"/>
+<path style="stroke-linejoin:bevel;" d="M348.282,263.953c0,0,3.461,17.036,53.764,6.653c22.04-4.552,8.776,12.774-13.577,23.155c-18.345,8.514-59.474,10.696-60.146-1.069c-1.729-30.355,21.647-21.133,19.96-28.739c-1.525-6.85-11.979-13.573-18.894-30.338    c-6.037-14.633-82.796-126.849,21.287-110.183c3.813-0.789-27.146-99.002-124.553-100.599c-97.385-1.597-94.19,119.762-94.19,119.762"/>
+<path d="M188.604,274.334c-13.577,15.166-9.584,17.829-36.723,23.417c-27.459,5.66-11.326,15.733-0.797,18.365c12.768,3.195,42.307,7.718,62.266-20.229c6.078-8.509-0.036-22.086-8.385-25.547c-4.034-1.671-9.428-3.765-16.361,3.994z"/>
+<path d="M187.715,274.069c-1.368-8.917,2.93-19.528,7.536-31.942c6.922-18.626,22.893-37.255,10.117-96.339c-9.523-44.029-73.396-9.163-73.436-3.193c-0.039,5.968,2.889,30.26-1.067,58.548c-5.162,36.913,23.488,68.132,56.479,64.938"/>
+<path style="fill:#FFFFFF;stroke-width:4.155;stroke-linecap:butt;stroke-linejoin:miter;" d="M172.517,141.7c-0.288,2.039,3.733,7.48,8.976,8.207c5.234,0.73,9.714-3.522,9.998-5.559c0.284-2.039-3.732-4.285-8.977-5.015c-5.237-0.731-9.719,0.333-9.996,2.367z"/>
+<path style="fill:#FFFFFF;stroke-width:2.0775;stroke-linecap:butt;stroke-linejoin:miter;" d="M331.941,137.543c0.284,2.039-3.732,7.48-8.976,8.207c-5.238,0.73-9.718-3.522-10.005-5.559c-0.277-2.039,3.74-4.285,8.979-5.015c5.239-0.73,9.718,0.333,10.002,2.368z"/>
+<path d="M350.676,123.432c0.863,15.994-3.445,26.888-3.988,43.914c-0.804,24.748,11.799,53.074-7.191,81.435"/>
+<path style="stroke-width:3;" d="M0,60.232"/>
+</g>
+</svg>
\ No newline at end of file

--- End Message ---
--- Begin Message --- 
Version: 1.10.1-2

        Hi!

* Antoine Leclair <[email protected]> [2010-02-12 07:17:01 CET]:
> Package: pgadmin3
> Version: 1.10.1-1
> Severity: minor
> Tags: patch
> User: [email protected]
> Usertags: origin-ubuntu lucid ubuntu-patch
> 
> The xpm icon was pretty ugly. We added a svg icon that looks nice.

 And broke the Debian menu along the lines through not installing the
xpm file anymore. It would had been convenient if the issue could have
get forwarded earlier (the bug in launchpad is actually almost a year
old) so we could have solved that long ago in cooperation.

 Anyway, I uploaded 1.10.1-2 on the weekend and Fabrice already did file
a sync request in LP (#521856) to get rid of the ubuntu diff and to have
the issue fixed properly:

,----------------------------> quote <----------------------------
| Please sync pgadmin3 1.10.1-2 (universe) from Debian unstable (main)
| 
| Explanation of the Ubuntu delta and why it can be dropped:
| Change has been adopted by Debian maintainer (Thanks Gerfried! :-) ).
| The package can be synced back.
| 
| Changelog entries since current lucid version 1.10.1-1ubuntu1:
| 
| pgadmin3 (1.10.1-2) unstable; urgency=low
| 
|   * Bump Standards-Version to 3.8.4.
|   * Add ${misc:Depends} to all Depends.
|   * Drop GNOME and System categories from desktop file.
|   * Add pgadmin3.svg image for better freedesktop menu icon.
| 
|  -- Gerfried Fuchs <[email protected]> Fri, 12 Feb 2010 22:23:01 +0100
`----------------------------> quote <----------------------------

 The Drop GNOME and System categories are meant to fix LP #260290.

 Thanks anyway!
Rhonda

--- End Message ---

Reply via email to