Your message dated Thu, 18 Feb 2010 22:03:49 +0000
with message-id <[email protected]>
and subject line Bug#570443: fixed in debhelper 7.4.15
has caused the Debian Bug report #570443,
regarding dh_auto_clean: should not close stderr
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
570443: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=570443
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: debhelper
Version: 7.4.13
Severity: normal
Tags: patch
Hello,
I have a little problem when building rt-tests[1]:
uklei...@cassiopeia:~/gsrc/rt-tests-0.66$ ls *.d*
ls: cannot access *.d*: No such file or directory
uklei...@cassiopeia:~/gsrc/rt-tests-0.66$ dh_auto_clean
for F in cyclictest signaltest pi_stress rt-migrate-test ptsematest
sigwaittest svsematest sendme pip *.o .depend *.*~ *.orig *.rej
rt-tests.spec *.d ; do find -type f -name $F | xargs rm -f; done
rm -f hwlatdetect
rm -f tags
rm -rf BUILD RPMS SRPMS releases *.tar.gz rt-tests.spec
uklei...@cassiopeia:~/gsrc/rt-tests-0.66$ ls *.d*
cyclictest.d.25488 ptsematest.d.25468 signaltest.d.25483
pip.d.25448 rt-migrate-test.d.25473 sigwaittest.d.25463
pi_stress.d.25478 sendme.d.25453 svsematest.d.25458
when creating a package that results in:
...
dpkg-source: info: local changes stored in
rt-tests-0.66/debian/patches/debian-changes-0.66-1, the modified files are:
rt-tests-0.66/cyclictest.d.25488
rt-tests-0.66/pi_stress.d.25478
rt-tests-0.66/pip.d.25448
rt-tests-0.66/ptsematest.d.25468
rt-tests-0.66/rt-migrate-test.d.25473
rt-tests-0.66/sendme.d.25453
rt-tests-0.66/signaltest.d.25483
rt-tests-0.66/sigwaittest.d.25463
rt-tests-0.66/svsematest.d.25458
...
which isn't nice.
rt-tests' Makefile contains:
...
# Pattern rule to generate dependency files from .c files
%.d: %.c
@set -e; rm -f $@; \
$(CC) -MM $(CFLAGS) $< > $...@.$$$$; \
sed 's,\($*\)\.o[ :]*,\1.o $@ : ,g' < $...@.$$$$ > $@; \
rm -f $...@.$$$$
...
-include $(sources:.c=.d)
...
So the *.d files are generated when debhelper tries to determine if
there is a distclean target by running
make -s -n --no-print-directory distclean
. That is OK so far. The problem now is that debhelper closes stderr
for the above command which makes sed fail[2] above and so
rm -f $...@.$$$$
isn't executed which leaves the files above.
Best regards
Uwe
[1] see git://git.pengutronix.de/git/ukl/rt-tests.git
[2] I'm not sure if this is sound behaviour, too.
-- System Information:
Debian Release: squeeze/sid
APT prefers proposed-updates
APT policy: (900, 'proposed-updates'), (900, 'stable'), (600,
'testing-proposed-updates'), (600, 'testing'), (500,
'oldstable-proposed-updates'), (500, 'oldstable'), (200, 'unstable'), (2,
'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.32-2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages debhelper depends on:
ii binutils 2.20-6 The GNU assembler, linker and bina
ii dpkg-dev 1.15.5.6 Debian package development tools
ii file 4.26-1 Determines file type using "magic"
ii html2text 1.3.2a-5 advanced HTML to text converter
ii man-db 2.5.2-4 on-line manual pager
ii perl 5.10.1-9 Larry Wall's Practical Extraction
ii perl-base 5.10.1-9 minimal Perl system
ii po-debconf 1.0.15 manage translated Debconf template
debhelper recommends no packages.
Versions of packages debhelper suggests:
pn dh-make <none> (no description available)
-- no debconf information
>From 1747dd4e5dfcbd65cd3441960d9d6475c79b46e9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <[email protected]>
Date: Thu, 18 Feb 2010 22:02:57 +0100
Subject: [PATCH] provide /dev/null on stderr for make in exists_make_target
The Makefile might include commands that are executed even though -n is
given (e.g. to generate included files). Be nice to them and provide a
valid stderr.
This was noticed when building rt-tests which calls sed to generate some
files tracking dependencies. sed tries to close stderr at the end and
exits with return value 4 if that fails.
---
Debian/Debhelper/Buildsystem/makefile.pm | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Debian/Debhelper/Buildsystem/makefile.pm
b/Debian/Debhelper/Buildsystem/makefile.pm
index 2c14c15..c9fe314 100644
--- a/Debian/Debhelper/Buildsystem/makefile.pm
+++ b/Debian/Debhelper/Buildsystem/makefile.pm
@@ -20,6 +20,7 @@ sub exists_make_target {
unshift @opts, "-C", $buildpath if $buildpath ne ".";
open(SAVEDERR, ">&STDERR");
close STDERR;
+ open(STDERR, '>/dev/null');
open(MAKE, "-|", $this->{makecmd}, @opts, $target);
my $output=<MAKE>;
close MAKE;
--
1.7.0
--- End Message ---
--- Begin Message ---
Source: debhelper
Source-Version: 7.4.15
We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive:
debhelper_7.4.15.dsc
to main/d/debhelper/debhelper_7.4.15.dsc
debhelper_7.4.15.tar.gz
to main/d/debhelper/debhelper_7.4.15.tar.gz
debhelper_7.4.15_all.deb
to main/d/debhelper/debhelper_7.4.15_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Joey Hess <[email protected]> (supplier of updated debhelper package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 18 Feb 2010 16:37:34 -0500
Source: debhelper
Binary: debhelper
Architecture: source all
Version: 7.4.15
Distribution: unstable
Urgency: low
Maintainer: Joey Hess <[email protected]>
Changed-By: Joey Hess <[email protected]>
Description:
debhelper - helper programs for debian/rules
Closes: 570443
Changes:
debhelper (7.4.15) unstable; urgency=low
.
* The fix for #563557 caused some new trouble involving makefile
that misbehave when stderr is closed. Reopen it to /dev/null
when testing for the existance of a makefile target. Closes: #570443
Checksums-Sha1:
6cd8e3a982fa45895340196f41d8d0301dcacf5d 1551 debhelper_7.4.15.dsc
d43068dd49717f1549b7f677c987256bf4cfdb67 352904 debhelper_7.4.15.tar.gz
c2f7456283caeccb417fcfa3f57d48dba528ee3d 455268 debhelper_7.4.15_all.deb
Checksums-Sha256:
1da5773abb6008acb87e51ccc431f10aa95005a78c5bd28f735df8b7723f7531 1551
debhelper_7.4.15.dsc
e69fcdc86bac510d667ab7df33536f823f067708818c3d7dd88d8cab9e73cdfa 352904
debhelper_7.4.15.tar.gz
b256d033505cc26993f33de4e4f9d36a102ad16edc1f5b698a92a2dec5356ea1 455268
debhelper_7.4.15_all.deb
Files:
b4c532bdee3c2ada74a76661f87d8602 1551 devel optional debhelper_7.4.15.dsc
6c021af091b0acb4ca09e7ce641bdfd2 352904 devel optional debhelper_7.4.15.tar.gz
34cd522ef91839078a551140ea557692 455268 devel optional debhelper_7.4.15_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iQIVAwUBS321UckQ2SIlEuPHAQg0Fg//eTNh+v83lujUyhIgzJVyAbZ6t5bH8RjQ
Bn4m7TvlUs4pELBAZt9SGdwusgbQ8kEi8anEFCNM+zAnfaM5gNx18PYsA4oX2ZHi
/c7OgCQeytmnNtFYs03QzPbcpub/hwnacpQrkdGnwyRL2RTEaGLqeuYpeAKCyjFC
Lv0YRAc5N8T8vsUjuLutaSw/hVGQe5afn20ahHvwsY7Jdpyu+dtQWAbFlZB2Xp3k
XoOiCoN2YKGIZgseYRCoatFcM6vHj8H6QDOfdgyGgH7Vm0DSdKySQVkaV8kRLTUN
nX/TMRBEfeznp4+TxX58cZJWDyakFIUELdFWl1W5A2pPD/A+iyL/YMGWkq6Ktj9G
dBl5CXNKEqQYQfQE9epqz3KRKDyxVpWeGZiZQZj/7mxdjoJO2CEvrORQzeivJnEO
HT5ZA7XQ+suOTXC0/I9vDKaYmE908VfILjfQi+TomeWLkydeHpfvQDelpakg0L9x
8991Y/hy1nnRnviXtB65/IK4btBjkkSpfZUSALKxYnrWJAJqVSqdnoL2p93+xfZd
MYeqHazHvZaA+ZaqHoNai6H3z5HOlstuMRMi5SKbXhPrMDWkwmceYRB+vEhsAcrD
tBiUp9iUnlP5vi5n3bbFeHOWjGlcnggrwDUT2fKd/3PomK5XA/gVvr5xau4VaURg
cUzE5GmorIQ=
=ylhj
-----END PGP SIGNATURE-----
--- End Message ---
