Your message dated Sat, 27 Feb 2010 05:17:08 +0000
with message-id <[email protected]>
and subject line Bug#502966: fixed in backupninja 0.9.7-5
has caused the Debian Bug report #502966,
regarding Add support for customising mysqldump options
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
502966: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=502966
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: backupninja
Version: 0.9.6-3
Tags: patch
It would be great in backupninja supported customising mysqldump options
without having to 'fork' the supplied handler.
The defaults supplied are somewhat understandable but unfortunate - for
example, adopting extended inserts reduces the time taken to dump and
insert, as well as I/O space and time. For regular snapshot backups, I
may also wish to not lock the tables so that the service is not paused.
(etc.)
My current solution is simply to apply:
- DUMP_BASE="$MYSQLDUMP $defaultsfile --lock-tables --complete-insert
--add-drop-table [..]"
+ DUMP_BASE="$MYSQLDUMP $defaultsfile"
to /usr/share/backupninja/mysql and specify my desired settings in the
backup user's ~/.my.cf -- the command line arguments would otherwise
override this file.
However, adding an option to the mysql helper to modify the mysqldump
options is probably a cleaner way. First stab at a patch attached.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected]
`-
diff -urNd backupninja-0.9.6.orig/handlers/mysql.helper.in
backupninja-0.9.6/handlers/mysql.helper.in
--- backupninja-0.9.6.orig/handlers/mysql.helper.in 2008-10-21
12:03:51.000000000 +0100
+++ backupninja-0.9.6/handlers/mysql.helper.in 2008-10-21 12:26:23.000000000
+0100
@@ -53,6 +53,9 @@
}
do_mysql_final() {
+ default_mysqldump_options="--lock-tables --complete-insert --add-drop-table
--quick --quote-names"
+ sqldumpoptions="$default_mysqldump_options"
+
if [ -z "$_DISABLE_HOTCOPY" ]; then
checkBox "$mysql_title" "check options" \
"sqldump" "create a backup using mysqldump (more compat)." no \
@@ -98,6 +101,10 @@
# if yes, compress the sqldump output.
$compress
+# mysqldumpoptions = <options> (default = $default_mysqldump_options)
+# arguments to pass to mysqldump
+$mysqldumpoptions
+
# dbhost = <host> (default = localhost)
EOF
diff -urNd backupninja-0.9.6.orig/handlers/mysql.in
backupninja-0.9.6/handlers/mysql.in
--- backupninja-0.9.6.orig/handlers/mysql.in 2008-10-21 12:03:51.000000000
+0100
+++ backupninja-0.9.6/handlers/mysql.in 2008-10-21 12:10:06.000000000 +0100
@@ -10,6 +10,7 @@
getconf dbhost localhost
getconf hotcopy no
getconf sqldump no
+getconf sqldumpoptions
getconf compress yes
getconf vsname
@@ -245,7 +246,7 @@
for db in $databases
do
- DUMP_BASE="$MYSQLDUMP $defaultsfile --lock-tables --complete-insert
--add-drop-table --quick --quote-names"
+ DUMP_BASE="$MYSQLDUMP $defaultsfile $sqldumpoptions"
# Dumping structure and data
DUMP="$DUMP_BASE $ignore $db"
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: backupninja
Source-Version: 0.9.7-5
We believe that the bug you reported is fixed in the latest version of
backupninja, which is due to be installed in the Debian FTP archive:
backupninja_0.9.7-5.diff.gz
to main/b/backupninja/backupninja_0.9.7-5.diff.gz
backupninja_0.9.7-5.dsc
to main/b/backupninja/backupninja_0.9.7-5.dsc
backupninja_0.9.7-5_all.deb
to main/b/backupninja/backupninja_0.9.7-5_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Micah Anderson <[email protected]> (supplier of updated backupninja package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 26 Feb 2010 23:44:25 -0500
Source: backupninja
Binary: backupninja
Architecture: source all
Version: 0.9.7-5
Distribution: unstable
Urgency: low
Maintainer: Micah Anderson <[email protected]>
Changed-By: Micah Anderson <[email protected]>
Description:
backupninja - lightweight, extensible meta-backup system
Closes: 398435 465837 502966 511299 525318 534592 536049 536360 537266 562249
563044 563734 566703
Changes:
backupninja (0.9.7-5) unstable; urgency=low
.
* Upload experimental package to unstable
* Bump Standards version: no changes
.
backupninja (0.9.7-4) experimental; urgency=low
.
* Fix bad upstream merge
.
backupninja (0.9.7-3) experimental; urgency=low
.
* Fix configure script, which was generated from previous release
.
backupninja (0.9.7-2) experimental; urgency=low
.
* Fix FTBFS by chmod +x configure and update clean target
.
backupninja (0.9.7-1) experimental; urgency=low
.
* Add dependency possibility on bsd-mailx for mailx transition
* Bump standards version to 3.8.3 (no changes)
* Install rsync and maildir examples (Closes: #566703)
* Fixed upstream homepage and VCS in debian/control (Closes: #525318)
* Brought back the desturl options to the dup handler (Closes: #534592)
* Fixed upstream homepage and VCS in debian/copyright
* New upstream release
. use gzip's --resyncable option
. add bash pipefail option so backups fail more reliably
. fix location of maildir deleted_on file
. add missing destid_file options to maildir ssh conntions
. added sshoptions variable for arbitrary ssh options
. updated example file to include destid_file, destport and sshoptions
. use any subdirectories for maildir (not just "a" to "z")
. hide mysql ping output to prevent confusion
. fix mysql error message when it is not running
. quote output filenames for shell meta-characters in database names
. do not assume English locale when using date (Closes: #465837)
. add 'when = manual' option, thanks Tuomas Jormola (Closes: #511299)
. new reportinfo option to include in email (Closes: #563734)
. fix reportspace to skip non-directories (Closes: #536049)
. set BACKUPNINJA_DEBUG when invoked with -d (Closes: #537266)
. allow form fields input to grow up to 100 chars (Closes: #562249)
. customizable mysqldump options, thanks Chris Lamb! (Closes: #502966)
. fix rdiff-backup include/exclude paths with spaces (Closes: #398435)
. fix confusing error if rdiff-backup cant be found on remote server
. increased element number in includes/excludes in ninjahelper
. add luksheaders option (default=disabled) to backup the LUKS header
. add lvm option (default=disabled) to backup LVM metadata for LVM VGs
. backup dmsetup info, for easier restoring of LUKS headers
. fixed bandwidthlimit syntax erro, thanks Ian Beckwith!
. send duplicity debug output line-by-line instead (Closes: #536360)
. duplicity output now "info" so reportinfo can include (Closes: #563734)
. do not propose to exclude /home/*/.gnupg twice anymore (Closes: #563044)
. add support for Amazon S3 buckets, thanks Stefan!
Checksums-Sha1:
beb2779a45675c28b8474012e1f5d95bf1b3b539 1780 backupninja_0.9.7-5.dsc
5c1b1270565b40bfd6490be6167c769deb8d1ab5 67873 backupninja_0.9.7-5.diff.gz
367ed5cade9f6d9d3c30862044897c439d812184 96162 backupninja_0.9.7-5_all.deb
Checksums-Sha256:
cd51c32590c97dbfb0bd66ed90fd63992693d36cc6a9e96760c109ab9c155c3b 1780
backupninja_0.9.7-5.dsc
0c9967193c2690694df39f7e203f37d3db1a227211a46b4afc634bc1c9d5e21e 67873
backupninja_0.9.7-5.diff.gz
d066cde75a0b2a121df84a3442d42253f2fa6082e6c3acd095253d97a2fda43d 96162
backupninja_0.9.7-5_all.deb
Files:
1ddaf0d4bcac99c403fd702a6a604c99 1780 admin optional backupninja_0.9.7-5.dsc
a5c9621a1acc4fa077942c8f1efaebc8 67873 admin optional
backupninja_0.9.7-5.diff.gz
210bbe2d2bd7be4d9c0f30a4b8bed1c8 96162 admin optional
backupninja_0.9.7-5_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iQIcBAEBCgAGBQJLiKb/AAoJEIy/mjIoYaeQDhgP+wT+eOoZxMdoLfwsh7W9TsX2
c1TCHo8+dsks1DYM3X/HEsapCc7fI9Cv2MDD7b27InA1ktfd3QMLAaxC1V7oohXd
dfvCJtc3MP4D1dB5Rlu1slulQzHpYly6U+v8VFDQhjeNKiVCzThm3V4Ppfnba06B
wN/AmLXC5blcJl9KfMIy3SHzp2msj3I+ryhEWHELN/id27116gjWBog2fVIXqvVl
LXTAdDFljCD1CCSv0C4M2Ic4gAIDYzpWKE5txLV9syLEymaK2iibhjlrwg96qZqQ
mvf3PQPq39EeFFe4E/LLE52VeJO6r0DgYEmOYdUn7KrTFkyFpRRS92b0qrE/7y1F
5hU3qvmEF4NQLsD0frfstBY6JxP/wea/BwBmx53FA+aoQdxhCYw4L+Df/NkTBh15
Z0yOaeA3BZo0a4iehiuSqa3FQPKsYMw9q3FcmDaJTluCJgYAnY01ZrctE04FdEWq
b+fRzNrNCYKWbWVaWYyxF7FyHjYABe1avUfF7N0bunIu1Asrh/ZF+n8heFp9UY2G
Xwr/uhz9l6S3GIsqiWrT/xRcskOyBO/w2KFGrMqyPLQj9D3LjUv332Y8KCjYriLv
MJkWkaLMX4baCFaoZ5zzFjMMmzT9BZQ1j1Zu6yNF3JJ3d7wsHVaevg5oEUqx6F4R
a3i49KleLdRKz8MkspDe
=zQYi
-----END PGP SIGNATURE-----
--- End Message ---
