Your message dated Fri, 28 May 2010 01:10:44 -0400
with message-id <[email protected]>
and subject line closing
has caused the Debian Bug report #530603,
regarding Many Makefiles need their PREFIX overridden (not only the ones
generated by MakeMaker)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
530603: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530603
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: debhelper
Version: 7.2.14
Severity: minor
Tags: patch
Dear Joey,
the dh_auto_install script checks if a Makefile has been generated by
MakeMaker and then overrides its PREFIX variable. However, it is not
only Makefiles generated by MakeMaker that need this variable
overridden. To be honest, every Makefile that I know of that is not
generated by autotools (or similar) does contain a PREFIX variable
that is by default set to PREFIX=/usr/local in most cases. Of source
this variable needs to be overridden whenever this Makefile is called
(well, maybe not in the clean rule).
The attached patch changes the search string to match every possible
way (that I know of) to set a PREFIX variable in the Makefile and
triggers to override it. Please note that the patch only applies to
dh_auto_install, but should by applied against dh_auto_build as well.
Cheers,
Fabian
PS: Maybe it won't even hurt to just pass the PREFIX variable to the
make call without any further checks at all?
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum
Telefon: +49 (0)234 / 32-26334
Fax: +49 (0)234 / 32-14227
E-Mail: [email protected]
--- dh_auto_install.orig 2009-05-26 10:48:34.000000000 +0200
+++ dh_auto_install 2009-05-26 10:49:32.000000000 +0200
@@ -64,9 +64,9 @@
$ENV{MAKE}="make" unless exists $ENV{MAKE};
my @params="DESTDIR=$destdir";
- # Special case for MakeMaker generated Makefiles.
+ # Special case for Makefiles that set their own PREFIX variable.
if (-e "Makefile" &&
- system('grep -q "generated automatically by MakeMaker" Makefile') == 0) {
+ system('grep -q "^PREFIX[[:space:]]*\([:+?]\)\?=" Makefile') == 0) {
push @params, "PREFIX=/usr";
}
--- End Message ---
--- Begin Message ---
I don't belive that it's possible to support setting PREFIX globally,
and it is certianly easy to override it in packages that need it,
so closing.
--
see shy jo
signature.asc
Description: Digital signature
--- End Message ---
