Your message dated Sat, 5 Jun 2010 12:06:33 +0900
with message-id <[email protected]>
and subject line Re: Bug#538833:
has caused the Debian Bug report #538833,
regarding quilt-el: should check package installation before setting up
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
538833: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=538833
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: quilt-el
Version: 0.45.4-1
Severity: minor
Hi,
I looked at this code in order to see about packaging it, before
realizing that it was already packaged. I have a few suggestions that
you can forward to the upstream maintainer.
It is in general okay, but far from checkdoc clean. Open it in Emacs
and run:
M-x checkdoc
to see where.
Also, it defines `C-c.' keys discouraged by elisp coding conventions. From
the elisp manual:
: D.2 Key Binding Conventions
: ===========================
:
: * Sequences consisting of `C-c' followed by a control character or a
: digit are reserved for major modes.
:
: * Sequences consisting of `C-c' followed by `{', `}', `<', `>', `:'
: or `;' are also reserved for major modes.
:
: * Sequences consisting of `C-c' followed by any other punctuation
: character are allocated for minor modes. Using them in a major
: mode is not absolutely prohibited, but if you do that, the major
: mode binding may be shadowed from time to time by minor modes.
I suggest the prefix `C-cC-c' instead.
It doesn't byte-compile cleanly:
: In quilt-editable:
: quilt.el:125:28:Warning: reference to free variable `quilt-edit-top-only'
:
: In quilt-header-commit:
: quilt.el:399:9:Warning: reference to free variable `quilt-header-directory'
:
: In quilt-edit-header:
: quilt.el:425:23:Warning: assignment to free variable `quilt-header-directory'
: quilt.el:426:23:Warning: assignment to free variable `mode-map'
:
: In end of data:
: quilt.el:500:1:Warning: the following functions are not known to be
: defined: to-alist, editable, revert-or-hook-buffer, revert,
: revert-list
This very last one is more important. The code has many embedded
`defun' function definitions, which won't byte-compile, and which will
pollute emacs once they get evaluated. I would prefix them all with
"quilt-" and place them at top level (i.e. not embbeded in code).
Lastly, /etc/emacs/site-start.d/50quilt-el.el should check that the
package is actually installed prior to setting up the package, since
that config file may be there after a package is removed but not purged.
I suggest to test if /usr/share/emacs/site-lisp/quilt-el/quilt.el is
present.
All of these issues can be easily addressed.
Thanks,
--
Peter S. Galbraith, Debian Developer <[email protected]>
http://people.debian.org/~psg
GPG key 1024/D2A913A1 - 97CE 866F F579 96EE 6E68 8170 35FF 799E
--- End Message ---
--- Begin Message ---
This package checks whether package is installed or not before setting
up. So there is no problem if it has been removed but not been purged.
Thanks,
Satoru
--- End Message ---
