Your message dated Sat, 24 Jul 2010 14:49:33 +0000
with message-id <[email protected]>
and subject line Bug#582956: fixed in dfu-util 0.1-1
has caused the Debian Bug report #582956,
regarding dfu-util: odd exit w/ upload; no error handling w/ download
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
582956: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582956
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dfu-util
Version: 0.0+r4880-1
Severity: normal
Tags: patch
The output on stdout looks odd in 'upload' mode because the upload loop
never actually breaks properly; it always exits through the 'out_close'
path so doesn't print "finished" or terminate the line. Changing one
'goto out_close' to a 'break' fixes this problem.
The download waits until dfu_get_status returns DFU_STATE_dfuDNLOAD_IDLE,
but if there is a verify or format error, the device will transition to
DFU_STATE_dfuERROR instead, which will result in an infinite loop.
The attached patch fixes both of these problems.
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.32-3-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages dfu-util depends on:
ii libc6 2.10.2-8 Embedded GNU C Library: Shared lib
ii libusb-0.1-4 2:0.1.12-14 userspace USB programming library
dfu-util recommends no packages.
dfu-util suggests no packages.
-- no debconf information
diff -ru dfu-util-0.0+r4880.orig/src/sam7dfu.c dfu-util-0.0+r4880/src/sam7dfu.c
--- dfu-util-0.0+r4880.orig/src/sam7dfu.c 2010-05-20 17:19:07.000000000 -0400
+++ dfu-util-0.0+r4880/src/sam7dfu.c 2010-05-20 17:24:41.000000000 -0400
@@ -60,7 +60,7 @@
if (rc < xfer_size) {
/* last block, return */
ret = total_bytes;
- goto out_close;
+ break;
}
putchar('#');
fflush(stdout);
@@ -143,7 +143,8 @@
goto out_close;
}
usleep(5000);
- } while (dst.bState != DFU_STATE_dfuDNLOAD_IDLE);
+ } while (dst.bState != DFU_STATE_dfuDNLOAD_IDLE &&
+ dst.bState != DFU_STATE_dfuERROR);
if (dst.bStatus != DFU_STATUS_OK) {
printf(" failed!\n");
printf("state(%u) = %s, status(%u) = %s\n", dst.bState,
Only in dfu-util-0.0+r4880/src: sam7dfu.c~
--- End Message ---
--- Begin Message ---
Source: dfu-util
Source-Version: 0.1-1
We believe that the bug you reported is fixed in the latest version of
dfu-util, which is due to be installed in the Debian FTP archive:
dfu-util_0.1-1.debian.tar.gz
to main/d/dfu-util/dfu-util_0.1-1.debian.tar.gz
dfu-util_0.1-1.dsc
to main/d/dfu-util/dfu-util_0.1-1.dsc
dfu-util_0.1-1_amd64.deb
to main/d/dfu-util/dfu-util_0.1-1_amd64.deb
dfu-util_0.1.orig.tar.gz
to main/d/dfu-util/dfu-util_0.1.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Uwe Hermann <[email protected]> (supplier of updated dfu-util package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 24 Jul 2010 15:46:44 +0200
Source: dfu-util
Binary: dfu-util
Architecture: source amd64
Version: 0.1-1
Distribution: unstable
Urgency: low
Maintainer: Uwe Hermann <[email protected]>
Changed-By: Uwe Hermann <[email protected]>
Description:
dfu-util - Device firmware update (DFU 1.0) USB programmer
Closes: 569938 582956
Changes:
dfu-util (0.1-1) unstable; urgency=low
.
* New upstream release.
+ Now states that only DFU 1.0 is supported (Closes: #569938).
* debian/control:
+ Standards-Version: 3.9.0 (no changes required).
+ Updated to new upstream homepage.
+ Drop dependency on autoconf/automake, we no longer build from svn.
* debian/copyright: Various updates.
* debian/watch: Add proper URLs now, we no longer track svn snapshots.
* Fix "odd exit w/ upload; no error handling w/ download" (Closes: #582956).
Thanks C. Scott Ananian <[email protected]> for the patch!
Checksums-Sha1:
76ec0cd7334319ffa264d32e851159f058b804ea 1048 dfu-util_0.1-1.dsc
1a0f79db06be2380277b7ab56a9c9f7068b25485 103135 dfu-util_0.1.orig.tar.gz
5b1f88f08605dcbc4ec49468fc65d3f455413a47 2773 dfu-util_0.1-1.debian.tar.gz
054a2fbddabfced4e1617fd541689296e73f7f24 15676 dfu-util_0.1-1_amd64.deb
Checksums-Sha256:
6e89cc631d3a3b85fbfe5f54148b9ddc7f8a5111676def89feaac79ca699e3ed 1048
dfu-util_0.1-1.dsc
a27cc667be9b158fecf0ed066698e30eca0c0b3cd7a85aad2058d47ffe16f0e1 103135
dfu-util_0.1.orig.tar.gz
5a63397f3a12f8767d474af274e957d578d38ce4fccea960e936d94e1ae6f61d 2773
dfu-util_0.1-1.debian.tar.gz
1e756c57e67c410fdfd63da6b3773d70c246d14531c0d4495421ef85d820eff5 15676
dfu-util_0.1-1_amd64.deb
Files:
9d2b6cc4f03473255165ae7916b61146 1048 electronics extra dfu-util_0.1-1.dsc
454b931249d29e4a6c2a2ade17858490 103135 electronics extra
dfu-util_0.1.orig.tar.gz
c0b4d7439a45284244437aa14154d646 2773 electronics extra
dfu-util_0.1-1.debian.tar.gz
7b4b19e06a6852ae4bc5ccdde3c18328 15676 electronics extra
dfu-util_0.1-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkxK844ACgkQXdVoV3jWIbSK2wCcCJZJouXdaCDAzCoCZEct30uz
+eAAnisl4ApJQUvOhgzisSFdxc1oVID9
=uOGO
-----END PGP SIGNATURE-----
--- End Message ---
