Your message dated Fri, 30 Jul 2010 18:48:53 +0200
with message-id <[email protected]>
and subject line Re: #449390 missing error check for getenv
has caused the Debian Bug report #449390,
regarding missing error check for getenv
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
449390: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=449390
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: lftp
Version: 3.5.14-1
Severity: minor
Hi,
lftp contains the following code in misc.cc:
189 >··· home=getenv("HOME");
190 }
191 else
192 {
193 >··· // extract user name and find the home
194 >··· int name_len=(sl?sl-s-1:strlen(s+1));
195 >··· char *name=(char*)alloca(name_len+1);
196 >··· strncpy(name,s+1,name_len);
197 >··· name[name_len]=0;
198
199 >··· struct passwd *pw=getpwnam(name);
200 >··· if(pw)
201 >··· home=pw->pw_dir;
202 }
203 if(home==0)
204 >··· return s;
205
206 if(sl)
207 {
208 >··· ret_path=(char*)xrealloc(ret_path,strlen(sl)+strlen(home)+1);
This code will segfault if HOME is not set because the return value of getenv
is not checked.
Kind regards
Nico
--
Nico Golde - http://www.ngolde.de - [email protected] - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.
pgpTjC74BqXjH.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Hi,
* Noël Köthe <[email protected]> [2010-07-30 18:32]:
> sorry I forgot about this one.
>
> I forwarded you report to upstream and he answered:
>
> http://www.mail-archive.com/[email protected]/msg01630.html
>
> I'm trying to reproduce it, too but wasn't successfull.
>
> $ unset HOME
> $ echo $HOME
>
> $ lftp ftp.debian.org
> lftp ftp.debian.org:~> ls
> ...
>
> Can you give us more information?
Closing this bug. Actually I reported this 3 years ago and I can't remember
but I also don't see an issue right now.
Cheers
Nico
--
Nico Golde - http://www.ngolde.de - [email protected] - GPG: 0xA0A0AAAA
For security reasons, all text in this mail is double-rot13 encrypted.
pgpz0kR9QYHCg.pgp
Description: PGP signature
--- End Message ---
