Your message dated Sun, 01 Aug 2010 16:47:16 +0000
with message-id <[email protected]>
and subject line Bug#579604: fixed in liboop 1.0-7
has caused the Debian Bug report #579604,
regarding liboop oop-read.h bugfixes
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
579604: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579604
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: liboop4
Version: 1.0-6
Some years ago I contributed a feature for reading lines and records
to liboop: oop-read.h and read.c. Since it took a while for that
feature to make it into distributed versions, for a long time I've
been using my own copy of the source file. It seems that I fixed a
couple of bugs in my copy which are still in the Debian package. I
can't find any record of me having told anyone about them and now I
find that 1.0-6 still has the bugs.
So anyway, here's the patch with my apologies. Could you apply it to
the Debian package, and also forward it upstream for me ?
There are two fixes:
* Initialise "rd->discard" properly
* Avoid rd->neednotcheck becoming negative
Thanks,
Ian.
--- /home/ian/things/trains/hostside/__oop-read-copy.c 2005-06-26
18:26:34.000000000 +0100
+++ read.c 2003-07-18 15:46:22.000000000 +0100
@@ -114,7 +114,6 @@
rd->allocbuf= 0;
rd->used= 0;
rd->alloc= buf ? bufsz : 0;
- rd->discard= 0;
rd->neednotcheck= 0;
rd->displacedchar= -1;
rd->style= *OOP_RD_STYLE_IMMED;
@@ -236,11 +235,7 @@
if (rd->discard) {
rd->used -= rd->discard;
- if (rd->neednotcheck > rd->discard) {
- rd->neednotcheck -= rd->discard;
- } else {
- rd->neednotcheck= 0;
- }
+ rd->neednotcheck -= rd->discard;
memmove(buf, buf + rd->discard, rd->used);
rd->discard= 0;
}
--- End Message ---
--- Begin Message ---
Source: liboop
Source-Version: 1.0-7
We believe that the bug you reported is fixed in the latest version of
liboop, which is due to be installed in the Debian FTP archive:
liboop-dbg_1.0-7_amd64.deb
to main/libo/liboop/liboop-dbg_1.0-7_amd64.deb
liboop-dev_1.0-7_amd64.deb
to main/libo/liboop/liboop-dev_1.0-7_amd64.deb
liboop-doc_1.0-7_all.deb
to main/libo/liboop/liboop-doc_1.0-7_all.deb
liboop4_1.0-7_amd64.deb
to main/libo/liboop/liboop4_1.0-7_amd64.deb
liboop_1.0-7.debian.tar.gz
to main/libo/liboop/liboop_1.0-7.debian.tar.gz
liboop_1.0-7.dsc
to main/libo/liboop/liboop_1.0-7.dsc
liboop_1.0.orig-html.tar.gz
to main/libo/liboop/liboop_1.0.orig-html.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Magnus Holmgren <[email protected]> (supplier of updated liboop package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 30 Jul 2010 17:57:35 +0200
Source: liboop
Binary: liboop4 liboop-dev liboop-doc liboop-dbg
Architecture: source all amd64
Version: 1.0-7
Distribution: unstable
Urgency: low
Maintainer: Magnus Holmgren <[email protected]>
Changed-By: Magnus Holmgren <[email protected]>
Description:
liboop-dbg - Event loop management library - debug symbols
liboop-dev - Event loop management library - development files
liboop-doc - Event loop management library - documentation
liboop4 - Event loop management library
Closes: 555285 579604
Changes:
liboop (1.0-7) unstable; urgency=low
.
* Add debug package
* Switch to source format 3.0 (quilt).
* Put the documentation from the former web site in an additional
upstream tarball. This means the logo no longer has to be stored as-is
instead of as a self-extracting archive, making the associated
Makefile unnecessary as well. The html can be installed by
dh_installdocs instead.
* read_bugfixes.patch: Fixes from Ian Jackson to bugs in a feature for
reading lines and records that he once contributed (Closes: #579604).
* Upgrade to debhelper compatibility level 7, use dh_install instead
of dh_movefiles as well as dh_prep instead of dh_clean.
* configure_support_freebsd_hurd.patch: Separate patch for bug #359930.
* explicit_linking.patch: In Makefile.am, explicitly link test-oop with
all the libraries that the adapter libraries use, so that the package
can be built with binutils-gold, where --no-add-needed is the default
(Closes: #555285). Also add -lglib-2.0 to the Libs: line in
liboop-glib2.pc (indirectly, via liboop-glib2.pc.in).
Checksums-Sha1:
1f3edbed60f0bb77d361df3e18cd1152fcf7c92c 1414 liboop_1.0-7.dsc
c9aa6fbf87814048aca525cc3f9f735f874d4181 17528 liboop_1.0.orig-html.tar.gz
9d25834fe8949117c96b2fc6f775ee43fc8d4b9d 7907 liboop_1.0-7.debian.tar.gz
5076b13cce3b314e8afe83739b1eec6ea6a16be3 22400 liboop-doc_1.0-7_all.deb
b5a19609ceaecb665e992fd45e3462dd6b39785c 27528 liboop4_1.0-7_amd64.deb
25c917ff211ee8e7aa9f5af03d97047d20dfff67 31622 liboop-dev_1.0-7_amd64.deb
59db7025c360c5b2eb9c781974cdeea359a15adc 43358 liboop-dbg_1.0-7_amd64.deb
Checksums-Sha256:
e51670235afcd33b8199864be97b514c1374492da404f62cad2be7ab130b5060 1414
liboop_1.0-7.dsc
bf953f0b0c46f4faa88f5fe4cae93c14ef063843409f2e21a7f27d16f5ad8882 17528
liboop_1.0.orig-html.tar.gz
c83c0d477aa6a321b6702bdfb11c2bcd65152903c4a2fce340ac07fd57913a51 7907
liboop_1.0-7.debian.tar.gz
e2e57fd5a92a2ef90bdc0635d340f050a9ce2a36cf6f08c6d29e1ee1745fff58 22400
liboop-doc_1.0-7_all.deb
1063181264d43aef85cbe0791453d55574067f81b4ff0f4d11e85d58af31c7f6 27528
liboop4_1.0-7_amd64.deb
24626e9c48d525d11c38caae747011af5055c0cd90e8fffa957ec86a5fef8521 31622
liboop-dev_1.0-7_amd64.deb
661c8b0839b98a878e3ca06efeed82e4887bec47b0a7616602e840353baff0b2 43358
liboop-dbg_1.0-7_amd64.deb
Files:
1173d8a128aab6467b79692b1899c92b 1414 libs optional liboop_1.0-7.dsc
f6fbdcc6a50ffd4c249eaac47af471cd 17528 libs optional
liboop_1.0.orig-html.tar.gz
515e5254e980017e607b94da04618257 7907 libs optional liboop_1.0-7.debian.tar.gz
7dfa513883330d4709d3bc8f8f20ea62 22400 doc optional liboop-doc_1.0-7_all.deb
9bb3dea8d760b52cad3732ced8f24e91 27528 libs optional liboop4_1.0-7_amd64.deb
8000b0af9d98f7c2f31c44f065cf8a47 31622 libdevel optional
liboop-dev_1.0-7_amd64.deb
f545f98fa70abf093c2db3e6edd62941 43358 debug extra liboop-dbg_1.0-7_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkxVoeAACgkQk7mRNn1h4+bN+ACfap2x/cxOS/EMkqgTMuZzWKvO
ssgAn1w+jMVj3RfcW59CI21yuRadVjnC
=HiJF
-----END PGP SIGNATURE-----
--- End Message ---
