Your message dated Wed, 20 Oct 2010 22:32:06 +0000
with message-id <[email protected]>
and subject line Bug#600445: fixed in libeatmydata 15-3
has caused the Debian Bug report #600445,
regarding eatmydata: FTBFS on kfreebsd-*: Illegal Instruction
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
600445: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=600445
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: eatmydata
Version: 15-1
Severity: important
User: [email protected]
Usertags: kfreebsd
Your package FTBFS on the kfreebsd architectures with an illegal
instruction¹. The reason can be seen in this GCC warning:
,----
| eatmydata.c: In function 'open':
| eatmydata.c:101: warning: 'mode_t' is promoted to 'int' when passed through
'...'
| eatmydata.c:101: note: (so you should pass 'int' not 'mode_t' to 'va_arg')
`----
On FreeBSD, mode_t is only 16 bits wide as opposed to 32 bits on Linux.
The following patch fixes this for me (tested on kfreebsd-i386 in qemu):
--8<---------------cut here---------------start------------->8---
diff --git a/eatmydata.c b/eatmydata.c
index 9bf0e46..1cb4d54 100644
--- a/eatmydata.c
+++ b/eatmydata.c
@@ -98,7 +98,10 @@ int open(const char* pathname, int flags, ...)
mode_t mode;
va_start(ap, flags);
- mode= va_arg(ap, mode_t);
+ if (sizeof (mode_t) < sizeof (int))
+ mode= va_arg(ap, int);
+ else
+ mode= va_arg(ap, mode_t);
va_end(ap);
/* In pthread environments the dlsym() may call our open(). */
--8<---------------cut here---------------end--------------->8---
Note that GCC will issue the (now bogus) warning, due to
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=4210.
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (101, 'experimental')
Architecture: i386 (x86_64)
Kernel: Linux 2.6.36-rc8-nouveau+ (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages eatmydata depends on:
ii libc6 2.11.2-6 Embedded GNU C Library: Shared lib
eatmydata recommends no packages.
eatmydata suggests no packages.
-- no debconf information
¹
https://buildd.debian.org/fetch.cgi?pkg=libeatmydata;ver=15-1;arch=kfreebsd-i386;stamp=1281282657
--- End Message ---
--- Begin Message ---
Source: libeatmydata
Source-Version: 15-3
We believe that the bug you reported is fixed in the latest version of
libeatmydata, which is due to be installed in the Debian FTP archive:
eatmydata_15-3_amd64.deb
to main/libe/libeatmydata/eatmydata_15-3_amd64.deb
libeatmydata_15-3.debian.tar.gz
to main/libe/libeatmydata/libeatmydata_15-3.debian.tar.gz
libeatmydata_15-3.dsc
to main/libe/libeatmydata/libeatmydata_15-3.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Modestas Vainius <[email protected]> (supplier of updated libeatmydata package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 21 Oct 2010 01:27:10 +0300
Source: libeatmydata
Binary: eatmydata
Architecture: source amd64
Version: 15-3
Distribution: unstable
Urgency: low
Maintainer: Modestas Vainius <[email protected]>
Changed-By: Modestas Vainius <[email protected]>
Description:
eatmydata - library and utilities designed to disable fsync and friends
Closes: 600445
Changes:
libeatmydata (15-3) unstable; urgency=low
.
* Fix a typo (made while refactoring) in the
upstream_handle_va_arg_promotion.diff patch. This should really solve a
FTBFS on kFreeBSD. (Closes: #600445)
Checksums-Sha1:
d3bb63f7f2bf0a33a4b5ac2dd8288b681fc7e73b 1191 libeatmydata_15-3.dsc
258db460f0952751b4a7367b90dc25d000e704b1 6449 libeatmydata_15-3.debian.tar.gz
725f1e6855512ab52e246e024c4f230aaff133e7 6724 eatmydata_15-3_amd64.deb
Checksums-Sha256:
2e1332872226ccd296a723976096ac0fe144f1deb4fcad24faefdfdc295a8dde 1191
libeatmydata_15-3.dsc
d47b1a6335544b3d3a40d074a949b0dd7a45d1aaacb50220b5f7e42d54dfa2fa 6449
libeatmydata_15-3.debian.tar.gz
4349235ee5552cbaff17cbbc82d78558eff420e817e965e5cbe2bd38e862d1e6 6724
eatmydata_15-3_amd64.deb
Files:
31a33f129d030624115009a8e0315229 1191 utils optional libeatmydata_15-3.dsc
e9f79a438bab993842d3db470afb3976 6449 utils optional
libeatmydata_15-3.debian.tar.gz
43045e3c94ea08d128084296de3e07a0 6724 utils optional eatmydata_15-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAky/bV4ACgkQHO9JRnPq4hT0MgCfRQVM2Xnz8QsrYDEnueiNKGyt
bqYAnRYNVYiOWGUQWMTpaBk4Tx4rN9zz
=cefr
-----END PGP SIGNATURE-----
--- End Message ---