Your message dated Sun, 13 Feb 2011 00:30:29 +0100
with message-id <[email protected]>
and subject line mon: monshow in cgi mode broken, dependencies on some alerts
broken, some alerts broken
has caused the Debian Bug report #182799,
regarding mon: monshow in cgi mode broken, dependencies on some alerts broken,
some alerts broken
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
182799: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=182799
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: mon
Version: 0.99.2-2
Severity: important
There are several problems with the package:
1. The moshow script does not parse CGI args correctly. Primary reason
is that the
author still uses medieval CGI arg parsing by hand instead of using CGI.pm. As
a result you
cannot run multiple mon instances on several machines and control them from one
CGI because
all args but passed to the CGI script are garbled. The attached diff fixes that.
2. The DNS alert depends on libnet:dns, the freespace alert depends on
the freespace modules,
ad naseum
3. The freespace alert is broken. It cannot handle any host args when
it gets them. Fix is
"bleeding obvious" so not quoted.
*** monshow.old Thu Feb 27 23:01:30 2003
--- monshow Thu Feb 27 23:00:53 2003
***************
*** 57,63 ****
my $VIEWPATH = "/etc/mon/monshow";
my %OPSTAT = %Mon::Client::OPSTAT;
! my $WORD = '[a-zA-Z0-9_-]+';
my $OUT_BUF = "";
my $e;
$= = 1000;
--- 57,63 ----
my $VIEWPATH = "/etc/mon/monshow";
my %OPSTAT = %Mon::Client::OPSTAT;
! my $WORD = '[,.a-zA-Z0-9_-]+';
my $OUT_BUF = "";
my $e;
$= = 1000;
***************
*** 100,113 ****
if ($CGI)
{
! foreach my $e (split (/\?/, $ENV{"QUERY_STRING"}))
! {
! next if ($e !~ /=/);
!
! my ($var, $val) = split (/=/, $e);
- $QUERY_ARGS{$var} = $val;
- }
}
my $CF = {
--- 100,124 ----
if ($CGI)
{
! # foreach my $e (split (/\?/, $ENV{"QUERY_STRING"}))
! # {
! # next if ($e !~ /=/);
! #
! # my ($var, $val) = split (/=/, $e);
! #
! # $QUERY_ARGS{$var} = $val;
! # }
! foreach my $un_clean_param ($CGI->param) {
! if($un_clean_param =~ /($WORD)/) {
! $un_clean_param = $1;
! };
! my $un_clean_value = $CGI->param($un_clean_param);
! if($un_clean_value =~ /($WORD)/) {
! $un_clean_value =$1;
! };
! $QUERY_ARGS{$un_clean_param} = $un_clean_value;
! }
}
my $CF = {
***************
*** 122,127 ****
--- 133,142 ----
"summary-len" => 20,
};
+ if ($QUERY_ARGS{'server'}) {
+ $CF->{'host'} = $QUERY_ARGS{'server'};
+ }
+
my $GLOBAL = {
"view-name" => undef,
};
***************
*** 1099,1105 ****
if ($sref->{"ack"})
{
if ($CGI) {
! $STATUS = "<a
href=\"$ENV{SCRIPT_NAME}?detail=$group,$service\">" .
"<b>ACK FAIL</b></a>";
} else {
$STATUS = "ACK FAIL";
--- 1114,1120 ----
if ($sref->{"ack"})
{
if ($CGI) {
! $STATUS = "<a
href=\"$ENV{SCRIPT_NAME}?detail=$group,$service&server=$CF->{'host'}\">" .
"<b>ACK FAIL</b></a>";
} else {
$STATUS = "ACK FAIL";
***************
*** 1190,1196 ****
<tr $bgcolor>
<td> $DEP </td>
<td> $GROUP </td>
! <td> <a href="$ENV{SCRIPT_NAME}?detail=$group,$service">$SERVICE</a> </td>
<td> <small>$DESC</small> </td>
<td> $TIME </td>
<td> $NEXT </td>
--- 1205,1211 ----
<tr $bgcolor>
<td> $DEP </td>
<td> $GROUP </td>
! <td> <a
href="$ENV{SCRIPT_NAME}?detail=$group,$service&server=$CF->{'host'}">$SERVICE</a>
</td>
<td> <small>$DESC</small> </td>
<td> $TIME </td>
<td> $NEXT </td>
-- System Information
Debian Release: 3.0
Kernel Version: Linux magrat 2.4.19 #1 SMP Tue Oct 8 15:28:01 UTC 2002 i686
unknown
Versions of the packages mon depends on:
ii libc6 2.2.5-11.2 GNU C Library: Shared libraries and Timezone
ii libmon-perl 0.11-2 mon Perl modules for clients and server
ii libtime-hires- 1.20-4 High-resolution time manipulation in perl
ii libtime-period 1.20-7 Perl library for testing if a time() is in a
ii perl 5.6.1-8.2 Larry Wall's Practical Extraction and Report
--- End Message ---
--- Begin Message ---
Hi,
Hereby I'm closing this bug since no reply was recived to my 'moreinfo' request.
Please, fell free to reopen it if you consider the bug still applies.
Regards,
--
Dario Minnucci <[email protected]>
Phone: +34 902021030 | Fax: +34 902024417
Key fingerprint = BAA1 7AAF B21D 6567 D457 D67D A82F BB83 F3D5 7033
signature.asc
Description: OpenPGP digital signature
--- End Message ---
