Your message dated Sat, 05 Mar 2011 01:57:26 +0000
with message-id <[email protected]>
and subject line Bug#612797: fixed in mcabber 0.10.0-1+squeeze1
has caused the Debian Bug report #612797,
regarding mcabber: Segmentation fault on status invisible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
612797: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612797
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: mcabber
Version: 0.10.0-1
Severity: normal
Tags: patch
MCabber 0.10.0 crashes after "/status invisible".
(Issue #56 in mcabber BTS)
Upstream fix available at: <http://mcabber.com/hg/index.cgi/rev/3695266e16c7>
-- System Information:
Debian Release: 6.0
# Author Mikael Berthe <[email protected]>
# Date 1273746408 -7200
Fix error presence packet handling -- they should not be processed as normal
messages.
This fixes the segfault reported by pbd in issue #56.
Index: mcabber-0.10.0/mcabber/utils.c
===================================================================
--- mcabber-0.10.0.orig/mcabber/utils.c 2011-02-10 20:45:59.000000000 +0100
+++ mcabber-0.10.0/mcabber/utils.c 2011-02-10 20:46:10.000000000 +0100
@@ -64,6 +64,12 @@
char *ptr;
char *alias;
+ if (!fjid) {
+ scr_LogPrint(LPRINT_LOGNORM, "** jidtodisp: NULL JID, "
+ "this is probably a bug, please report!");
+ return NULL;
+ }
+
alias = g_strdup(fjid);
if ((ptr = strchr(alias, JID_RESOURCE_SEPARATOR)) != NULL) {
Index: mcabber-0.10.0/mcabber/xmpp.c
===================================================================
--- mcabber-0.10.0.orig/mcabber/xmpp.c 2011-02-10 20:45:59.000000000 +0100
+++ mcabber-0.10.0/mcabber/xmpp.c 2011-02-10 20:46:10.000000000 +0100
@@ -1335,13 +1335,23 @@
char bpprio;
time_t timestamp = 0L;
LmMessageNode *muc_packet, *caps;
- LmMessageSubType mstype;
+ LmMessageSubType mstype = lm_message_get_sub_type(m);
// Check for MUC presence packet
muc_packet = lm_message_node_find_xmlns
(m->node, "http://jabber.org/protocol/muc#user";);
from = lm_message_get_from(m);
+ if (!from) {
+ scr_LogPrint(LPRINT_LOGNORM, "Unexpected presence packet!");
+
+ if (mstype == LM_MESSAGE_SUB_TYPE_ERROR) {
+ display_server_error(lm_message_node_get_child(m->node, "error"),
+ lm_message_get_from(m));
+ return LM_HANDLER_RESULT_REMOVE_MESSAGE;
+ }
+ return LM_HANDLER_RESULT_ALLOW_MORE_HANDLERS;
+ }
rname = strchr(from, JID_RESOURCE_SEPARATOR);
if (rname) rname++;
@@ -1354,7 +1364,6 @@
}
bjid = jidtodisp(from);
- mstype = lm_message_get_sub_type(m);
if (mstype == LM_MESSAGE_SUB_TYPE_ERROR) {
LmMessageNode *x;
@@ -1505,12 +1514,21 @@
char *buf;
int newbuddy;
const char *from = lm_message_get_from(m);
- LmMessageSubType mstype;
+ LmMessageSubType mstype = lm_message_get_sub_type(m);
+
+ if (mstype == LM_MESSAGE_SUB_TYPE_ERROR) {
+ display_server_error(lm_message_node_get_child(m->node, "error"),
+ lm_message_get_from(m));
+ return LM_HANDLER_RESULT_REMOVE_MESSAGE;
+ }
+ if (!from) {
+ scr_LogPrint(LPRINT_DEBUG, "handle_s10n: Unexpected presence packet!");
+ return LM_HANDLER_RESULT_ALLOW_MORE_HANDLERS;
+ }
r = jidtodisp(from);
newbuddy = !roster_find(r, jidsearch, 0);
- mstype = lm_message_get_sub_type(m);
if (mstype == LM_MESSAGE_SUB_TYPE_SUBSCRIBE) {
/* The sender wishes to subscribe to our presence */
--- End Message ---
--- Begin Message ---
Source: mcabber
Source-Version: 0.10.0-1+squeeze1
We believe that the bug you reported is fixed in the latest version of
mcabber, which is due to be installed in the Debian FTP archive:
mcabber_0.10.0-1+squeeze1.diff.gz
to main/m/mcabber/mcabber_0.10.0-1+squeeze1.diff.gz
mcabber_0.10.0-1+squeeze1.dsc
to main/m/mcabber/mcabber_0.10.0-1+squeeze1.dsc
mcabber_0.10.0-1+squeeze1_i386.deb
to main/m/mcabber/mcabber_0.10.0-1+squeeze1_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gerfried Fuchs <[email protected]> (supplier of updated mcabber package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 04 Mar 2011 20:06:56 +0100
Source: mcabber
Binary: mcabber
Architecture: source i386
Version: 0.10.0-1+squeeze1
Distribution: squeeze
Urgency: medium
Maintainer: Mario Iseli <[email protected]>
Changed-By: Gerfried Fuchs <[email protected]>
Description:
mcabber - small Jabber (XMPP) console client
Closes: 612789 612797 612798 612799
Changes:
mcabber (0.10.0-1+squeeze1) squeeze; urgency=medium
.
* Pull upstream commit 3695266e16c7 to fix crash after /status invisible
(closes: #612797)
* Pull upstream commit e09763e16e49 to fix segfault related to url_regex
(closes: #612798)
* Pull upstream commit 75a0a22bbf78 to fix commandline corruption
(closes: #612789)
* Pull upstream commit ee8657ff9aa8 to fix two FD leaks
(closes: #612799)
Checksums-Sha1:
5a530ca195d7eee57595228d478dec6f90839d3e 1508 mcabber_0.10.0-1+squeeze1.dsc
d9eed69e6680c3f0cb0667556ddbd4edc1dba018 5269 mcabber_0.10.0-1+squeeze1.diff.gz
71807dae365f3985c3c7a2377ba4713003840abe 269566
mcabber_0.10.0-1+squeeze1_i386.deb
Checksums-Sha256:
5f2c9cb68eb954274f690c5ceaf02e7d1faa5ca0eeb811b742f4a123dc3e265a 1508
mcabber_0.10.0-1+squeeze1.dsc
8847dae147971206f1dcb7d40c4141da575b394ee905b9e0bf85cf31a4afca70 5269
mcabber_0.10.0-1+squeeze1.diff.gz
28565903e96928be8b9cf8077e0480fe3e754b1fa48e94bf245585d88f36e48c 269566
mcabber_0.10.0-1+squeeze1_i386.deb
Files:
acb6a54ddcd62078e549026fef53baab 1508 net optional
mcabber_0.10.0-1+squeeze1.dsc
59336d0ca4e9bc6558cc7ef510b6327b 5269 net optional
mcabber_0.10.0-1+squeeze1.diff.gz
c9b632de6ea947661b298569f0cec98e 269566 net optional
mcabber_0.10.0-1+squeeze1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQEcBAEBCAAGBQJNcUoDAAoJEDH85+fdB5RhYAcIALUjmEamUHTBSuW0Wyukh3fe
1MzZH86nOCMjp0JEvyjzF9mFd8NQmBcrLl/CsW4DLM5/I3XymvA4bofvQU5xx0VP
e+xMzo+TAjnv43qKlOY35nnfhs2bGqd5LsOjYE8nZjP8h/8bSr4dEoi/yFq6wCDJ
K8D33cYrv7nDhyQ58WLbPjgHcl+X9bsdy4c2vwbkZ/18EIDIgWT6tzQ4mbdM5V09
RaelFj/u47AxbWs/p+55mXVnbw1WvMTJ2NG/KaBRK/Y4CqzocLYaTgqpcx4lStoa
w9espDn47YqU/9xdTmnbmJ+98/J9SrsADGIcnhRTA+wnXndTLNMErP9VX0Lvzb8=
=lX/2
-----END PGP SIGNATURE-----
--- End Message ---
