Your message dated Sat, 05 Mar 2011 12:49:05 +0000 with message-id <[email protected]> and subject line Bug#504678: fixed in multipath-tools 0.4.9-2 has caused the Debian Bug report #504678, regarding add -r to make resulting devices read/only to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 504678: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504678 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: kpartx Version: 0.4.8-13 Severity: wishlist Tags: patch I'd like to have the ability to create targets in which are read-only to keep from accidentally modifying the newly created device. In some cases, mounting with -o ro still modifies the device (in the case of ext3 filesystems). I created a small patch that will do this. I have tested it only to the point that using -a with or without -r produces the desired effects. -- System Information: Debian Release: 3.1 APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.24.5 Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Versions of packages kpartx depends on: ii dmsetup 2:1.02.27-4 The Linux Kernel Device Mapper use ii libc6 2.7-5 GNU C Library: Shared libraries ii libdevmapper1.02.1 2:1.02.27-4 The Linux Kernel Device Mapper use kpartx recommends no packages. -- no debconf informationdiff -ruN multipath-tools-0.4.8-orig/kpartx/devmapper.c multipath-tools-0.4.8/kpartx/devmapper.c --- multipath-tools-0.4.8-orig/kpartx/devmapper.c 2007-08-02 17:05:37.000000000 -0400 +++ multipath-tools-0.4.8/kpartx/devmapper.c 2008-11-05 21:32:51.000000000 -0500 @@ -72,7 +72,7 @@ extern int dm_addmap (int task, const char *name, const char *target, - const char *params, unsigned long size, const char *uuid, int part) { + const char *params, unsigned long size, int ro, const char *uuid, int part) { int r = 0; struct dm_task *dmt; char *prefixed_uuid; @@ -86,6 +86,9 @@ if (!dm_task_add_target (dmt, 0, size, target, params)) goto addout; + if (ro && !dm_task_set_ro (dmt)) + goto addout; + if (task == DM_DEVICE_CREATE && uuid) { prefixed_uuid = malloc(MAX_PREFIX_LEN + strlen(uuid) + 1); if (!prefixed_uuid) { diff -ruN multipath-tools-0.4.8-orig/kpartx/devmapper.h multipath-tools-0.4.8/kpartx/devmapper.h --- multipath-tools-0.4.8-orig/kpartx/devmapper.h 2007-08-02 17:05:37.000000000 -0400 +++ multipath-tools-0.4.8/kpartx/devmapper.h 2008-11-05 21:36:05.000000000 -0500 @@ -1,7 +1,7 @@ int dm_prereq (char *, int, int, int); int dm_simplecmd (int, const char *); int dm_addmap (int, const char *, const char *, const char *, unsigned long, - char *, int); + int, char *, int); int dm_map_present (char *); char * dm_mapname(int major, int minor); dev_t dm_get_first_dep(char *devname); diff -ruN multipath-tools-0.4.8-orig/kpartx/kpartx.c multipath-tools-0.4.8/kpartx/kpartx.c --- multipath-tools-0.4.8-orig/kpartx/kpartx.c 2007-08-02 17:05:37.000000000 -0400 +++ multipath-tools-0.4.8/kpartx/kpartx.c 2008-11-05 21:38:59.000000000 -0500 @@ -82,7 +82,7 @@ addpts("sun", read_sun_pt); } -static char short_opts[] = "ladgvnp:t:"; +static char short_opts[] = "rladgvnp:t:"; /* Used in gpt.c */ int force_gpt=0; @@ -91,6 +91,7 @@ usage(void) { printf("usage : kpartx [-a|-d|-l] [-v] wholedisk\n"); printf("\t-a add partition devmappings\n"); + printf("\t-r devmappings will be readonly\n"); printf("\t-d del partition devmappings\n"); printf("\t-l list partitions devmappings that would be added by -a\n"); printf("\t-p set device name-partition number delimiter\n"); @@ -183,7 +184,7 @@ int main(int argc, char **argv){ - int fd, i, j, m, n, op, off, arg, c, d; + int fd, i, j, m, n, op, off, arg, c, d, ro=0; struct slice all; struct pt *ptp; enum action what = LIST; @@ -230,6 +231,9 @@ } while ((arg = getopt(argc, argv, short_opts)) != EOF) switch(arg) { + case 'r': + ro=1; + break; case 'g': force_gpt=1; break; @@ -458,7 +462,7 @@ DM_DEVICE_RELOAD : DM_DEVICE_CREATE); dm_addmap(op, partname, DM_TARGET, params, - slices[j].size, uuid, j+1); + slices[j].size, ro, uuid, j+1); if (op == DM_DEVICE_RELOAD) dm_simplecmd(DM_DEVICE_RESUME, @@ -514,7 +518,7 @@ DM_DEVICE_RELOAD : DM_DEVICE_CREATE); dm_addmap(op, partname, DM_TARGET, params, - slices[j].size, uuid, j+1); + slices[j].size, ro, uuid, j+1); if (op == DM_DEVICE_RELOAD) dm_simplecmd(DM_DEVICE_RESUME,
--- End Message ---
--- Begin Message ---Source: multipath-tools Source-Version: 0.4.9-2 We believe that the bug you reported is fixed in the latest version of multipath-tools, which is due to be installed in the Debian FTP archive: kpartx_0.4.9-2_amd64.deb to main/m/multipath-tools/kpartx_0.4.9-2_amd64.deb multipath-tools-boot_0.4.9-2_all.deb to main/m/multipath-tools/multipath-tools-boot_0.4.9-2_all.deb multipath-tools-dbg_0.4.9-2_amd64.deb to main/m/multipath-tools/multipath-tools-dbg_0.4.9-2_amd64.deb multipath-tools_0.4.9-2.debian.tar.gz to main/m/multipath-tools/multipath-tools_0.4.9-2.debian.tar.gz multipath-tools_0.4.9-2.dsc to main/m/multipath-tools/multipath-tools_0.4.9-2.dsc multipath-tools_0.4.9-2_amd64.deb to main/m/multipath-tools/multipath-tools_0.4.9-2_amd64.deb multipath-udeb_0.4.9-2_amd64.udeb to main/m/multipath-tools/multipath-udeb_0.4.9-2_amd64.udeb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Ritesh Raj Sarraf <[email protected]> (supplier of updated multipath-tools package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sat, 05 Mar 2011 03:22:32 +0530 Source: multipath-tools Binary: multipath-tools multipath-tools-dbg kpartx multipath-tools-boot multipath-udeb Architecture: source amd64 all Version: 0.4.9-2 Distribution: unstable Urgency: low Maintainer: Debian LVM Team <[email protected]> Changed-By: Ritesh Raj Sarraf <[email protected]> Description: kpartx - create device mappings for partitions multipath-tools - maintain multipath block device access multipath-tools-boot - Support booting from multipath devices multipath-tools-dbg - maintain multipath block device access - debugging symbols multipath-udeb - maintain multipath block device access - udeb package (udeb) Closes: 504678 607911 609068 Changes: multipath-tools (0.4.9-2) unstable; urgency=low . * [2544655] wait harder for multipath init. Thanks to Serge Hallyn for the patch * [eb87e52] switch to 3.0 quilt source format * [e55a306] explictly mention license copyright * [52db82f] update vcs headers * [8313f77] with dpkg > 1.15.7 we now don't need XC * [8fdf077] update short description for multipath udeb package * [c409ef3] add misc:Depends for multipath-udeb * [c890181] take maintenance of package (Closes: #607911) * [09bbbc8] add debugging symbols package. Thanks to Craig Magina. (Closes: #609068) * [2e6f8a7] spelling/hyphen fixes * [97e02e7] add manpage for read-only mappings * [5419352] add-r-to-make-resulting-device-read-only. Thanks to Wakko Warner for the patch (Closes: #504678) Checksums-Sha1: fc5c22086a113fb458e2af575143e5c8c4683bec 2102 multipath-tools_0.4.9-2.dsc c6619f4c659b283cd045e5df0e3d993bb1cead75 25414 multipath-tools_0.4.9-2.debian.tar.gz 6746a4b79139c53fe01f1653e33d8bb41e6f21df 175440 multipath-tools_0.4.9-2_amd64.deb 38adce8ba17d9300044c878890b0c5222ee9ed14 223124 multipath-tools-dbg_0.4.9-2_amd64.deb 0e085e560eb7b1678bbd661f39230c242bc17145 30322 kpartx_0.4.9-2_amd64.deb f71848b6ee38fbe23ad2d0406a7aa4784c677cfa 14446 multipath-tools-boot_0.4.9-2_all.deb f1fd9c7a4a37e0bdb94ba8b2118635dfebb527c6 140074 multipath-udeb_0.4.9-2_amd64.udeb Checksums-Sha256: cbc1423fd4031f3a75c674cee6cbb289d256389430c0d61a9d28a47452197fea 2102 multipath-tools_0.4.9-2.dsc 750c6de0355d65f5ed0b13bdf39886b90d86d15b38b1504959ae893cc21f4993 25414 multipath-tools_0.4.9-2.debian.tar.gz 3e83862005af57052b22731f7f54faf2cf76134bb263cd50d5bb00777e457814 175440 multipath-tools_0.4.9-2_amd64.deb d0c17d7c691f00a6c06645fd24937d753cb22781fcb979f5e9f0d350dd989b83 223124 multipath-tools-dbg_0.4.9-2_amd64.deb b84fbd84de3220f8d82d02f655b54c4e8b6909551b41fdbd3c915525ee084aee 30322 kpartx_0.4.9-2_amd64.deb a9331185fa29dcfd575c59facfee719b93b68152d9d88dd744301662986bd2ad 14446 multipath-tools-boot_0.4.9-2_all.deb 273c09cca73ad440d258be040b402170cc5c5481848c3580f4ac975510a76d46 140074 multipath-udeb_0.4.9-2_amd64.udeb Files: e21c4bfdeda0d62fecc3e8c507a2346f 2102 admin extra multipath-tools_0.4.9-2.dsc abc6a7bb2193ab4b718f34b3de076dcb 25414 admin extra multipath-tools_0.4.9-2.debian.tar.gz 70881c9c2402cfab1d1003cb4cb1d4ce 175440 admin extra multipath-tools_0.4.9-2_amd64.deb b1c83e547ec4f01100ab920029a330d7 223124 debug extra multipath-tools-dbg_0.4.9-2_amd64.deb 9c3b0523bbadfe805f40485bb6454716 30322 admin extra kpartx_0.4.9-2_amd64.deb c278b12a206f55ce2ca0bca5983c32ad 14446 admin extra multipath-tools-boot_0.4.9-2_all.deb 29866d30b29c773a52f4479d69e7cb5d 140074 debian-installer extra multipath-udeb_0.4.9-2_amd64.udeb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCgAGBQJNcWIsAAoJEKY6WKPy4XVphlYP/RsDocNbOZSLWqN53v9QwFyR vHvb6rRBBQgXtia+c4/sZ31hLCvy711e1RotsCLwgHcSM2uT2qGl7UhQg2nyLylk VYz6Rqi8PyxTZ0MPjhWjz+ds8Aigw/iXWUi+zq3MqqR+2ty08OqsdWc4WjPGiAZA SKBM/M32vAFR3wNc3Wh46ITjdLicoJBk27cWEXcus3rx9cGLTYTzr3WwzGAOI9RU kNsPeN+Y4eH/YJ8w6isyUzkYhkjA/2uBbLW6e9YPYOPjN9J3WFhIYtrPQk2dtEJz lWWgnWM3RFRKu0C7VlCdtDZrUd2H4glRb6wa6eCof6PbMMjMPyxHVLk/rytI5ym8 q3p2dLhEZ7jVmXf9O7qSc4zr+f41M9k5DmKVoQSiktnJv8+i7sZzlYuo+1zCvvsF w6UI8aoIcBq9PamwFTDnA7TzillTWW7ChCdSkdwA9TUa8wgBojiSvBKkHLFjA9QV MSNrrGsWbtBIWU15zJ8jiAqZFgx1ZyDpGNMnzIEcFnzVoRBAHSz/nCHYIc/dgJTL WL8r5OIAvEO4zKCfFqAxQG4ZqU8Isc30OWuo9kNocPu2RTXgOMZRrgESd//vXlAj 1/1alhV/mwt2c8N+7WK1MpEJzQcn+p53CPGYM8M320ff2olGXaBTUGZVG8a/ICDN tDYcrV1f+u0FA3DX7XNl =PG5v -----END PGP SIGNATURE-----
--- End Message ---
