Your message dated Sat, 02 Apr 2011 16:17:20 +0000
with message-id <[email protected]>
and subject line Bug#586009: fixed in cifs-utils 2:4.9-1
has caused the Debian Bug report #586009,
regarding mount.cifs appends trailing slash to share name in mtab
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
586009: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=586009
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libpam-mount
Version: 2.5-3
Severity: important
Tags: upstream patch

Hi,

After migrating to squeeze I've been having difficulties with
libpam-mount. One of them is that it fails to detect the already mounted
cifs setups, so the cifs entries get mounted on each authentication.

Tracking the problem I found that the newer the mount.cifs adds a trailing /
to the device part in /etc/mtab and /proc/mounts. So, what use to be
//samba/share now becomes //samba/share/. Which makes the check made by
libpam-mount to fail.

So, I made a quick fix in libpam-mount, that removes the trailing slash
whenever its processing the mtab and mounts lines.

Which is something like this:

--- libpam-mount-2.5/src/mtab.c 2010-09-14 13:29:21.000000000 -0300
+++ libpam-mount-2.5.remove_trailing_slash/src/mtab.c   2010-09-14 
12:58:23.000000000 -0300
@@ -222,6 +222,8 @@
                        ;
                for (p = q; !HX_isspace(*p) && *p != '\0'; ++p)
                        ;
+               /* newer mount.cifs adds a hanging '/' at the end, messing up 
with the check */
+               if ((i == 0) && (p > line+1) && (*(p-1) == '/')) *(p-1) = '\0';
                *p++ = '\0';
                field[i] = mt_unescape(q);
        }

Thanks,

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing-proposed-updates
  APT policy: (500, 'testing-proposed-updates'), (500, 'proposed-updates'), 
(500, 'testing'), (500, 'stable')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libpam-mount depends on:
ii  libc6                       2.11.2-2     Embedded GNU C Library: Shared lib
ii  libcryptsetup1              2:1.1.3-3    libcryptsetup shared library
ii  libhx25                     3.5-2        A library providing queue, tree, I
ii  libpam-runtime              1.1.1-4      Runtime support for the PAM librar
ii  libpam0g                    1.1.1-4      Pluggable Authentication Modules l
ii  libssl0.9.8                 0.9.8o-2     SSL shared libraries
ii  libxml2                     2.7.7.dfsg-4 GNOME XML library
ii  mount                       2.17.2-3.1   Tools for mounting and manipulatin

libpam-mount recommends no packages.

Versions of packages libpam-mount suggests:
pn  davfs2                     <none>        (no description available)
ii  fuse-utils                 2.8.1-1.2     Filesystem in USErspace (utilities
ii  lsof                       4.81.dfsg.1-1 List open files
pn  ncpfs                      <none>        (no description available)
ii  openssl                    0.9.8o-2      Secure Socket Layer (SSL) binary a
ii  psmisc                     22.11-1       utilities that use the proc file s
ii  smbfs                      2:4.5-2       Common Internet File System utilit
ii  sshfs                      2.2-1         filesystem client based on SSH Fil
pn  tc-utils                   <none>        (no description available)
pn  xfsprogs                   <none>        (no description available)

-- Configuration Files:
/etc/pam.d/common-pammount changed [not included]
/etc/security/pam_mount.conf.xml changed [not included]

-- debconf information excluded
--- libpam-mount-2.5/src/mtab.c	2010-09-14 13:29:21.000000000 -0300
+++ libpam-mount-2.5.remove_trailing_slash/src/mtab.c	2010-09-14 12:58:23.000000000 -0300
@@ -222,6 +222,8 @@
 			;
 		for (p = q; !HX_isspace(*p) && *p != '\0'; ++p)
 			;
+		/* newer mount.cifs adds a hanging '/' at the end, messing up with the check */
+		if ((i == 0) && (p > line+1) && (*(p-1) == '/')) *(p-1) = '\0';
 		*p++ = '\0';
 		field[i] = mt_unescape(q);
 	}

--- End Message ---
--- Begin Message ---
Source: cifs-utils
Source-Version: 2:4.9-1

We believe that the bug you reported is fixed in the latest version of
cifs-utils, which is due to be installed in the Debian FTP archive:

cifs-utils_4.9-1.debian.tar.gz
  to main/c/cifs-utils/cifs-utils_4.9-1.debian.tar.gz
cifs-utils_4.9-1.dsc
  to main/c/cifs-utils/cifs-utils_4.9-1.dsc
cifs-utils_4.9-1_i386.deb
  to main/c/cifs-utils/cifs-utils_4.9-1_i386.deb
cifs-utils_4.9.orig.tar.bz2
  to main/c/cifs-utils/cifs-utils_4.9.orig.tar.bz2
smbfs_4.9-1_i386.deb
  to main/c/cifs-utils/smbfs_4.9-1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luk Claes <[email protected]> (supplier of updated cifs-utils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 02 Apr 2011 17:10:35 +0200
Source: cifs-utils
Binary: cifs-utils smbfs
Architecture: source i386
Version: 2:4.9-1
Distribution: unstable
Urgency: low
Maintainer: Debian Samba Maintainers <[email protected]>
Changed-By: Luk Claes <[email protected]>
Description: 
 cifs-utils - Common Internet File System utilities
 smbfs      - Common Internet File System utilities - compatibility package
Closes: 504690 583508 586009 589218 600788 603094 615211
Changes: 
 cifs-utils (2:4.9-1) unstable; urgency=low
 .
   [ Luk Claes ]
   * Add Recommends to keyutils so following DFS links works out of the
     box.  Closes: #504690.
   * Install README.  Closes: #603094.
   * Add --without-libcap to dh_auto_configure.  Closes: #615211.
 .
   [ Steve Langasek ]
   * New upstream release.  Closes: #600788.
     - mount.cifs: use original device name as-is for mtab.
       Closes: #586009, #583508, #589218.
Checksums-Sha1: 
 d4f6ede732f2f3f98056ac55b4565baca6a13c7a 1466 cifs-utils_4.9-1.dsc
 0a530f6ce5ea6c05e278cc05927c20f992c95d39 323980 cifs-utils_4.9.orig.tar.bz2
 4dbfeeb6cd33e0cf37ab7d27fbeb52f0f4d13d73 4685 cifs-utils_4.9-1.debian.tar.gz
 58492eb9be851142f640ba841bc6ab32390b7645 40874 cifs-utils_4.9-1_i386.deb
 baddc16d058091d169c68e06d5cd5fff28fedce6 4650 smbfs_4.9-1_i386.deb
Checksums-Sha256: 
 55117692980cdbb64a7723cfa088bce4c94dfaa1de912eb991edef572d9a31ed 1466 
cifs-utils_4.9-1.dsc
 4a3410a598a13d71421d4d78027ca507a63ea32eec0892eb78e4f3aec2e335af 323980 
cifs-utils_4.9.orig.tar.bz2
 fabae089902e1066d3e3e337db23a630ca5ab51e83851aec4dce2d6aa542870a 4685 
cifs-utils_4.9-1.debian.tar.gz
 a8f6502170e957bb263dd1fe3841d6b1574bee3f52618be828b232f1b4e00438 40874 
cifs-utils_4.9-1_i386.deb
 feddb6f9017f9e836b7b11238fb3dad7a73222c194c305019384c685e0687da3 4650 
smbfs_4.9-1_i386.deb
Files: 
 b14953a1c665b933506b5170ad8e462e 1466 otherosfs optional cifs-utils_4.9-1.dsc
 908d904e6b9e58f09f530de151a88ef8 323980 otherosfs optional 
cifs-utils_4.9.orig.tar.bz2
 e8cea4daf36e9ecc26a6232831faae08 4685 otherosfs optional 
cifs-utils_4.9-1.debian.tar.gz
 00de4af4d6ca927ff6e1e93e39d0980e 40874 otherosfs optional 
cifs-utils_4.9-1_i386.deb
 bac1ca7663418b34ab49d36de2b20246 4650 otherosfs optional smbfs_4.9-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk2XRNoACgkQ5UTeB5t8Mo3dhwCgjEuUfrPuJutF21eJFePVCzMu
EwUAniRXGhyfGtcIgO3tk7VJjHGlfGAu
=9HoM
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to