Your message dated Fri, 15 Apr 2011 09:18:08 +0000
with message-id <[email protected]>
and subject line Bug#619997: fixed in python-debian 0.1.19
has caused the Debian Bug report #619997,
regarding python-debian: BaseVersion is not strict enough
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
619997: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=619997
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python-debian
Version: 0.1.17~bzr184~launchpad1
Severity: normal
Tags: patch

Hi,

    The BaseVersion class in debian_support contains an re_valid_version
regular expression. It isn't quite strict enough, to quote from Policy
5.6.12: "if there is no epoch then colons are not allowed.".

    Find attached a patch that corrects that.

-- System Information:
Debian Release: squeeze/sid
  APT prefers maverick-updates
  APT policy: (500, 'maverick-updates'), (500, 'maverick-security'), (500, 
'maverick')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.35-25-generic (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages python-debian depends on:
ii  python                    2.6.6-2ubuntu2 interactive high-level object-orie
ii  python-support            1.0.9ubuntu1   automated rebuilding support for P

Versions of packages python-debian recommends:
ii  python-apt            0.7.96.1ubuntu11.1 Python interface to libapt-pkg

Versions of packages python-debian suggests:
ii  gpgv                     1.4.10-2ubuntu2 GNU privacy guard - signature veri

-- no debconf information
=== modified file 'lib/debian/debian_support.py'
--- lib/debian/debian_support.py        2010-03-14 11:37:42 +0000
+++ lib/debian/debian_support.py        2011-03-29 00:55:46 +0000
@@ -94,6 +94,12 @@
         m = self.re_valid_version.match(version)
         if not m:
             raise ValueError("Invalid version string %r" % version)
+        # If there no epoch ("1:..."), then the upstream version can not
+        # contain a :.
+        if (
+            m.group("epoch") is None and 
+            m.group("upstream_version").find(':') != -1): 
+            raise ValueError("Invalid version string %r" % version)
 
         self.__full_version = version
         self.__epoch = m.group("epoch")

=== modified file 'tests/test_changelog.py'
--- tests/test_changelog.py     2010-03-14 09:16:30 +0000
+++ tests/test_changelog.py     2011-03-28 07:51:38 +0000
@@ -202,6 +202,8 @@
         self._test_version('2:1.0.4+svn26-1ubuntu1', '2', '1.0.4+svn26',
                            '1ubuntu1')
         self._test_version('2:1.0.4~rc2-1', '2', '1.0.4~rc2', '1')
+        self.assertRaises(
+            ValueError, changelog.Version, 'a1:1.8.8-070403-1~priv1')
 
     def test_version_updating(self):
         v = changelog.Version('1:1.4.1-1')


--- End Message ---
--- Begin Message ---
Source: python-debian
Source-Version: 0.1.19

We believe that the bug you reported is fixed in the latest version of
python-debian, which is due to be installed in the Debian FTP archive:

python-debian_0.1.19.dsc
  to main/p/python-debian/python-debian_0.1.19.dsc
python-debian_0.1.19.tar.gz
  to main/p/python-debian/python-debian_0.1.19.tar.gz
python-debian_0.1.19_all.deb
  to main/p/python-debian/python-debian_0.1.19_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
John Wright <[email protected]> (supplier of updated python-debian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 15 Apr 2011 02:05:45 -0700
Source: python-debian
Binary: python-debian
Architecture: source all
Version: 0.1.19
Distribution: unstable
Urgency: low
Maintainer: Debian python-debian Maintainers 
<[email protected]>
Changed-By: John Wright <[email protected]>
Description: 
 python-debian - Python modules to work with Debian-related data formats
Closes: 604544 619997
Changes: 
 python-debian (0.1.19) unstable; urgency=low
 .
   * debian_support.BaseVersion: Disallow ':' in upstream version if
     there is no epoch.  Original patch by Steve Kowalik.
     (Closes: #619997)
 .
 python-debian (0.1.18+nmu1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Migrate to new python-apt API (Closes: #604544)
Checksums-Sha1: 
 3bbf63572df7e28a77e61f28e321118fcd0b50ff 1258 python-debian_0.1.19.dsc
 b75cfb2cae29c6c3a6a44aff290e8de4ed818bb9 183422 python-debian_0.1.19.tar.gz
 40af651c8635ec7163072e84313e3768c4b07a32 59076 python-debian_0.1.19_all.deb
Checksums-Sha256: 
 fcd7b613f46082b59a2104292bb0b839cbb9c35d83cd187ffd05142caeee626c 1258 
python-debian_0.1.19.dsc
 f2f5712363ff4269ae91443798a4bfd076410668a90374df33b71b8f0dfc0051 183422 
python-debian_0.1.19.tar.gz
 eb13c3c1e35848ea03db33ebe7a583dd52a3de63bf87e770b687755e59071297 59076 
python-debian_0.1.19_all.deb
Files: 
 5fe45ca075ccdbf3be7ce0bd9c4b1b5b 1258 python optional python-debian_0.1.19.dsc
 19a47147940180fabd61a330c23a0bfd 183422 python optional 
python-debian_0.1.19.tar.gz
 31572084135b4165e5cfa0ef0fd015b2 59076 python optional 
python-debian_0.1.19_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk2oCsUACgkQ0UIZh3p4ZWHVhwCfe44qqbhORVFZiU4eV1l+1Agc
S9UAoIeUw1aIpgnLy5GmiN6ol/9gb/gT
=5Fes
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to