Your message dated Thu, 28 Apr 2011 18:17:11 +0000
with message-id <[email protected]>
and subject line Bug#624474: fixed in accountsservice 0.6.9-2
has caused the Debian Bug report #624474,
regarding Use a different session type filter for recent users
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
624474: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=624474
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: accountsservice
Version: 0.6.9-1
Severity: wishlist

Hi,

the ck_history code, having been moved from GDM to accountsservice,
comes with the bugs it already had.

The ConsoleKit session type parameter is not clearly defined upstream.
AFAIK, its sole user is GDM. For the login session, which is not a real
session, it sets the type to 'LoginWindow'. For regular sessions, it
sets the type to '' (the default), so this is the same as TTY or SSH
connections.

GDM then uses this database to generate a list of frequent users. But
the way it is written, it accounts for all users, including those that
might never log with X11, such as a remote user or a sysadmin. It is
very wrong to display all of them.

In squeeze, this was fixed by making GDM use 'gdm' as session type for
regular sessions. However, since this code has been moved to
accountsservice, this doesn’t work at all anymore. Furthermore, the API
doesn’t allow to query the history for a specific session type.

Therefore I’m proposing to fix it differently: 
      * have accountsservice filter by 'x11' session type; 
      * make GDM use that 'x11' session type instead of 'gdm'; 
      * request other display managers (such as slim or kdm) to use the
        same session type.
This way I feel we have a double-win: users are filtered correctly, and
they still are regardless of the login manager.

I’m attaching the needed change in accountsservice. Without another
solution, I consider it as a prerequisite to uploading gdm3 3.x.

Thanks,
-- 
 .''`.      Josselin Mouette
: :' :
`. `'  “If you behave this way because you are blackmailed by someone,
  `-    […] I will see what I can do for you.”  -- Jörg Schilling

Index: accountsservice/src/daemon.c
===================================================================
--- accountsservice.orig/src/daemon.c	2011-04-28 19:12:31.452838301 +0200
+++ accountsservice/src/daemon.c	2011-04-28 19:14:46.413498112 +0200
@@ -418,7 +418,7 @@ reload_ck_history (Daemon *daemon)
         gint standard_out;
         GIOChannel *channel;
 
-        command = g_strdup ("ck-history --frequent --session-type=''");
+        command = g_strdup ("ck-history --frequent --session-type='x11'");
         g_debug ("running '%s'", command);
         error = NULL;
         if (! g_shell_parse_argv (command, NULL, &argv, &error)) {

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message ---
Source: accountsservice
Source-Version: 0.6.9-2

We believe that the bug you reported is fixed in the latest version of
accountsservice, which is due to be installed in the Debian FTP archive:

accountsservice_0.6.9-2.debian.tar.gz
  to main/a/accountsservice/accountsservice_0.6.9-2.debian.tar.gz
accountsservice_0.6.9-2.dsc
  to main/a/accountsservice/accountsservice_0.6.9-2.dsc
accountsservice_0.6.9-2_amd64.deb
  to main/a/accountsservice/accountsservice_0.6.9-2_amd64.deb
gir1.2-accountservice-1.0_0.6.9-2_amd64.deb
  to main/a/accountsservice/gir1.2-accountservice-1.0_0.6.9-2_amd64.deb
libaccountsservice-dev_0.6.9-2_amd64.deb
  to main/a/accountsservice/libaccountsservice-dev_0.6.9-2_amd64.deb
libaccountsservice0_0.6.9-2_amd64.deb
  to main/a/accountsservice/libaccountsservice0_0.6.9-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alessio Treglia <[email protected]> (supplier of updated accountsservice 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 28 Apr 2011 20:03:07 +0200
Source: accountsservice
Binary: accountsservice libaccountsservice0 libaccountsservice-dev 
gir1.2-accountservice-1.0
Architecture: source amd64
Version: 0.6.9-2
Distribution: unstable
Urgency: low
Maintainer: Alessio Treglia <[email protected]>
Changed-By: Alessio Treglia <[email protected]>
Description: 
 accountsservice - query and manipulate user account information
 gir1.2-accountservice-1.0 - GObject introspection data for AccountService
 libaccountsservice-dev - query and manipulate user account information - 
header files
 libaccountsservice0 - query and manipulate user account information - shared 
libraries
Closes: 624474
Changes: 
 accountsservice (0.6.9-2) unstable; urgency=low
 .
   * Small change to reload_ck_history in order to make accountsservice
     filter by 'x11' session type (Closes: #624474);
     thanks to Josselin Mouette for the report and patch.
   * Bump Standards.
Checksums-Sha1: 
 1b5859ea9254070e7a58fd213539449df93bea2b 1536 accountsservice_0.6.9-2.dsc
 7de3dfbb5f49ca3bd6a2ffea67871415691a34e8 8811 
accountsservice_0.6.9-2.debian.tar.gz
 5909fbd36f9ea50e236e3c84e17716dbc3db2389 40626 
accountsservice_0.6.9-2_amd64.deb
 39b39197d56743c52a4f7b31f6850246690b8cd8 27650 
libaccountsservice0_0.6.9-2_amd64.deb
 7d4f06682abfe42b12903c07527a9e3dd6b9ff96 9962 
libaccountsservice-dev_0.6.9-2_amd64.deb
 fba0c616d43958f059142f0f82d308b32bbbed2f 6512 
gir1.2-accountservice-1.0_0.6.9-2_amd64.deb
Checksums-Sha256: 
 78f45ddce45dd6cc4352b6013f40a2729efb0f7062085bd4407479a51e4953a0 1536 
accountsservice_0.6.9-2.dsc
 ef3b4c9fbbeabd423880f6585114eb858199a87034e3da602578e908898738f9 8811 
accountsservice_0.6.9-2.debian.tar.gz
 264fe82e805722809ca63f6aeb159f25bb4e4a34b47553444c08a8406983c367 40626 
accountsservice_0.6.9-2_amd64.deb
 51f5f8c279e3a45dfc173a1be58ad2043f95437088f29e0c0065719039ca5066 27650 
libaccountsservice0_0.6.9-2_amd64.deb
 12d9295053113b7939be80c8b6102dc136d38257401fdd1d808c856680cb733b 9962 
libaccountsservice-dev_0.6.9-2_amd64.deb
 d75e1eaf402fa2e1bf6cbf1e554f0530b7bb04e2f32daa29450137d4750a523e 6512 
gir1.2-accountservice-1.0_0.6.9-2_amd64.deb
Files: 
 30534d093b512ecebc3759522c12cadb 1536 admin optional 
accountsservice_0.6.9-2.dsc
 189ba8467f568146e20104a51112f9a9 8811 admin optional 
accountsservice_0.6.9-2.debian.tar.gz
 bb44fc7bc511a57d25649bfc8769d181 40626 admin optional 
accountsservice_0.6.9-2_amd64.deb
 7494877e85cdf523d83540ae6dcc0ded 27650 libs optional 
libaccountsservice0_0.6.9-2_amd64.deb
 f2d021208ff392d6053af34649e1a1ba 9962 libdevel optional 
libaccountsservice-dev_0.6.9-2_amd64.deb
 2aba35774781f9e7a4dbf17f1452d971 6512 libs optional 
gir1.2-accountservice-1.0_0.6.9-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk25rNwACgkQRdSMfNz8P9ByWQCdEcGxvDrf1zw8SmYln/LErAmv
BTkAniUOYxKOGPTSAqxL5a11+UUsrJii
=n0p7
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to