Bug#602083: marked as done (Repeat flag is set also when pressing different keys quickly)

Thu, 19 May 2011 13:51:21 -0700 

Your message dated Thu, 19 May 2011 20:47:43 +0000
with message-id <[email protected]>
and subject line Bug#602083: fixed in inputlirc 19-1
has caused the Debian Bug report #602083,
regarding Repeat flag is set also when pressing different keys quickly
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
602083: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=602083
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message --- 
Package: inputlirc
Version: 16-1


Hello,
inputlirc increases the repeat flag even when two _different_ keys are pressed within the repeat time.
Here is an example output of "irw" where I pressed two different keys within the defined repeat-rate (300 ms in my case): 

# irw
47 0 KEY_KP7 event0
48 1 KEY_KP8 event0
I think this is not the intended behaviour. Since the second key has a different key code, the repeat flag should be zero for that second key. 

My system configuration:

# uname -a
Linux dockstar 2.6.32-5-kirkwood #1 Wed Oct 20 12:58:44 UTC 2010 armv5tel GNU/Linux 

# cat /etc/default/inputlirc
# Options to be passed to inputlirc.
EVENTS="/dev/input/event*"
OPTIONS="-m 55 -r 300"


I attached a small patch to correct this:

Index: inputlircd.c
===================================================================
--- inputlircd.c        (revision 15)
+++ inputlircd.c        (working copy)
@@ -70,6 +70,7 @@

 static long repeat_time = 0L;
 static struct timeval previous_input;
+static struct input_event previous_event;
 static int repeat = 0;

 static void *xalloc(size_t size) {
@@ -252,7 +253,7 @@

        struct timeval current;
        gettimeofday(&current, NULL);
-       if(time_elapsed(&previous_input, &current) < repeat_time)
+ if(event.code == previous_event.code && time_elapsed(&previous_input, &current) < repeat_time) 
                repeat++;
        else
                repeat = 0;
@@ -263,6 +264,7 @@
len = snprintf(message, sizeof message, "%x %x KEY_CODE_%d %s\n", event.code, repeat, event.code, evdev->name); 

        previous_input = current;
+       previous_event = event;
        
        for(client = clients; client; client = client->next) {
                if(write(client->fd, message, len) != len) {




Best regards,
Oliver

--- End Message ---
--- Begin Message --- 
Source: inputlirc
Source-Version: 19-1

We believe that the bug you reported is fixed in the latest version of
inputlirc, which is due to be installed in the Debian FTP archive:

inputlirc_19-1.diff.gz
  to main/i/inputlirc/inputlirc_19-1.diff.gz
inputlirc_19-1.dsc
  to main/i/inputlirc/inputlirc_19-1.dsc
inputlirc_19-1_amd64.deb
  to main/i/inputlirc/inputlirc_19-1_amd64.deb
inputlirc_19.orig.tar.gz
  to main/i/inputlirc/inputlirc_19.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guus Sliepen <[email protected]> (supplier of updated inputlirc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 19 May 2011 22:42:33 +0200
Source: inputlirc
Binary: inputlirc
Architecture: source amd64
Version: 19-1
Distribution: unstable
Urgency: low
Maintainer: Guus Sliepen <[email protected]>
Changed-By: Guus Sliepen <[email protected]>
Description: 
 inputlirc  - Zeroconf LIRC daemon using input event devices
Closes: 602083 617523
Changes: 
 inputlirc (19-1) unstable; urgency=low
 .
   * New upstream release.
     - Don't set repeat flag when two different keys are pressed in rapid
       succession. Closes: #602083
     - Change socket location to /var/run/lirc/lircd. Closes: #617523
   * Bump Standards-Version.
   * Add $remote_fs to the Required-Start and -Stop fields in the init script.
Checksums-Sha1: 
 ec5695c5edaaae7c65bb001849b352a6a028bc88 928 inputlirc_19-1.dsc
 d459ddf5c2b03e3978d4965ea36236cb37a70d24 7881 inputlirc_19.orig.tar.gz
 788b87df7b269efa022f30b1e48d06709d4faf8a 3216 inputlirc_19-1.diff.gz
 1d3def642c24d0fa2bac42b131d375f56d45d0a6 16958 inputlirc_19-1_amd64.deb
Checksums-Sha256: 
 1dd5bfa249ec31e545a68b8a36d9f82c0c9dacf59eb31c40d2c79f759387e7ab 928 
inputlirc_19-1.dsc
 70711af35e70ee16e5fe5a2be42714fc10364733d6ce61f51f4411f861eb61a4 7881 
inputlirc_19.orig.tar.gz
 6e716433f6b7939737031386d9eeca38a0307b5e7d2c38ac556fc8be888699e4 3216 
inputlirc_19-1.diff.gz
 e01196046e9550c110994593a5f8bdf86da42045a8771fee6d0b4c8849e123e9 16958 
inputlirc_19-1_amd64.deb
Files: 
 5ce3c04b6ac4e9a3ee84923c62ac2d75 928 utils extra inputlirc_19-1.dsc
 a2eb48495adc240d54b12b6e8c1c1a66 7881 utils extra inputlirc_19.orig.tar.gz
 4e61eace7c0a05b7c926f6aac3f40291 3216 utils extra inputlirc_19-1.diff.gz
 df4ce00bf0c8ab092ae7472201252611 16958 utils extra inputlirc_19-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk3VgRYACgkQAxLow12M2nvoXACfeUBSi1J5cWpMGK9Zd6/NVERK
e8wAn3QoPE/vuXJc2tVcxlEzX3wiJFcN
=D17d
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to