Your message dated Fri, 23 Sep 2011 09:22:02 +0200
with message-id <1316762522.3951.355.camel@pi0307572>
and subject line Re: Bug#642496: quadrapassel doesn't move the top line down
when removing lines
has caused the Debian Bug report #642496,
regarding quadrapassel doesn't move the top line down when removing lines
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
642496: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=642496
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gnome-games
Version: 2.30.2-2
Tags: patch
If you fill the entire playing field with blocks, then remove some lines
by completing a row, the top line stays stationary. It turns out to be
a simple fencepost error as the below patch (which fixes the problem)
demonstrates.
The easiest way to reproduce the problem is fill the entire left or
right column with blocks, right up to the top, then clear the bottom row.
What happens is this:
|x
|
|x
|x
|x
when it should look like this:
|
|x
|x
|x
|x
diff -urp gnome-games-2.30.2/quadrapassel/blockops.cpp
gnome-games-qpfix/quadrapassel/blockops.cpp
--- gnome-games-2.30.2/quadrapassel/blockops.cpp 2010-04-10
01:01:17.000000000 -0400
+++ gnome-games-qpfix/quadrapassel/blockops.cpp 2011-09-22 15:17:47.000000000
-0400
@@ -363,7 +363,7 @@ BlockOps::checkFullLines()
clutter_behaviour_remove_all (explode_fade_behaviour);
clutter_behaviour_remove_all (explode_scale_behaviour);
- for (int y = MIN (posy + 4, LINES); y > 0; --y)
+ for (int y = MIN (posy + 4, LINES); y >= 0; --y)
{
if (checkFullLine (y))
{
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--- End Message ---
--- Begin Message ---
Version: 1:3.0.1.1-1
Le jeudi 22 septembre 2011 à 20:37 -0600, Matthew Wilcox a écrit :
> If you fill the entire playing field with blocks, then remove some lines
> by completing a row, the top line stays stationary. It turns out to be
> a simple fencepost error as the below patch (which fixes the problem)
> demonstrates.
This is already fixed in experimental by
http://git.gnome.org/browse/gnome-games/commit/quadrapassel/blockops.cpp?id=fed9a37e62e7f69f8e410cb7f78126ee84c7ee22
Maybe I’ll backport this to stable, this is quite an important bug.
--
.''`. Josselin Mouette
: :' :
`. `'
`-
--- End Message ---
