Your message dated Fri, 23 Sep 2005 06:02:07 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#329094: fixed in libpam-mount 0.9.25-4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 19 Sep 2005 13:58:53 +0000
>From [EMAIL PROTECTED] Mon Sep 19 06:58:53 2005
Return-path: <[EMAIL PROTECTED]>
Received: from mx1.univ-lille2.fr (smtp.univ-lille2.fr) [194.254.117.4]
(postfix)
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EHMAX-0002Mz-00; Mon, 19 Sep 2005 06:58:53 -0700
Received: from localhost (localhost.localdomain [127.0.0.1])
by smtp.univ-lille2.fr (Postfix) with ESMTP id 9D1A73BB
for <[EMAIL PROTECTED]>; Mon, 19 Sep 2005 15:58:51 +0200 (CEST)
Received: from smtp.univ-lille2.fr ([127.0.0.1])
by localhost (mx1 [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
id 23750-06 for <[EMAIL PROTECTED]>;
Mon, 19 Sep 2005 15:58:50 +0200 (CEST)
Received: from tatabox.dmz.genopole-lille.fr (tatabox.genopole-lille.fr
[194.254.117.114])
by smtp.univ-lille2.fr (Postfix) with ESMTP id 51DC93B5
for <[EMAIL PROTECTED]>; Mon, 19 Sep 2005 15:58:50 +0200 (CEST)
Received: from proline.priv.genopole-lille.fr
([172.20.104.14] helo=localhost ident=Debian-exim)
by tatabox.dmz.genopole-lille.fr with esmtp (Exim 4.43)
id 1EHMAU-0005eD-4e
for [EMAIL PROTECTED]; Mon, 19 Sep 2005 15:58:50 +0200
Received: from jjss by localhost with local (Exim 4.50)
id 1EHMAU-0005Ap-0f
for [EMAIL PROTECTED]; Mon, 19 Sep 2005 15:58:50 +0200
Content-Type: multipart/mixed; boundary="===============1897879313=="
MIME-Version: 1.0
From: Julien Soula <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: libpam-mount: fails to check already mounted volume when links are used
X-Mailer: reportbug 3.8
Date: Mon, 19 Sep 2005 15:58:49 +0200
Message-Id: <[EMAIL PROTECTED]>
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at univ-lille2.fr
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
This is a multi-part MIME message sent by reportbug.
--===============1897879313==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: libpam-mount
Version: 0.9.25-3
Severity: normal
Tags: patch
if the mount point contains links then only the real path is stored in mtab.
So, at the next check, process fails to see that volume is already mounted and
mounts it twice.
Patch included doubles the path check : with original volume path and its
realpath.
In case of match with realpath, return the original volume path.
-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.6.11.11
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages libpam-mount depends on:
ii libc6 2.3.2.ds1-22 GNU C Library: Shared libraries an
ii libglib2.0-0 2.6.4-1 The GLib library of C routines
ii libssl0.9.7 0.9.7e-3 SSL shared libraries
ii mount 2.12p-4 Tools for mounting and manipulatin
ii zlib1g 1:1.2.2-4.sarge.2 compression library - runtime
-- no debconf information
--===============1897879313==
Content-Type: text/x-c; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="libpam-mount_0.9.25-3-x.diff"
diff -ru pam_mount-0.9.25/src/mount.c libpam-mount-0.9.25-x/src/mount.c
--- pam_mount-0.9.25/src/mount.c 2005-05-16 06:11:30.000000000 +0200
+++ libpam-mount-0.9.25-x/src/mount.c 2005-09-19 15:46:53.000000000 +0200
@@ -128,6 +128,7 @@
fmt_ptrn_t *vinfo)
{
char match[PATH_MAX + 1];
+ char realvolmntpt[PATH_MAX + 1];
int mounted = 0;
#if defined(__linux__)
FILE *mtab;
@@ -186,6 +187,15 @@
l0g("pam_mount: %s\n", "could not open /etc/mtab");
return -1;
}
+ if (!realpath(config->volume[vol].mountpoint, realvolmntpt)) {
+ w4rn("pam_mount: can't get realpath of volume (%s)\n",
config->volume[vol].mountpoint);
+ strncpy(realvolmntpt, config->volume[vol].mountpoint, PATH_MAX);
+ realvolmntpt[PATH_MAX] = 0x00;
+ } else {
+ realvolmntpt[PATH_MAX] = 0x00;
+ w4rn("pam_mount: realpath of volume (%s) is (%s)\n",
config->volume[vol].mountpoint, realvolmntpt);
+ }
+
w4rn("pam_mount: checking to see if %s is already mounted at %s\n",
match, config->volume[vol].mountpoint);
while ((mtab_record = getmntent(mtab)) != NULL) {
@@ -215,9 +225,14 @@
strncpy(mntpt, mtab_record->mnt_dir, PATH_MAX);
mntpt[PATH_MAX] = 0x00;
mounted = 1;
- if (!strcmp(mtab_record->mnt_dir,
- config->volume[vol].mountpoint)) {
- strncpy(mntpt, mtab_record->mnt_dir,
+ if (
+ (!strcmp(mtab_record->mnt_dir,
+ config->volume[vol].mountpoint))
+ ||
+ (!strcmp(mtab_record->mnt_dir,
+ realvolmntpt))
+ ) {
+ strncpy(mntpt, config->volume[vol].mountpoint,
PATH_MAX);
mntpt[PATH_MAX] = 0x00;
break;
--===============1897879313==--
---------------------------------------
Received: (at 329094-close) by bugs.debian.org; 23 Sep 2005 13:08:11 +0000
>From [EMAIL PROTECTED] Fri Sep 23 06:08:11 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1EInBn-0006mW-00; Fri, 23 Sep 2005 06:02:07 -0700
From: Bastian Kleineidam <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#329094: fixed in libpam-mount 0.9.25-4
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Fri, 23 Sep 2005 06:02:07 -0700
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 3
Source: libpam-mount
Source-Version: 0.9.25-4
We believe that the bug you reported is fixed in the latest version of
libpam-mount, which is due to be installed in the Debian FTP archive:
libpam-mount_0.9.25-4.diff.gz
to pool/main/libp/libpam-mount/libpam-mount_0.9.25-4.diff.gz
libpam-mount_0.9.25-4.dsc
to pool/main/libp/libpam-mount/libpam-mount_0.9.25-4.dsc
libpam-mount_0.9.25-4_i386.deb
to pool/main/libp/libpam-mount/libpam-mount_0.9.25-4_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bastian Kleineidam <[EMAIL PROTECTED]> (supplier of updated libpam-mount
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 23 Sep 2005 14:52:38 +0200
Source: libpam-mount
Binary: libpam-mount
Architecture: source i386
Version: 0.9.25-4
Distribution: unstable
Urgency: low
Maintainer: Bastian Kleineidam <[EMAIL PROTECTED]>
Changed-By: Bastian Kleineidam <[EMAIL PROTECTED]>
Description:
libpam-mount - a PAM module that can mount volumes for a user session
Closes: 276322 327614 329094
Changes:
libpam-mount (0.9.25-4) unstable; urgency=low
.
* Added fsck to the default allowed options. Also add it to one of the
example mount configs to give users a hint that this option is
useful for home directory mounts.
* Allow to specify a group name as user for volume mounts with
'@group'. This lets all users in the given group mount a volume.
This option is only allowed in the global config. (Closes: #276322)
* Allow relative pathnames with umount.crypt (Closes: #327614)
* New patch 38_mount_links thanks to Julien Soula.
(Closes: #329094) - fails to check already mounted volume when links
are used
Files:
a66bff7fdf4c9435de6e859f1a490eaa 678 admin extra libpam-mount_0.9.25-4.dsc
35802a6724a945d3eb544c50c2c7bc7b 31227 admin extra
libpam-mount_0.9.25-4.diff.gz
7b8584f351929dcb20e2753658ab793b 101790 admin extra
libpam-mount_0.9.25-4_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFDM/uGeBwlBDLsbz4RAjMpAJ9D/lLPaY2WA+TJTVI2oiSxnHPaMQCfUA7U
D2KqcKkMPnmfA7+7kecflVI=
=GTWQ
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
