Your message dated Thu, 03 Nov 2011 12:17:12 +0000
with message-id <[email protected]>
and subject line Bug#619014: fixed in bash-completion 1:1.90-1
has caused the Debian Bug report #619014,
regarding bash-completion: Bash completion whitelisting returns no results when
it could return some that do not match
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
619014: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=619014
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: bash-completion
Version: 1:1.3-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu natty ubuntu-patch
*** /tmp/tmpiebbIm
I've submitted this patch to Ubuntu as well. The original bug report is
available here:
https://launchpad.net/bugs/533985
The idea is simply that if the filename whitelist passed to _filedir
fails to produce any results, its more useful to the user to fall
back to unfiltered results than give them nothing. This makes the bash
completion more adaptable as programs change underneath them, and solves
the issue where a program like sqlite3 doesn't actually care at all about
extensions and the general conventions used have just been encoded in
the bash completion.
* Drop whitelists if they fail to produce any results (LP: #533985)
Thanks for considering the patch.
-- System Information:
Debian Release: squeeze/sid
APT prefers natty-updates
APT policy: (500, 'natty-updates'), (500, 'natty-security'), (500, 'natty')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.38-6-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru bash-completion-1.3/debian/changelog bash-completion-1.3/debian/changelog
diff -Nru bash-completion-1.3/debian/patches/disable-whitelist-on-fail.patch bash-completion-1.3/debian/patches/disable-whitelist-on-fail.patch
--- bash-completion-1.3/debian/patches/disable-whitelist-on-fail.patch 1969-12-31 16:00:00.000000000 -0800
+++ bash-completion-1.3/debian/patches/disable-whitelist-on-fail.patch 2011-03-20 06:00:50.000000000 -0700
@@ -0,0 +1,20 @@
+Author: Clint Byrum <[email protected]>
+Subject: disable whitelists when they fail to produce results
+Bug-Ubuntu: https://launchpad.net/bugs/533985
+
+Index: bash-completion-1.3/bash_completion
+===================================================================
+--- bash-completion-1.3.orig/bash_completion 2011-03-20 05:36:36.717277995 -0700
++++ bash-completion-1.3/bash_completion 2011-03-20 05:56:15.748086091 -0700
+@@ -661,6 +661,11 @@
+ fi
+ [ ${#toks[@]} -ne 0 ] && _compopt_o_filenames
+
++ # If the filter failed to produce anything, try w/o it (LP: #533985)
++ if [[ -n "$1" ]] && [[ "$1" != -d ]] && [[ ${#toks[@]} -lt 1 ]] ; then
++ toks=( ${toks[@]-} $( compgen -f -X -- $quoted) )
++ fi
++
+ COMPREPLY=( "${COMPREPLY[@]}" "${toks[@]}" )
+ } # _filedir()
+
diff -Nru bash-completion-1.3/debian/patches/series bash-completion-1.3/debian/patches/series
--- bash-completion-1.3/debian/patches/series 2011-02-08 06:52:30.000000000 -0800
+++ bash-completion-1.3/debian/patches/series 2011-03-20 05:36:29.000000000 -0700
@@ -1,2 +1,3 @@
disable-avahi-browse.diff
apt-get-changelog.patch
+disable-whitelist-on-fail.patch
--- End Message ---
--- Begin Message ---
Source: bash-completion
Source-Version: 1:1.90-1
We believe that the bug you reported is fixed in the latest version of
bash-completion, which is due to be installed in the Debian FTP archive:
bash-completion_1.90-1.debian.tar.gz
to main/b/bash-completion/bash-completion_1.90-1.debian.tar.gz
bash-completion_1.90-1.dsc
to main/b/bash-completion/bash-completion_1.90-1.dsc
bash-completion_1.90-1_all.deb
to main/b/bash-completion/bash-completion_1.90-1_all.deb
bash-completion_1.90.orig.tar.bz2
to main/b/bash-completion/bash-completion_1.90.orig.tar.bz2
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
David Paleino <[email protected]> (supplier of updated bash-completion package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 03 Nov 2011 13:03:51 +0100
Source: bash-completion
Binary: bash-completion
Architecture: source all
Version: 1:1.90-1
Distribution: experimental
Urgency: low
Maintainer: Bash Completion Maintainers
<[email protected]>
Changed-By: David Paleino <[email protected]>
Description:
bash-completion - programmable completion for the bash shell
Closes: 577933 593835 604393 615134 618734 619014 622383 623680 625234 642526
Changes:
bash-completion (1:1.90-1) experimental; urgency=low
.
* bash-completion 2 preview: dynamic loading of completions
- optionally fallback to generic file completion if _filedir
returns nothing (Closes: #619014, LP: #533985)
- various fixes (Closes: #622383)
- apt: add 'download' to subcommands (Closes: #625234, LP: #720541)
- aptitude: add 'versions' command (Closes: #604393)
- dpkg-query: use the 'dpkg' completion (Closes: #642526)
- lintian: remove --unpack-level (Closes: #623680)
- rrdtool: complete filenames after commands (Closes: #577933)
- provide profile.d hook for per user disabling of bash_completion
(Closes: #593835)
- mutt: support tildes when recursively sourcing muttrc files
(Closes: #615134)
- tar: improve tar *[cr]*f completions (Closes: #618734)
* More checks in update-bash-completion: avoid unnecessary
sourcing of completion if symlink already exists
* Add message for users before they report a bug (debian/bug-presubj),
I'm kind of fed-up with bugs caused by acroread.sh :/
* Removed patches merged upstream
* Drop trigger-based completion loading
* Standards-Version bump to 3.9.2, no changes needed
Checksums-Sha1:
748b796aa5f70f17b2c3ec449dd7a8d66933bb8a 1394 bash-completion_1.90-1.dsc
aa1a1f4e34bff93f8227c1a200de310a04a21e86 228640
bash-completion_1.90.orig.tar.bz2
e5deb79d3aa91dff60baee0d4f1675fc5fd6ea2b 13057
bash-completion_1.90-1.debian.tar.gz
64a6a900971b2bc4d6d8706345f3037c81b85762 179058 bash-completion_1.90-1_all.deb
Checksums-Sha256:
78c827e512975c885b3cb09a2a50676d2f8bcd3c81b712a18035b288bfa0d92a 1394
bash-completion_1.90-1.dsc
293084b7584e89734002a49688ca9aea2bab16ca4750b30f66b62a373750c41c 228640
bash-completion_1.90.orig.tar.bz2
06975fe1a3291aadad7489d381183bcc64731f6b256647b8a5e277bb16ae97a8 13057
bash-completion_1.90-1.debian.tar.gz
4f78b12ab95b5ed24c8fe63e26d9f1635f189ccb9c7f7b503af101c0dfe92fe0 179058
bash-completion_1.90-1_all.deb
Files:
adf23b480b86c55d9e337258164785a0 1394 shells standard
bash-completion_1.90-1.dsc
82635839d83074eba923822fd584490c 228640 shells standard
bash-completion_1.90.orig.tar.bz2
ab9637c3c2aea423af97932b19bdc832 13057 shells standard
bash-completion_1.90-1.debian.tar.gz
e43e91227a8d739a095577d51a1e0b78 179058 shells standard
bash-completion_1.90-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk6yhD8ACgkQ5qqQFxOSsXQUSACfdui594rcT9CfiI3CyWfl60xa
UpMAoKbynog3IF+e2EOHcrFL6VBNbHPO
=Wi2f
-----END PGP SIGNATURE-----
--- End Message ---
