Your message dated Mon, 26 Sep 2005 14:47:10 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#306983: fixed in splay 0.9.5.2-7
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 29 Apr 2005 19:41:31 +0000
>From [EMAIL PROTECTED] Fri Apr 29 12:41:30 2005
Return-path: <[EMAIL PROTECTED]>
Received: from mailfe07.swip.net (swip.net) [212.247.154.193]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DRbMg-0005mq-00; Fri, 29 Apr 2005 12:41:30 -0700
X-T2-Posting-ID: dCnToGxhL58ot4EWY8b+QGwMembwLoz1X2yB7MdtIiA=
Received: from [83.179.18.76] (HELO bouh.famille.thibault.fr)
by mailfe07.swip.net (CommuniGate Pro SMTP 4.3c5)
with ESMTPS id 157175232; Fri, 29 Apr 2005 21:40:58 +0200
Received: from samy by bouh.famille.thibault.fr with local (Exim 4.50)
id 1DRbM2-0001nA-Eg; Fri, 29 Apr 2005 21:40:50 +0200
Date: Fri, 29 Apr 2005 21:40:49 +0200
From: Samuel Thibault <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Bcc: Samuel Thibault <[EMAIL PROTECTED]>
Subject: splay: Shuffle is not exactly randomized
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Reportbug-Version: 3.11
User-Agent: Mutt/1.5.6i-nntp
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: splay
Version: 0.9.5.2-6
Severity: minor
Tags: patch, upstream
Hi,
The shuffle algorithm is not exactly randomizing, here is a patch:
diff -urN splay-0.9.5.2/apps/common.cc splay-mine/apps/common.cc
--- splay-0.9.5.2/apps/common.cc 2001-03-17 19:57:12.000000000 +0100
+++ splay-mine/apps/common.cc 2005-04-29 21:36:04.000000000 +0200
@@ -186,7 +186,9 @@
for(i=splay_listsize-1;i>0;i--)
{
- p=random()%i;
+ p=random()%(i+1);
+
+ if(p==i)continue;
tmp=splay_list[p];
splay_list[p]=splay_list[i];
Because else, the last song in the list would *never* appear last once
shuffled, for instance.
Regards,
Samuel
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (100, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.11
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)
Versions of packages splay depends on:
ii libc6 2.3.2.ds1-21 GNU C Library: Shared libraries an
ii libgcc1 1:4.0-0pre4 GCC support library
ii libid3-3.8.3 3.8.3-4.1 Library for manipulating ID3v1 and
ii libstdc++5 1:3.3.5-12 The GNU Standard C++ Library v3
-- no debconf information
--
Samuel Thibault <[EMAIL PROTECTED]>
<N> je déteste import
<N> parce que lorsque tu fais du python et que tu oublies le #!/bin/env python
et que tu mets le fichier exécutable
<N> import est exécuté
-+- #ens-mim - ben déteste python plutôt -+-
---------------------------------------
Received: (at 306983-close) by bugs.debian.org; 26 Sep 2005 21:48:12 +0000
>From [EMAIL PROTECTED] Mon Sep 26 14:48:12 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1EK0oY-00063x-00; Mon, 26 Sep 2005 14:47:10 -0700
From: John Hedges <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#306983: fixed in splay 0.9.5.2-7
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Mon, 26 Sep 2005 14:47:10 -0700
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: splay
Source-Version: 0.9.5.2-7
We believe that the bug you reported is fixed in the latest version of
splay, which is due to be installed in the Debian FTP archive:
splay_0.9.5.2-7.diff.gz
to pool/main/s/splay/splay_0.9.5.2-7.diff.gz
splay_0.9.5.2-7.dsc
to pool/main/s/splay/splay_0.9.5.2-7.dsc
splay_0.9.5.2-7_i386.deb
to pool/main/s/splay/splay_0.9.5.2-7_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
John Hedges <[EMAIL PROTECTED]> (supplier of updated splay package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Wed, 14 Sep 2005 10:30:00 +0100
Source: splay
Binary: splay
Architecture: source i386
Version: 0.9.5.2-7
Distribution: unstable
Urgency: low
Maintainer: John Hedges <[EMAIL PROTECTED]>
Changed-By: John Hedges <[EMAIL PROTECTED]>
Description:
splay - Sound player for MPEG-1,2 layer 1,2,3
Closes: 306983 312765 328215
Changes:
splay (0.9.5.2-7) unstable; urgency=low
.
* Fixes random shuffle bug (closes: #306983).
Thanks to Samuel Thibault for supplying this patch.
* Repaired typo in man page (closes: #312765).
* Fixes dependency on outdated libid3 package,
now depends on libid3-3.8.3c2 (closes: #328215).
Files:
cbf671b7f84b55eb2ba1ef5fe1e500f5 577 sound optional splay_0.9.5.2-7.dsc
e12fc32c381a35d8d2f8164a40904d36 9800 sound optional splay_0.9.5.2-7.diff.gz
e4920aadaeb796c2d44e9eb9b24a2b88 51766 sound optional splay_0.9.5.2-7_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDOGifpdwBkPlyvgMRAkZqAJ0e/hndMyf19rq0/qIRiIQhJ3o8QACfQyVf
NNMztR849+N9EG9iZvTnb6k=
=/9ea
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
