Your message dated Fri, 02 Dec 2011 21:06:42 +0000
with message-id <[email protected]>
and subject line Bug#646400: fixed in git-buildpackage 0.6.0~git20111202
has caused the Debian Bug report #646400,
regarding git-buildpackage: qbp-pq truncates a valid patch
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
646400: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=646400
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: git-buildpackage
Version: 0.5.32
Severity: important

gbp-pq command contains the following code:
  if in_patch:
            if line.startswith('-- '):
                # Found final signature, we're done:
                tmp.write(line)
                break

The assumption written in the comment is incorrect. '-- ' can be a part
of a valid patch, e.g.:
-- original text
+- patched text 
In such a case the above code incorrectly truncates the file it
generates.


For a real-life example please do the following:

gbp-clone git://anonscm.debian.org/users/robert/manpages-pl.git
cd manpages-pl
gbp-pq import
gbp-pq export
quilt push -a # this fails

(Also note that gpp-pq renames `file.patch' into `file.patch.patch'.
I belive it could work smarter, but it's another issue, quite a minor
one).

Regards,
robert




-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (200, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-2-686 (SMP w/1 CPU core)
Locale: LANG=pl_PL, LC_CTYPE=pl_PL (charmap=ISO-8859-2)
Shell: /bin/sh linked to /bin/dash

Versions of packages git-buildpackage depends on:
ii  devscripts       2.11.1   
ii  git [git-core]   1:1.7.7-2
ii  git-core         1:1.7.7-2
ii  python           2.7.2-9  
ii  python-dateutil  1.5-1    
ii  python2.6        2.6.7-4  
ii  python2.7        2.7.2-6  

Versions of packages git-buildpackage recommends:
ii  cowbuilder    0.65
ii  pristine-tar  1.15

Versions of packages git-buildpackage suggests:
ii  python-notify  0.1.1-3
ii  unzip          6.0-5  

-- Configuration Files:
/etc/git-buildpackage/gbp.conf changed [not included]

-- no debconf information



--- End Message ---
--- Begin Message ---
Source: git-buildpackage
Source-Version: 0.6.0~git20111202

We believe that the bug you reported is fixed in the latest version of
git-buildpackage, which is due to be installed in the Debian FTP archive:

git-buildpackage_0.6.0~git20111202.dsc
  to main/g/git-buildpackage/git-buildpackage_0.6.0~git20111202.dsc
git-buildpackage_0.6.0~git20111202.tar.gz
  to main/g/git-buildpackage/git-buildpackage_0.6.0~git20111202.tar.gz
git-buildpackage_0.6.0~git20111202_all.deb
  to main/g/git-buildpackage/git-buildpackage_0.6.0~git20111202_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guido Günther <[email protected]> (supplier of updated git-buildpackage package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 02 Dec 2011 19:19:51 +0100
Source: git-buildpackage
Binary: git-buildpackage
Architecture: source all
Version: 0.6.0~git20111202
Distribution: experimental
Urgency: low
Maintainer: Guido Günther <[email protected]>
Changed-By: Guido Günther <[email protected]>
Description: 
 git-buildpackage - Suite to help with Debian packages in Git repositories
Closes: 564791 582775 640982 643752 646400
Changes: 
 git-buildpackage (0.6.0~git20111202) experimental; urgency=low
 .
   [ Guido Günther ]
   * [3a3539a] Document that gbp-create-repo is noninteractive
     (Closes: #643752)
   * [bf397fc] gbp-pq: Properly check for start of signature (Closes: #646400)
   * [718f0c3] gbp-pq: Strip .patch and .diff when importing patches without a
     subject
   * [3fcf009] command_wrappers.Command: Don't print several error lines
   * [37e8310] Allow to import upstream tarballs into bare repositories
     (Closes: #582775)
   * [abf90ab] Allow to import Debian packages into bare repositories
   * [8c22803] gbp-pull: massive speedup by just updating the ref to the
     remote's SHA1 instead of checking out the branch and doing a fast-forward
     merge.
   * [af07c40] gbp-pq: Instead of looking for the signature don't let git
     generate it. Thanks to Robert Luberda
   * [69d348c] Support postexport hooks. Heavily based on a patch by Jan Čapek
     (Closes: #640982)
   * [030744d] Parse the changelog of the exported tree instead of the working
     copy when using --export. This reduces the number of options needed when
     using an export dir since the correct tarball is now being created without
     additional options. (Closes: #564791)
   * GitRepository: Lots of api, documentation and test updates replacing Git*
     classes by GitRepository methods. Check the apidocs for details.
   * [7168735] Switch to dh
 .
   [ Jan Čapek ]
   * [d2c1033] Documentation update for --git-postexport, --git-postbuild typo
     fix
   * [f7a6b07] Additional documentation for postexport hook in the manual - the
     documentation now provides sample postexport script and gbp.conf
Checksums-Sha1: 
 664010bcf5c32f2aff0e80ae5a8ec9c193f1428a 1243 
git-buildpackage_0.6.0~git20111202.dsc
 7ad2047fc51757174e28ab3e633095828145f0d3 124341 
git-buildpackage_0.6.0~git20111202.tar.gz
 0e99ea9601ab68da3fbd4d971080307c4033d22c 254514 
git-buildpackage_0.6.0~git20111202_all.deb
Checksums-Sha256: 
 ed4917ccf99abe441e5624568f1641113b41f5b4c6f1345d10942dd296193081 1243 
git-buildpackage_0.6.0~git20111202.dsc
 c86fd344ac8944b615f3c64f7ad944f560aeeac5fcf669fb64053195752fe67c 124341 
git-buildpackage_0.6.0~git20111202.tar.gz
 b2942d14a7e755f2e9ff48af319ba5ba28f85ac98b9841ea36c1927575502394 254514 
git-buildpackage_0.6.0~git20111202_all.deb
Files: 
 814ef0f53b9ef5660088588ab6bb9139 1243 vcs optional 
git-buildpackage_0.6.0~git20111202.dsc
 827802ce0f6b27b29830c5bc1c359f87 124341 vcs optional 
git-buildpackage_0.6.0~git20111202.tar.gz
 ea6c87076cbc68c572b7578b91e88ad2 254514 vcs optional 
git-buildpackage_0.6.0~git20111202_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFO2TTwn88szT8+ZCYRAnH3AJ9gOQ4MV+RbzRZZ+4jEq31fA5UhiQCfcsKC
OrklteKzOGph4DEb9jGd56o=
=qAST
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to